[experiment] Remove work_stealing experiment configuration (#34468)

Cleanup after https://github.com/grpc/grpc/pull/34315
pull/34397/head^2
AJ Heller 1 year ago committed by GitHub
parent 59d886cb5c
commit 15a8aebc6d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 9
      bazel/experiments.bzl
  2. 15
      src/core/lib/experiments/experiments.cc
  3. 11
      src/core/lib/experiments/experiments.h
  4. 7
      src/core/lib/experiments/experiments.yaml
  5. 2
      src/core/lib/experiments/rollouts.yaml

@ -59,9 +59,6 @@ EXPERIMENTS = {
], ],
}, },
"on": { "on": {
"core_end2end_test": [
"work_stealing",
],
"cpp_lb_end2end_test": [ "cpp_lb_end2end_test": [
"round_robin_delegate_to_pick_first", "round_robin_delegate_to_pick_first",
"wrr_delegate_to_pick_first", "wrr_delegate_to_pick_first",
@ -124,9 +121,6 @@ EXPERIMENTS = {
], ],
}, },
"on": { "on": {
"core_end2end_test": [
"work_stealing",
],
"cpp_lb_end2end_test": [ "cpp_lb_end2end_test": [
"round_robin_delegate_to_pick_first", "round_robin_delegate_to_pick_first",
"wrr_delegate_to_pick_first", "wrr_delegate_to_pick_first",
@ -199,9 +193,6 @@ EXPERIMENTS = {
], ],
}, },
"on": { "on": {
"core_end2end_test": [
"work_stealing",
],
"cpp_lb_end2end_test": [ "cpp_lb_end2end_test": [
"round_robin_delegate_to_pick_first", "round_robin_delegate_to_pick_first",
"wrr_delegate_to_pick_first", "wrr_delegate_to_pick_first",

@ -73,9 +73,6 @@ const char* const additional_constraints_trace_record_callops = "{}";
const char* const description_event_engine_dns = const char* const description_event_engine_dns =
"If set, use EventEngine DNSResolver for client channel resolution"; "If set, use EventEngine DNSResolver for client channel resolution";
const char* const additional_constraints_event_engine_dns = "{}"; const char* const additional_constraints_event_engine_dns = "{}";
const char* const description_work_stealing =
"If set, use a work stealing thread pool implementation in EventEngine";
const char* const additional_constraints_work_stealing = "{}";
const char* const description_client_privacy = "If set, client privacy"; const char* const description_client_privacy = "If set, client privacy";
const char* const additional_constraints_client_privacy = "{}"; const char* const additional_constraints_client_privacy = "{}";
const char* const description_canary_client_privacy = const char* const description_canary_client_privacy =
@ -157,8 +154,6 @@ const ExperimentMetadata g_experiment_metadata[] = {
additional_constraints_trace_record_callops, false, true}, additional_constraints_trace_record_callops, false, true},
{"event_engine_dns", description_event_engine_dns, {"event_engine_dns", description_event_engine_dns,
additional_constraints_event_engine_dns, false, false}, additional_constraints_event_engine_dns, false, false},
{"work_stealing", description_work_stealing,
additional_constraints_work_stealing, true, false},
{"client_privacy", description_client_privacy, {"client_privacy", description_client_privacy,
additional_constraints_client_privacy, false, false}, additional_constraints_client_privacy, false, false},
{"canary_client_privacy", description_canary_client_privacy, {"canary_client_privacy", description_canary_client_privacy,
@ -243,9 +238,6 @@ const char* const additional_constraints_trace_record_callops = "{}";
const char* const description_event_engine_dns = const char* const description_event_engine_dns =
"If set, use EventEngine DNSResolver for client channel resolution"; "If set, use EventEngine DNSResolver for client channel resolution";
const char* const additional_constraints_event_engine_dns = "{}"; const char* const additional_constraints_event_engine_dns = "{}";
const char* const description_work_stealing =
"If set, use a work stealing thread pool implementation in EventEngine";
const char* const additional_constraints_work_stealing = "{}";
const char* const description_client_privacy = "If set, client privacy"; const char* const description_client_privacy = "If set, client privacy";
const char* const additional_constraints_client_privacy = "{}"; const char* const additional_constraints_client_privacy = "{}";
const char* const description_canary_client_privacy = const char* const description_canary_client_privacy =
@ -327,8 +319,6 @@ const ExperimentMetadata g_experiment_metadata[] = {
additional_constraints_trace_record_callops, false, true}, additional_constraints_trace_record_callops, false, true},
{"event_engine_dns", description_event_engine_dns, {"event_engine_dns", description_event_engine_dns,
additional_constraints_event_engine_dns, false, false}, additional_constraints_event_engine_dns, false, false},
{"work_stealing", description_work_stealing,
additional_constraints_work_stealing, true, false},
{"client_privacy", description_client_privacy, {"client_privacy", description_client_privacy,
additional_constraints_client_privacy, false, false}, additional_constraints_client_privacy, false, false},
{"canary_client_privacy", description_canary_client_privacy, {"canary_client_privacy", description_canary_client_privacy,
@ -413,9 +403,6 @@ const char* const additional_constraints_trace_record_callops = "{}";
const char* const description_event_engine_dns = const char* const description_event_engine_dns =
"If set, use EventEngine DNSResolver for client channel resolution"; "If set, use EventEngine DNSResolver for client channel resolution";
const char* const additional_constraints_event_engine_dns = "{}"; const char* const additional_constraints_event_engine_dns = "{}";
const char* const description_work_stealing =
"If set, use a work stealing thread pool implementation in EventEngine";
const char* const additional_constraints_work_stealing = "{}";
const char* const description_client_privacy = "If set, client privacy"; const char* const description_client_privacy = "If set, client privacy";
const char* const additional_constraints_client_privacy = "{}"; const char* const additional_constraints_client_privacy = "{}";
const char* const description_canary_client_privacy = const char* const description_canary_client_privacy =
@ -497,8 +484,6 @@ const ExperimentMetadata g_experiment_metadata[] = {
additional_constraints_trace_record_callops, false, true}, additional_constraints_trace_record_callops, false, true},
{"event_engine_dns", description_event_engine_dns, {"event_engine_dns", description_event_engine_dns,
additional_constraints_event_engine_dns, false, false}, additional_constraints_event_engine_dns, false, false},
{"work_stealing", description_work_stealing,
additional_constraints_work_stealing, true, false},
{"client_privacy", description_client_privacy, {"client_privacy", description_client_privacy,
additional_constraints_client_privacy, false, false}, additional_constraints_client_privacy, false, false},
{"canary_client_privacy", description_canary_client_privacy, {"canary_client_privacy", description_canary_client_privacy,

@ -72,8 +72,6 @@ inline bool IsEventEngineListenerEnabled() { return false; }
inline bool IsScheduleCancellationOverWriteEnabled() { return false; } inline bool IsScheduleCancellationOverWriteEnabled() { return false; }
inline bool IsTraceRecordCallopsEnabled() { return false; } inline bool IsTraceRecordCallopsEnabled() { return false; }
inline bool IsEventEngineDnsEnabled() { return false; } inline bool IsEventEngineDnsEnabled() { return false; }
#define GRPC_EXPERIMENT_IS_INCLUDED_WORK_STEALING
inline bool IsWorkStealingEnabled() { return true; }
inline bool IsClientPrivacyEnabled() { return false; } inline bool IsClientPrivacyEnabled() { return false; }
inline bool IsCanaryClientPrivacyEnabled() { return false; } inline bool IsCanaryClientPrivacyEnabled() { return false; }
inline bool IsServerPrivacyEnabled() { return false; } inline bool IsServerPrivacyEnabled() { return false; }
@ -109,8 +107,6 @@ inline bool IsEventEngineListenerEnabled() { return false; }
inline bool IsScheduleCancellationOverWriteEnabled() { return false; } inline bool IsScheduleCancellationOverWriteEnabled() { return false; }
inline bool IsTraceRecordCallopsEnabled() { return false; } inline bool IsTraceRecordCallopsEnabled() { return false; }
inline bool IsEventEngineDnsEnabled() { return false; } inline bool IsEventEngineDnsEnabled() { return false; }
#define GRPC_EXPERIMENT_IS_INCLUDED_WORK_STEALING
inline bool IsWorkStealingEnabled() { return true; }
inline bool IsClientPrivacyEnabled() { return false; } inline bool IsClientPrivacyEnabled() { return false; }
inline bool IsCanaryClientPrivacyEnabled() { return false; } inline bool IsCanaryClientPrivacyEnabled() { return false; }
inline bool IsServerPrivacyEnabled() { return false; } inline bool IsServerPrivacyEnabled() { return false; }
@ -146,8 +142,6 @@ inline bool IsEventEngineListenerEnabled() { return false; }
inline bool IsScheduleCancellationOverWriteEnabled() { return false; } inline bool IsScheduleCancellationOverWriteEnabled() { return false; }
inline bool IsTraceRecordCallopsEnabled() { return false; } inline bool IsTraceRecordCallopsEnabled() { return false; }
inline bool IsEventEngineDnsEnabled() { return false; } inline bool IsEventEngineDnsEnabled() { return false; }
#define GRPC_EXPERIMENT_IS_INCLUDED_WORK_STEALING
inline bool IsWorkStealingEnabled() { return true; }
inline bool IsClientPrivacyEnabled() { return false; } inline bool IsClientPrivacyEnabled() { return false; }
inline bool IsCanaryClientPrivacyEnabled() { return false; } inline bool IsCanaryClientPrivacyEnabled() { return false; }
inline bool IsServerPrivacyEnabled() { return false; } inline bool IsServerPrivacyEnabled() { return false; }
@ -184,7 +178,6 @@ enum ExperimentIds {
kExperimentIdScheduleCancellationOverWrite, kExperimentIdScheduleCancellationOverWrite,
kExperimentIdTraceRecordCallops, kExperimentIdTraceRecordCallops,
kExperimentIdEventEngineDns, kExperimentIdEventEngineDns,
kExperimentIdWorkStealing,
kExperimentIdClientPrivacy, kExperimentIdClientPrivacy,
kExperimentIdCanaryClientPrivacy, kExperimentIdCanaryClientPrivacy,
kExperimentIdServerPrivacy, kExperimentIdServerPrivacy,
@ -255,10 +248,6 @@ inline bool IsTraceRecordCallopsEnabled() {
inline bool IsEventEngineDnsEnabled() { inline bool IsEventEngineDnsEnabled() {
return IsExperimentEnabled(kExperimentIdEventEngineDns); return IsExperimentEnabled(kExperimentIdEventEngineDns);
} }
#define GRPC_EXPERIMENT_IS_INCLUDED_WORK_STEALING
inline bool IsWorkStealingEnabled() {
return IsExperimentEnabled(kExperimentIdWorkStealing);
}
#define GRPC_EXPERIMENT_IS_INCLUDED_CLIENT_PRIVACY #define GRPC_EXPERIMENT_IS_INCLUDED_CLIENT_PRIVACY
inline bool IsClientPrivacyEnabled() { inline bool IsClientPrivacyEnabled() {
return IsExperimentEnabled(kExperimentIdClientPrivacy); return IsExperimentEnabled(kExperimentIdClientPrivacy);

@ -118,13 +118,6 @@
owner: yijiem@google.com owner: yijiem@google.com
test_tags: ["cancel_ares_query_test", "resolver_component_tests_runner_invoker"] test_tags: ["cancel_ares_query_test", "resolver_component_tests_runner_invoker"]
allow_in_fuzzing_config: false allow_in_fuzzing_config: false
- name: work_stealing
description:
If set, use a work stealing thread pool implementation in EventEngine
expiry: 2023/11/01
owner: hork@google.com
test_tags: ["core_end2end_test"]
allow_in_fuzzing_config: false
- name: client_privacy - name: client_privacy
description: description:
If set, client privacy If set, client privacy

@ -76,8 +76,6 @@
# TODO(yijiem): resolve when the WindowsEventEngine DNS Resolver is # TODO(yijiem): resolve when the WindowsEventEngine DNS Resolver is
# implemented # implemented
windows: broken windows: broken
- name: work_stealing
default: true
- name: work_serializer_dispatch - name: work_serializer_dispatch
default: false default: false
- name: client_privacy - name: client_privacy

Loading…
Cancel
Save