From 812c5e10dfffab5d4d14181d23e534e0891539a6 Mon Sep 17 00:00:00 2001 From: ctiller <10120821+ctiller@users.noreply.github.com> Date: Wed, 8 May 2024 17:57:43 +0000 Subject: [PATCH 1/2] Automated change: Fix sanity tests --- src/core/lib/surface/call.cc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/core/lib/surface/call.cc b/src/core/lib/surface/call.cc index 8ae57cd6141..cd29138495e 100644 --- a/src/core/lib/surface/call.cc +++ b/src/core/lib/surface/call.cc @@ -3390,7 +3390,8 @@ class MaybeOpImpl { // Once we express our surface API in terms of core internal types this whole // dance will go away. template -auto MaybeOp(const grpc_op* ops, const std::array& idxs, SetupFn setup) { +auto MaybeOp(const grpc_op* ops, const std::array& idxs, + SetupFn setup) { using SetupResult = decltype(std::declval()(grpc_op())); if (idxs[op_type] == 255) { return MaybeOpImpl(); From 51c39fe3f2a5ddde8da3c71ca6a3b09ed7899a3a Mon Sep 17 00:00:00 2001 From: Craig Tiller Date: Wed, 8 May 2024 11:29:00 -0700 Subject: [PATCH 2/2] fix --- src/core/lib/surface/call.cc | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/core/lib/surface/call.cc b/src/core/lib/surface/call.cc index 8ae57cd6141..463674402a8 100644 --- a/src/core/lib/surface/call.cc +++ b/src/core/lib/surface/call.cc @@ -3292,6 +3292,7 @@ class MaybeOpImpl { ~MaybeOpImpl() { switch (state_) { case State::kDismissed: + break; case State::kPromiseFactory: Destruct(&promise_factory_); break; @@ -3306,6 +3307,7 @@ class MaybeOpImpl { MaybeOpImpl(MaybeOpImpl&& other) noexcept : state_(other.state_) { switch (state_) { case State::kDismissed: + break; case State::kPromiseFactory: Construct(&promise_factory_, std::move(other.promise_factory_)); break;