[retry e2e test] add log message about known flakiness (#37974)

Closes #37974

COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/37974 from markdroth:retry_flake_fix 23a63f5485
PiperOrigin-RevId: 688319769
pull/37979/head
Mark D. Roth 5 months ago committed by Copybara-Service
parent c5999dbac3
commit 1178b2d229
  1. 15
      test/core/end2end/tests/retry_non_retriable_status.cc

@ -76,6 +76,21 @@ CORE_END2END_TEST(RetryTest, RetryNonRetriableStatus) {
.RecvCloseOnServer(client_close);
Expect(102, true);
Expect(1, true);
// TODO(roth): After promise conversion, reevalute this.
LOG(INFO)
<< "NOTE(roth): We've seen infrequent flakiness in this test due to "
"a callback reordering issue. I considered making a change similar "
"to https://github.com/grpc/grpc/pull/37944 here to avoid the "
"flakiness, but that would have made this test essentially the "
"same as the existing retry_non_retriable_status_before_trailers "
"test, and the reason these are two separate tests is that they "
"cover different edge cases in the current implementation. The "
"flake rate is currently low enough (about 3 flakes in 6 months) "
"that I think we get more value from having this separate test "
"than we're losing due to the flakiness, so I'm leaving the test "
"as-is for now. Once the promise migration is done, this "
"difference won't be important anymore, and we'll be able to "
"remove a bunch of retry test cases at that point anyway.";
Step();
EXPECT_EQ(server_status.status(), GRPC_STATUS_INVALID_ARGUMENT);
EXPECT_EQ(server_status.message(), "xyz");

Loading…
Cancel
Save