Memory leak fix on windows in grpc_tcp_create() (#27457)

* Avoid using memset on types with non POD data members.

* add todo

Co-authored-by: Jan Tattermusch <jtattermusch@google.com>
pull/28602/head
perjoh 3 years ago committed by GitHub
parent 03bf699600
commit 10694d1679
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 5
      src/core/lib/iomgr/tcp_windows.cc

@ -500,8 +500,9 @@ static grpc_endpoint_vtable vtable = {win_read,
grpc_endpoint* grpc_tcp_create(grpc_winsocket* socket,
grpc_channel_args* channel_args,
absl::string_view peer_string) {
grpc_tcp* tcp = new grpc_tcp;
memset(tcp, 0, sizeof(grpc_tcp));
// TODO(jtattermusch): C++ize grpc_tcp and its dependencies (i.e. add
// constructors) to ensure proper initialization
grpc_tcp* tcp = new grpc_tcp{};
tcp->base.vtable = &vtable;
tcp->socket = socket;
gpr_mu_init(&tcp->mu);

Loading…
Cancel
Save