Merge pull request #18273 from grpc/revert-18241-strip

Revert "Strip Python wheel binary"
reviewable/pr18275/r1
Jan Tattermusch 6 years ago committed by GitHub
commit 0feab2065e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 2
      test/distrib/python/test_packages.sh
  2. 18
      tools/run_tests/artifacts/build_package_python.sh

@ -41,7 +41,7 @@ PYTHON=$VIRTUAL_ENV/bin/python
function at_least_one_installs() { function at_least_one_installs() {
for file in "$@"; do for file in "$@"; do
if "$PYTHON" -m pip install --require-hashes "$file"; then if "$PYTHON" -m pip install "$file"; then
return 0 return 0
fi fi
done done

@ -23,24 +23,6 @@ mkdir -p artifacts/
# and we only collect them here to deliver them to the distribtest phase. # and we only collect them here to deliver them to the distribtest phase.
cp -r "${EXTERNAL_GIT_ROOT}"/input_artifacts/python_*/* artifacts/ || true cp -r "${EXTERNAL_GIT_ROOT}"/input_artifacts/python_*/* artifacts/ || true
strip_binary_wheel() {
WHEEL_PATH="$1"
TEMP_WHEEL_DIR=$(mktemp -d)
wheel unpack "$WHEEL_PATH" -d "$TEMP_WHEEL_DIR"
find "$TEMP_WHEEL_DIR" -name "_protoc_compiler*.so" -exec strip --strip-debug {} ";"
find "$TEMP_WHEEL_DIR" -name "cygrpc*.so" -exec strip --strip-debug {} ";"
WHEEL_FILE=$(basename "$WHEEL_PATH")
DISTRIBUTION_NAME=$(basename "$WHEEL_PATH" | cut -d '-' -f 1)
VERSION=$(basename "$WHEEL_PATH" | cut -d '-' -f 2)
wheel pack "$TEMP_WHEEL_DIR/$DISTRIBUTION_NAME-$VERSION" -d "$TEMP_WHEEL_DIR"
mv "$TEMP_WHEEL_DIR/$WHEEL_FILE" "$WHEEL_PATH"
}
for wheel in artifacts/*.whl; do
strip_binary_wheel "$wheel"
done
# TODO: all the artifact builder configurations generate a grpcio-VERSION.tar.gz # TODO: all the artifact builder configurations generate a grpcio-VERSION.tar.gz
# source distribution package, and only one of them will end up # source distribution package, and only one of them will end up
# in the artifacts/ directory. They should be all equivalent though. # in the artifacts/ directory. They should be all equivalent though.

Loading…
Cancel
Save