Merge pull request #18959 from SataQiu/fix-20190506

Fix some spelling mistakes
pull/19027/head
Vijay Pai 6 years ago committed by GitHub
commit 0df4cb1bdc
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 2
      src/core/ext/transport/chttp2/transport/chttp2_transport.cc
  2. 4
      src/core/ext/transport/chttp2/transport/internal.h
  3. 2
      src/core/lib/compression/compression_internal.h
  4. 4
      src/core/lib/compression/stream_compression.h
  5. 2
      src/core/lib/gpr/env.h
  6. 2
      src/core/lib/gprpp/global_config_custom.h
  7. 2
      src/core/lib/gprpp/ref_counted.h
  8. 2
      src/core/lib/iomgr/error_internal.h
  9. 2
      src/core/lib/iomgr/ev_epoll1_linux.cc
  10. 4
      src/core/lib/iomgr/udp_server.cc
  11. 2
      src/core/lib/security/security_connector/security_connector.h
  12. 2
      src/core/lib/security/security_connector/ssl/ssl_security_connector.cc
  13. 4
      src/core/lib/slice/b64.h
  14. 2
      src/core/tsi/alts/handshaker/alts_shared_resource.h

@ -1720,7 +1720,7 @@ static void perform_stream_op(grpc_transport* gt, grpc_stream* gs,
} }
static void cancel_pings(grpc_chttp2_transport* t, grpc_error* error) { static void cancel_pings(grpc_chttp2_transport* t, grpc_error* error) {
/* callback remaining pings: they're not allowed to call into the transpot, /* callback remaining pings: they're not allowed to call into the transport,
and maybe they hold resources that need to be freed */ and maybe they hold resources that need to be freed */
grpc_chttp2_ping_queue* pq = &t->ping_queue; grpc_chttp2_ping_queue* pq = &t->ping_queue;
GPR_ASSERT(error != GRPC_ERROR_NONE); GPR_ASSERT(error != GRPC_ERROR_NONE);

@ -225,14 +225,14 @@ class Chttp2IncomingByteStream : public ByteStream {
// TODO(roth): When I converted this class to C++, I wanted to make it // TODO(roth): When I converted this class to C++, I wanted to make it
// inherit from RefCounted or InternallyRefCounted instead of continuing // inherit from RefCounted or InternallyRefCounted instead of continuing
// to use its own custom ref-counting code. However, that would require // to use its own custom ref-counting code. However, that would require
// using multiple inheritence, which sucks in general. And to make matters // using multiple inheritance, which sucks in general. And to make matters
// worse, it causes problems with our New<> and Delete<> wrappers. // worse, it causes problems with our New<> and Delete<> wrappers.
// Specifically, unless RefCounted is first in the list of parent classes, // Specifically, unless RefCounted is first in the list of parent classes,
// it will see a different value of the address of the object than the one // it will see a different value of the address of the object than the one
// we actually allocated, in which case gpr_free() will be called on a // we actually allocated, in which case gpr_free() will be called on a
// different address than the one we got from gpr_malloc(), thus causing a // different address than the one we got from gpr_malloc(), thus causing a
// crash. Given the fragility of depending on that, as well as a desire to // crash. Given the fragility of depending on that, as well as a desire to
// avoid multiple inheritence in general, I've decided to leave this // avoid multiple inheritance in general, I've decided to leave this
// alone for now. We can revisit this once we're able to link against // alone for now. We can revisit this once we're able to link against
// libc++, at which point we can eliminate New<> and Delete<> and // libc++, at which point we can eliminate New<> and Delete<> and
// switch to std::shared_ptr<>. // switch to std::shared_ptr<>.

@ -35,7 +35,7 @@ typedef enum {
GRPC_MESSAGE_COMPRESS_ALGORITHMS_COUNT GRPC_MESSAGE_COMPRESS_ALGORITHMS_COUNT
} grpc_message_compression_algorithm; } grpc_message_compression_algorithm;
/** Stream compresssion algorithms supported by gRPC */ /** Stream compression algorithms supported by gRPC */
typedef enum { typedef enum {
GRPC_STREAM_COMPRESS_NONE = 0, GRPC_STREAM_COMPRESS_NONE = 0,
GRPC_STREAM_COMPRESS_GZIP, GRPC_STREAM_COMPRESS_GZIP,

@ -68,7 +68,7 @@ struct grpc_stream_compression_vtable {
* at the end of compression. Emits at most \a max_output_size compressed bytes * at the end of compression. Emits at most \a max_output_size compressed bytes
* into \a out. If all the bytes in input buffer \a in are depleted and \a flush * into \a out. If all the bytes in input buffer \a in are depleted and \a flush
* is not GRPC_STREAM_COMPRESSION_FLUSH_NONE, the corresponding flush method is * is not GRPC_STREAM_COMPRESSION_FLUSH_NONE, the corresponding flush method is
* executed. The total number of bytes emitted is outputed in \a output_size. * executed. The total number of bytes emitted is outputted in \a output_size.
* *
* A SYNC flush indicates that the entire messages in \a in can be decompressed * A SYNC flush indicates that the entire messages in \a in can be decompressed
* from \a out. A FINISH flush implies a SYNC flush, and that any further * from \a out. A FINISH flush implies a SYNC flush, and that any further
@ -85,7 +85,7 @@ bool grpc_stream_compress(grpc_stream_compression_context* ctx,
* Decompress bytes provided in \a in with a given context. Emits at most \a * Decompress bytes provided in \a in with a given context. Emits at most \a
* max_output_size decompressed bytes into \a out. If decompression process * max_output_size decompressed bytes into \a out. If decompression process
* reached the end of a gzip stream, \a end_of_context is set to true; otherwise * reached the end of a gzip stream, \a end_of_context is set to true; otherwise
* it is set to false. The total number of bytes emitted is outputed in \a * it is set to false. The total number of bytes emitted is outputted in \a
* output_size. * output_size.
*/ */
bool grpc_stream_decompress(grpc_stream_compression_context* ctx, bool grpc_stream_decompress(grpc_stream_compression_context* ctx,

@ -26,7 +26,7 @@
/* Env utility functions */ /* Env utility functions */
/* Gets the environment variable value with the specified name. /* Gets the environment variable value with the specified name.
Returns a newly allocated string. It is the responsability of the caller to Returns a newly allocated string. It is the responsibility of the caller to
gpr_free the return value if not NULL (which means that the environment gpr_free the return value if not NULL (which means that the environment
variable exists). */ variable exists). */
char* gpr_getenv(const char* name); char* gpr_getenv(const char* name);

@ -19,7 +19,7 @@
#ifndef GRPC_CORE_LIB_GPRPP_GLOBAL_CONFIG_CUSTOM_H #ifndef GRPC_CORE_LIB_GPRPP_GLOBAL_CONFIG_CUSTOM_H
#define GRPC_CORE_LIB_GPRPP_GLOBAL_CONFIG_CUSTOM_H #define GRPC_CORE_LIB_GPRPP_GLOBAL_CONFIG_CUSTOM_H
// This is a placeholder for custom global configuration implementaion. // This is a placeholder for custom global configuration implementation.
// To use the custom one, please define following macros here. // To use the custom one, please define following macros here.
// //
// GPR_GLOBAL_CONFIG_DEFINE_BOOL // GPR_GLOBAL_CONFIG_DEFINE_BOOL

@ -180,7 +180,7 @@ class RefCount {
// So, use NonPolymorphicRefCount only when both of the following conditions // So, use NonPolymorphicRefCount only when both of the following conditions
// are guaranteed to hold: // are guaranteed to hold:
// (a) Child is a concrete leaf class in RefCounted<Child>, and // (a) Child is a concrete leaf class in RefCounted<Child>, and
// (b) you are gauranteed to call Unref only on concrete leaf classes and not // (b) you are guaranteed to call Unref only on concrete leaf classes and not
// their parents. // their parents.
// //
// The following example is illegal, because calling Unref() will not call // The following example is illegal, because calling Unref() will not call

@ -49,7 +49,7 @@ struct grpc_error {
uint8_t strs[GRPC_ERROR_STR_MAX]; uint8_t strs[GRPC_ERROR_STR_MAX];
uint8_t times[GRPC_ERROR_TIME_MAX]; uint8_t times[GRPC_ERROR_TIME_MAX];
// The child errors are stored in the arena, but are effectively a linked list // The child errors are stored in the arena, but are effectively a linked list
// structure, since they are contained withing grpc_linked_error objects. // structure, since they are contained within grpc_linked_error objects.
uint8_t first_err; uint8_t first_err;
uint8_t last_err; uint8_t last_err;
// The arena is dynamically reallocated with a grow factor of 1.5. // The arena is dynamically reallocated with a grow factor of 1.5.

@ -1031,7 +1031,7 @@ static grpc_error* pollset_work(grpc_pollset* ps,
process the pending epoll events. process the pending epoll events.
The reason for decoupling do_epoll_wait and process_epoll_events is to The reason for decoupling do_epoll_wait and process_epoll_events is to
better distrubute the work (i.e handling epoll events) across multiple better distribute the work (i.e handling epoll events) across multiple
threads threads
process_epoll_events() returns very quickly: It just queues the work on process_epoll_events() returns very quickly: It just queues the work on

@ -332,7 +332,7 @@ void GrpcUdpListener::OnFdAboutToOrphan() {
GRPC_CLOSURE_INIT(&destroyed_closure_, destroyed_port, server_, GRPC_CLOSURE_INIT(&destroyed_closure_, destroyed_port, server_,
grpc_schedule_on_exec_ctx); grpc_schedule_on_exec_ctx);
if (!orphan_notified_ && udp_handler_ != nullptr) { if (!orphan_notified_ && udp_handler_ != nullptr) {
/* Singals udp_handler that the FD is about to be closed and /* Signals udp_handler that the FD is about to be closed and
* should no longer be used. */ * should no longer be used. */
GRPC_CLOSURE_INIT(&orphan_fd_closure_, shutdown_fd, this, GRPC_CLOSURE_INIT(&orphan_fd_closure_, shutdown_fd, this,
grpc_schedule_on_exec_ctx); grpc_schedule_on_exec_ctx);
@ -645,7 +645,7 @@ int grpc_udp_server_add_port(grpc_udp_server* s,
grpc_sockaddr_set_port(addr, allocated_port1); grpc_sockaddr_set_port(addr, allocated_port1);
port = allocated_port1; port = allocated_port1;
} else if (allocated_port1 >= 0) { } else if (allocated_port1 >= 0) {
/* The following sucessfully created socket should have same port as /* The following successfully created socket should have same port as
* the first one. */ * the first one. */
GPR_ASSERT(port == allocated_port1); GPR_ASSERT(port == allocated_port1);
} }

@ -102,7 +102,7 @@ class grpc_channel_security_connector : public grpc_security_connector {
grpc_auth_context* auth_context, grpc_auth_context* auth_context,
grpc_closure* on_call_host_checked, grpc_closure* on_call_host_checked,
grpc_error** error) GRPC_ABSTRACT; grpc_error** error) GRPC_ABSTRACT;
/// Cancels a pending asychronous call to /// Cancels a pending asynchronous call to
/// grpc_channel_security_connector_check_call_host() with /// grpc_channel_security_connector_check_call_host() with
/// \a on_call_host_checked as its callback. /// \a on_call_host_checked as its callback.
virtual void cancel_check_call_host(grpc_closure* on_call_host_checked, virtual void cancel_check_call_host(grpc_closure* on_call_host_checked,

@ -310,7 +310,7 @@ class grpc_ssl_server_security_connector
private: private:
/* Attempts to fetch the server certificate config if a callback is available. /* Attempts to fetch the server certificate config if a callback is available.
* Current certificate config will continue to be used if the callback returns * Current certificate config will continue to be used if the callback returns
* an error. Returns true if new credentials were sucessfully loaded. */ * an error. Returns true if new credentials were successfully loaded. */
bool try_fetch_ssl_server_credentials() { bool try_fetch_ssl_server_credentials() {
grpc_ssl_server_certificate_config* certificate_config = nullptr; grpc_ssl_server_certificate_config* certificate_config = nullptr;
bool status; bool status;

@ -23,7 +23,7 @@
#include <grpc/slice.h> #include <grpc/slice.h>
/* Encodes data using base64. It is the caller's responsability to free /* Encodes data using base64. It is the caller's responsibility to free
the returned char * using gpr_free. Returns NULL on NULL input. the returned char * using gpr_free. Returns NULL on NULL input.
TODO(makdharma) : change the flags to bool from int */ TODO(makdharma) : change the flags to bool from int */
char* grpc_base64_encode(const void* data, size_t data_size, int url_safe, char* grpc_base64_encode(const void* data, size_t data_size, int url_safe,
@ -35,7 +35,7 @@ size_t grpc_base64_estimate_encoded_size(size_t data_size, int url_safe,
int multiline); int multiline);
/* Encodes data using base64 and write it to memory pointed to by result. It is /* Encodes data using base64 and write it to memory pointed to by result. It is
* the caller's responsiblity to allocate enough memory in |result| to fit the * the caller's responsibility to allocate enough memory in |result| to fit the
* encoded data. */ * encoded data. */
void grpc_base64_encode_core(char* result, const void* vdata, size_t data_size, void grpc_base64_encode_core(char* result, const void* vdata, size_t data_size,
int url_safe, int multiline); int url_safe, int multiline);

@ -48,7 +48,7 @@ alts_shared_resource_dedicated* grpc_alts_get_shared_resource_dedicated(void);
/** /**
* This method destroys the alts_shared_resource_dedicated object * This method destroys the alts_shared_resource_dedicated object
* shared by all TSI handshakes. The applicaiton is responsible for * shared by all TSI handshakes. The application is responsible for
* invoking the API before calling grpc_shutdown(). * invoking the API before calling grpc_shutdown().
*/ */
void grpc_alts_shared_resource_dedicated_shutdown(); void grpc_alts_shared_resource_dedicated_shutdown();

Loading…
Cancel
Save