From 0b53cc6bce4deed756d479ed51fb767fe8fda893 Mon Sep 17 00:00:00 2001 From: Yousuk Seung Date: Thu, 27 Jun 2024 10:30:19 -0700 Subject: [PATCH] [experiments] Retry #36875 (rollback of #36997) (#37061) Flaky tests are fixed now. Closes #37061 COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/37061 from yousukseung:work-serializer-retry 610a8e0e1a0ebe79bc2b048a9e581140114ac086 PiperOrigin-RevId: 647366412 --- bazel/experiments.bzl | 2 +- src/core/lib/experiments/experiments.cc | 17 +++-------------- src/core/lib/experiments/rollouts.yaml | 1 - 3 files changed, 4 insertions(+), 16 deletions(-) diff --git a/bazel/experiments.bzl b/bazel/experiments.bzl index 9aeb2fc360d..1e58632622a 100644 --- a/bazel/experiments.bzl +++ b/bazel/experiments.bzl @@ -41,7 +41,7 @@ EXPERIMENT_ENABLES = { "trace_record_callops": "trace_record_callops", "unconstrained_max_quota_buffer_size": "unconstrained_max_quota_buffer_size", "work_serializer_clears_time_cache": "work_serializer_clears_time_cache", - "work_serializer_dispatch": "event_engine_client,work_serializer_dispatch", + "work_serializer_dispatch": "work_serializer_dispatch", } EXPERIMENT_POLLERS = [ diff --git a/src/core/lib/experiments/experiments.cc b/src/core/lib/experiments/experiments.cc index deec6512339..abaf294db5a 100644 --- a/src/core/lib/experiments/experiments.cc +++ b/src/core/lib/experiments/experiments.cc @@ -16,8 +16,6 @@ #include "src/core/lib/experiments/experiments.h" -#include - #include #ifndef GRPC_EXPERIMENTS_ARE_FINAL @@ -114,8 +112,6 @@ const char* const description_work_serializer_dispatch = "callback, instead of running things inline in the first thread that " "successfully enqueues work."; const char* const additional_constraints_work_serializer_dispatch = "{}"; -const uint8_t required_experiments_work_serializer_dispatch[] = { - static_cast(grpc_core::kExperimentIdEventEngineClient)}; } // namespace namespace grpc_core { @@ -181,8 +177,7 @@ const ExperimentMetadata g_experiment_metadata[] = { additional_constraints_work_serializer_clears_time_cache, nullptr, 0, true, true}, {"work_serializer_dispatch", description_work_serializer_dispatch, - additional_constraints_work_serializer_dispatch, - required_experiments_work_serializer_dispatch, 1, false, true}, + additional_constraints_work_serializer_dispatch, nullptr, 0, false, true}, }; } // namespace grpc_core @@ -279,8 +274,6 @@ const char* const description_work_serializer_dispatch = "callback, instead of running things inline in the first thread that " "successfully enqueues work."; const char* const additional_constraints_work_serializer_dispatch = "{}"; -const uint8_t required_experiments_work_serializer_dispatch[] = { - static_cast(grpc_core::kExperimentIdEventEngineClient)}; } // namespace namespace grpc_core { @@ -346,8 +339,7 @@ const ExperimentMetadata g_experiment_metadata[] = { additional_constraints_work_serializer_clears_time_cache, nullptr, 0, true, true}, {"work_serializer_dispatch", description_work_serializer_dispatch, - additional_constraints_work_serializer_dispatch, - required_experiments_work_serializer_dispatch, 1, false, true}, + additional_constraints_work_serializer_dispatch, nullptr, 0, false, true}, }; } // namespace grpc_core @@ -444,8 +436,6 @@ const char* const description_work_serializer_dispatch = "callback, instead of running things inline in the first thread that " "successfully enqueues work."; const char* const additional_constraints_work_serializer_dispatch = "{}"; -const uint8_t required_experiments_work_serializer_dispatch[] = { - static_cast(grpc_core::kExperimentIdEventEngineClient)}; } // namespace namespace grpc_core { @@ -511,8 +501,7 @@ const ExperimentMetadata g_experiment_metadata[] = { additional_constraints_work_serializer_clears_time_cache, nullptr, 0, true, true}, {"work_serializer_dispatch", description_work_serializer_dispatch, - additional_constraints_work_serializer_dispatch, - required_experiments_work_serializer_dispatch, 1, true, true}, + additional_constraints_work_serializer_dispatch, nullptr, 0, true, true}, }; } // namespace grpc_core diff --git a/src/core/lib/experiments/rollouts.yaml b/src/core/lib/experiments/rollouts.yaml index 05438ce6f90..a0f25b5dc91 100644 --- a/src/core/lib/experiments/rollouts.yaml +++ b/src/core/lib/experiments/rollouts.yaml @@ -111,7 +111,6 @@ - name: work_serializer_clears_time_cache default: true - name: work_serializer_dispatch - requires: ["event_engine_client"] default: # TODO(ysseung): Not fully tested. ios: broken