mirror of https://github.com/grpc/grpc.git
Change cancellation semantics in the iomgr DNSResolver (#29581)
DNS requests were previously cancellable, but it was assumed that the resolution callback would be called in all cases. Now, requests provide a `bool Cancel(TaskHandle handle)` method that lets callers know whether cancellation is successful, and if so, the callback will not be run. This is in accordance with EventEngine's cancellation semantics, and it is a step towards migration from iomgr to EventEngine.pull/29631/head^2
AJ Heller
3 years ago
committed by
GitHub
parent
7b53ceec4d
commit
0a21ecdff6
28 changed files with 320 additions and 202 deletions
@ -0,0 +1,56 @@ |
||||
// Copyright 2022 The gRPC Authors
|
||||
//
|
||||
// Licensed under the Apache License, Version 2.0 (the "License");
|
||||
// you may not use this file except in compliance with the License.
|
||||
// You may obtain a copy of the License at
|
||||
//
|
||||
// http://www.apache.org/licenses/LICENSE-2.0
|
||||
//
|
||||
// Unless required by applicable law or agreed to in writing, software
|
||||
// distributed under the License is distributed on an "AS IS" BASIS,
|
||||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
||||
// See the License for the specific language governing permissions and
|
||||
// limitations under the License.
|
||||
#ifndef GRPC_CORE_LIB_EVENT_ENGINE_HANDLE_CONTAINERS_H |
||||
#define GRPC_CORE_LIB_EVENT_ENGINE_HANDLE_CONTAINERS_H |
||||
|
||||
#include <grpc/support/port_platform.h> |
||||
|
||||
#include "absl/container/flat_hash_set.h" |
||||
#include "absl/hash/hash.h" |
||||
|
||||
#include <grpc/event_engine/event_engine.h> |
||||
|
||||
// Used for heterogenous lookup of TaskHandles in abseil containers.
|
||||
template <typename TaskHandle> |
||||
struct TaskHandleComparator { |
||||
struct Hash { |
||||
using HashType = std::pair<const intptr_t, const intptr_t>; |
||||
using is_transparent = void; |
||||
size_t operator()(const TaskHandle& handle) const { |
||||
return absl::Hash<HashType>()({handle.keys[0], handle.keys[1]}); |
||||
} |
||||
}; |
||||
struct Eq { |
||||
using is_transparent = void; |
||||
bool operator()(const TaskHandle& lhs, const TaskHandle& rhs) const { |
||||
return lhs.keys[0] == rhs.keys[0] && lhs.keys[1] == rhs.keys[1]; |
||||
} |
||||
}; |
||||
}; |
||||
|
||||
using TaskHandleSet = absl::flat_hash_set< |
||||
grpc_event_engine::experimental::EventEngine::TaskHandle, |
||||
TaskHandleComparator< |
||||
grpc_event_engine::experimental::EventEngine::TaskHandle>::Hash, |
||||
TaskHandleComparator< |
||||
grpc_event_engine::experimental::EventEngine::TaskHandle>::Eq>; |
||||
|
||||
using LookupTaskHandleSet = absl::flat_hash_set< |
||||
grpc_event_engine::experimental::EventEngine::DNSResolver::LookupTaskHandle, |
||||
TaskHandleComparator<grpc_event_engine::experimental::EventEngine:: |
||||
DNSResolver::LookupTaskHandle>::Hash, |
||||
TaskHandleComparator<grpc_event_engine::experimental::EventEngine:: |
||||
DNSResolver::LookupTaskHandle>::Eq>; |
||||
|
||||
#endif // GRPC_CORE_LIB_EVENT_ENGINE_HANDLE_CONTAINERS_H
|
||||
Loading…
Reference in new issue