Added import order comments, resolved other minor issues

pull/8125/head
murgatroid99 8 years ago
parent b516cadc2a
commit 085f9afaf0
  1. 4
      src/core/ext/lb_policy/grpclb/grpclb.c
  2. 7
      src/core/lib/iomgr/tcp_server_posix.c
  3. 5
      test/core/client_channel/set_initial_connect_string_test.c
  4. 5
      test/core/end2end/bad_server_response_test.c
  5. 4
      test/core/iomgr/sockaddr_utils_test.c
  6. 4
      test/core/surface/concurrent_connectivity_test.c

@ -96,6 +96,10 @@
* - Implement LB service forwarding (point 2c. in the doc's diagram). * - Implement LB service forwarding (point 2c. in the doc's diagram).
*/ */
/* With the addition of a libuv endpoint, sockaddr.h now includes uv.h when
using that endpoint. Because of various transitive includes in uv.h,
including windows.h on Windows, uv.h must be included before other system
headers. Therefore, sockaddr.h must always be included first */
#include "src/core/lib/iomgr/sockaddr.h" #include "src/core/lib/iomgr/sockaddr.h"
#include <errno.h> #include <errno.h>

@ -81,13 +81,6 @@ struct grpc_tcp_listener {
grpc_fd *emfd; grpc_fd *emfd;
grpc_tcp_server *server; grpc_tcp_server *server;
grpc_resolved_address addr; grpc_resolved_address addr;
/*
union {
uint8_t untyped[GRPC_MAX_SOCKADDR_SIZE];
struct sockaddr sockaddr;
} addr;
size_t addr_len;
*/
int port; int port;
unsigned port_index; unsigned port_index;
unsigned fd_index; unsigned fd_index;

@ -30,6 +30,11 @@
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
* *
*/ */
/* With the addition of a libuv endpoint, sockaddr.h now includes uv.h when
using that endpoint. Because of various transitive includes in uv.h,
including windows.h on Windows, uv.h must be included before other system
headers. Therefore, sockaddr.h must always be included first */
#include "src/core/lib/iomgr/sockaddr.h" #include "src/core/lib/iomgr/sockaddr.h"
#include <string.h> #include <string.h>

@ -30,6 +30,11 @@
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
* *
*/ */
/* With the addition of a libuv endpoint, sockaddr.h now includes uv.h when
using that endpoint. Because of various transitive includes in uv.h,
including windows.h on Windows, uv.h must be included before other system
headers. Therefore, sockaddr.h must always be included first */
#include "src/core/lib/iomgr/sockaddr.h" #include "src/core/lib/iomgr/sockaddr.h"
#include <string.h> #include <string.h>

@ -31,6 +31,10 @@
* *
*/ */
/* With the addition of a libuv endpoint, sockaddr.h now includes uv.h when
using that endpoint. Because of various transitive includes in uv.h,
including windows.h on Windows, uv.h must be included before other system
headers. Therefore, sockaddr.h must always be included first */
#include "src/core/lib/iomgr/sockaddr.h" #include "src/core/lib/iomgr/sockaddr.h"
#include "src/core/lib/iomgr/sockaddr_utils.h" #include "src/core/lib/iomgr/sockaddr_utils.h"

@ -31,6 +31,10 @@
* *
*/ */
/* With the addition of a libuv endpoint, sockaddr.h now includes uv.h when
using that endpoint. Because of various transitive includes in uv.h,
including windows.h on Windows, uv.h must be included before other system
headers. Therefore, sockaddr.h must always be included first */
#include "src/core/lib/iomgr/sockaddr.h" #include "src/core/lib/iomgr/sockaddr.h"
#include <memory.h> #include <memory.h>

Loading…
Cancel
Save