GCP Observability: Plumbing with logging filter (#32065)

* GCP Observability: Plumbing with logging filter

* Fix MacOS build

* IWYU

* IWYU again

src/cpp/ext/filters/logging/logging_filter.cc

@@ -20,8 +20,8 @@
 
 #include "src/cpp/ext/filters/logging/logging_filter.h"
 
+#include <inttypes.h>
 #include <limits.h>
-#include <stdint.h>
 
 #include <algorithm>
 #include <cstddef>
@@ -117,10 +117,11 @@ class MetadataEncoder {
     }
     uint64_t mdentry_len = key.length() + value.length();
     if (mdentry_len > log_len_) {
-      gpr_log(GPR_DEBUG,
+      gpr_log(
-              "Skipped metadata key because of max metadata logging bytes %lu "
+          GPR_DEBUG,
-              "(current) vs %lu (max less already accounted metadata)",
+          "Skipped metadata key because of max metadata logging bytes %" PRIu64
-              mdentry_len, log_len_);
+          " (current) vs %" PRIu64 " (max less already accounted metadata)",
+          mdentry_len, log_len_);
       truncated_ = true;
       return;
     }

src/cpp/ext/gcp/BUILD

@@ -51,9 +51,11 @@ grpc_cc_library(
     visibility = ["//:__subpackages__"],
     deps = [
         "observability_config",
+        "observability_logging_sink",
         "//:gpr",
         "//:grpc++",
         "//:grpc_opencensus_plugin",
+        "//src/cpp/ext/filters/logging:logging_filter",
     ],
 )
 

src/cpp/ext/gcp/observability.cc

@@ -40,7 +40,9 @@
 
 #include "src/cpp/ext/filters/census/grpc_plugin.h"
 #include "src/cpp/ext/filters/census/open_census_call_tracer.h"
+#include "src/cpp/ext/filters/logging/logging_filter.h"
 #include "src/cpp/ext/gcp/observability_config.h"
+#include "src/cpp/ext/gcp/observability_logging_sink.h"
 
 namespace grpc {
 namespace experimental {
@@ -80,7 +82,8 @@ absl::Status GcpObservabilityInit() {
     return config.status();
   }
   if (!config->cloud_trace.has_value() &&
-      !config->cloud_monitoring.has_value()) {
+      !config->cloud_monitoring.has_value() &&
+      !config->cloud_logging.has_value()) {
     return absl::OkStatus();
   }
   grpc::RegisterOpenCensusPlugin();
@@ -116,6 +119,11 @@ absl::Status GcpObservabilityInit() {
     // Disable OpenCensus stats
     EnableOpenCensusStats(false);
   }
+  if (config->cloud_logging.has_value()) {
+    grpc::internal::RegisterLoggingFilter(
+        new grpc::internal::ObservabilityLoggingSink(
+            config->cloud_logging.value(), config->project_id));
+  }
   return absl::OkStatus();
 }