Writing a doc with steps to contribute to the grpc code base.

Making screenshots for this doc better.
This is meant for non googlers.

PiperOrigin-RevId: 603266696
pull/35780/head
Tanvi Jagtap 1 year ago committed by Copybara-Service
parent ba43ac914d
commit 05b62c90a9
  1. 35
      CONTRIBUTING_STEPS.md
  2. BIN
      doc/images/img/grpc-assignee.png
  3. BIN
      doc/images/img/grpc-compare-and-pull-request.png
  4. BIN
      doc/images/img/grpc-contributor-type.png
  5. BIN
      doc/images/img/grpc-easycla-authorize.png
  6. BIN
      doc/images/img/grpc-easycla-covered.png
  7. BIN
      doc/images/img/grpc-pull-request-details.png
  8. BIN
      doc/images/img/grpc-review-complete.png
  9. BIN
      doc/images/img/grpc-sign-cla.png
  10. BIN
      doc/images/img/grpc-tests.png
  11. BIN
      doc/images/img/grpc-wait-for-merge.png

@ -66,10 +66,35 @@ Create a pull request.
Once the pull request is ready, you must wait for a reviewer to be
assigned to your pull request.
If you see *Not Covered* in the EasyCLA screen, as shown in the following image,
click on the mentioned link to start the authorization process.
![Screenshot of waiting for safe review](doc/images/img/grpc-tests.png)
After a few hours, you will notice a new "assignee" assigned to the pull
request. After a reviewer is assigned to you, they will help with the next
You will see a series of screens:
1. Select *Authorize LF-Engineering:
![Screenshot of EasyCLA Step 1](doc/images/img/grpc-easycla-authorize.png)
1. Select your contributor type:
![Screenshot of EasyCLA Step 2](doc/images/img/grpc-contributor-type.png)
1. Select *SIGN CLA*:
![Screenshot of EasyCLA Step 3](doc/images/img/grpc-sign-cla.png)
Some time after you've digitally signed the document, the EasyCLA will appear as
*Covered*.
![Screenshot of EasyCLA Step 5](doc/images/img/grpc-easycla-covered.png)
After a few hours, you will notice a new "assignee" assigned to the pull request.
![Screenshot after an assignee is added](doc/images/img/grpc-assignee.png)
After a reviewer is assigned to you, they will help with the next
steps, which are as follows:
1. You complete the code review and address the comments.
@ -92,10 +117,14 @@ You can read more about the process and requirements
After you fix the code review, you will finally get an approval. After getting
approval, you can submit the pull request.
![Pull request approved and labelled ](doc/images/img/grpc-review-complete.png)
### Submission
You **cannot** do submission or merge of a pull request through Github.
![Pull request approved and labelled ](doc/images/img/grpc-wait-for-merge.png)
After you have approval from a reviewer, a Google employee will trigger
the submission process. When the submission happens:
@ -103,5 +132,3 @@ the submission process. When the submission happens:
be committed to the `grpc/master` branch.
1. The pull request you originally created will be closed.
<!-- TODO add screenshot of PR that is closed -->
<!-- TODO add screenshot of commit made by copybara -->

Binary file not shown.

After

Width:  |  Height:  |  Size: 455 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 487 KiB

After

Width:  |  Height:  |  Size: 530 KiB

Binary file not shown.

After

Width:  |  Height:  |  Size: 389 KiB

Binary file not shown.

After

Width:  |  Height:  |  Size: 173 KiB

Binary file not shown.

After

Width:  |  Height:  |  Size: 506 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 375 KiB

After

Width:  |  Height:  |  Size: 523 KiB

Binary file not shown.

After

Width:  |  Height:  |  Size: 524 KiB

Binary file not shown.

After

Width:  |  Height:  |  Size: 106 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 399 KiB

After

Width:  |  Height:  |  Size: 540 KiB

Binary file not shown.

After

Width:  |  Height:  |  Size: 343 KiB

Loading…
Cancel
Save