|
|
|
@ -66,10 +66,35 @@ Create a pull request. |
|
|
|
|
Once the pull request is ready, you must wait for a reviewer to be |
|
|
|
|
assigned to your pull request. |
|
|
|
|
|
|
|
|
|
If you see *Not Covered* in the EasyCLA screen, as shown in the following image, |
|
|
|
|
click on the mentioned link to start the authorization process. |
|
|
|
|
|
|
|
|
|
 |
|
|
|
|
|
|
|
|
|
After a few hours, you will notice a new "assignee" assigned to the pull |
|
|
|
|
request. After a reviewer is assigned to you, they will help with the next |
|
|
|
|
You will see a series of screens: |
|
|
|
|
|
|
|
|
|
1. Select *Authorize LF-Engineering: |
|
|
|
|
|
|
|
|
|
 |
|
|
|
|
|
|
|
|
|
1. Select your contributor type: |
|
|
|
|
|
|
|
|
|
 |
|
|
|
|
|
|
|
|
|
1. Select *SIGN CLA*: |
|
|
|
|
|
|
|
|
|
 |
|
|
|
|
|
|
|
|
|
Some time after you've digitally signed the document, the EasyCLA will appear as |
|
|
|
|
*Covered*. |
|
|
|
|
|
|
|
|
|
 |
|
|
|
|
|
|
|
|
|
After a few hours, you will notice a new "assignee" assigned to the pull request. |
|
|
|
|
|
|
|
|
|
 |
|
|
|
|
|
|
|
|
|
After a reviewer is assigned to you, they will help with the next |
|
|
|
|
steps, which are as follows: |
|
|
|
|
|
|
|
|
|
1. You complete the code review and address the comments. |
|
|
|
@ -92,10 +117,14 @@ You can read more about the process and requirements |
|
|
|
|
After you fix the code review, you will finally get an approval. After getting |
|
|
|
|
approval, you can submit the pull request. |
|
|
|
|
|
|
|
|
|
 |
|
|
|
|
|
|
|
|
|
### Submission |
|
|
|
|
|
|
|
|
|
You **cannot** do submission or merge of a pull request through Github. |
|
|
|
|
|
|
|
|
|
 |
|
|
|
|
|
|
|
|
|
After you have approval from a reviewer, a Google employee will trigger |
|
|
|
|
the submission process. When the submission happens: |
|
|
|
|
|
|
|
|
@ -103,5 +132,3 @@ the submission process. When the submission happens: |
|
|
|
|
be committed to the `grpc/master` branch. |
|
|
|
|
1. The pull request you originally created will be closed. |
|
|
|
|
|
|
|
|
|
<!-- TODO add screenshot of PR that is closed --> |
|
|
|
|
<!-- TODO add screenshot of commit made by copybara --> |
|
|
|
|