Make debug flags DebugOnly

src/core/ext/filters/client_channel/client_channel_plugin.cc

@@ -78,10 +78,6 @@ extern "C" void grpc_client_channel_init(void) {
       GRPC_CLIENT_CHANNEL, GRPC_CHANNEL_INIT_BUILTIN_PRIORITY, append_filter,
       (void*)&grpc_client_channel_filter);
   grpc_http_connect_register_handshaker_factory();
-
-#ifndef NDEBUG
-
-#endif
 }
 
 extern "C" void grpc_client_channel_shutdown(void) {

src/core/ext/filters/client_channel/lb_policy.h

@@ -33,9 +33,7 @@ typedef struct grpc_lb_policy grpc_lb_policy;
 typedef struct grpc_lb_policy_vtable grpc_lb_policy_vtable;
 typedef struct grpc_lb_policy_args grpc_lb_policy_args;
 
-#ifndef NDEBUG
-extern grpc_core::TraceFlag grpc_trace_lb_policy_refcount;
-#endif
+extern grpc_core::DebugOnlyTraceFlag grpc_trace_lb_policy_refcount;
 
 struct grpc_lb_policy {
   const grpc_lb_policy_vtable* vtable;

src/core/ext/filters/client_channel/resolver.cc

@@ -19,9 +19,7 @@
 #include "src/core/ext/filters/client_channel/resolver.h"
 #include "src/core/lib/iomgr/combiner.h"
 
-#ifndef NDEBUG
-grpc_core::TraceFlag grpc_trace_resolver_refcount(false, "resolver_refcount");
-#endif
+grpc_core::DebugOnlyTraceFlag grpc_trace_resolver_refcount(false, "resolver_refcount");
 
 void grpc_resolver_init(grpc_resolver* resolver,
                         const grpc_resolver_vtable* vtable,

src/core/ext/filters/client_channel/resolver.h

@@ -29,9 +29,7 @@ extern "C" {
 typedef struct grpc_resolver grpc_resolver;
 typedef struct grpc_resolver_vtable grpc_resolver_vtable;
 
-#ifndef NDEBUG
-extern grpc_core::TraceFlag grpc_trace_resolver_refcount;
-#endif
+extern grpc_core::DebugOnlyTraceFlag grpc_trace_resolver_refcount;
 
 /** \a grpc_resolver provides \a grpc_channel_args objects to its caller */
 struct grpc_resolver {

src/core/ext/transport/chttp2/transport/chttp2_plugin.cc

@@ -20,10 +20,6 @@
 #include "src/core/lib/debug/trace.h"
 #include "src/core/lib/transport/metadata.h"
 
-extern "C" void grpc_chttp2_plugin_init(void) {
-#ifndef NDEBUG
-
-#endif
-}
+extern "C" void grpc_chttp2_plugin_init(void) {}
 
 extern "C" void grpc_chttp2_plugin_shutdown(void) {}

src/core/ext/transport/chttp2/transport/chttp2_transport.cc

@@ -91,10 +91,7 @@ static int g_default_max_ping_strikes = DEFAULT_MAX_PING_STRIKES;
 
 #define MAX_CLIENT_STREAM_ID 0x7fffffffu
 grpc_core::TraceFlag grpc_http_trace(false, "http");
-
-#ifndef NDEBUG
-grpc_core::TraceFlag grpc_trace_chttp2_refcount(false, "chttp2_refcount");
-#endif
+grpc_core::DebugOnlyTraceFlag grpc_trace_chttp2_refcount(false, "chttp2_refcount");
 
 /* forward declarations of various callbacks that we'll build closures around */
 static void write_action_begin_locked(grpc_exec_ctx* exec_ctx, void* t,

src/core/ext/transport/chttp2/transport/chttp2_transport.h

@@ -25,10 +25,7 @@
 
 extern grpc_core::TraceFlag grpc_http_trace;
 extern grpc_core::TraceFlag grpc_trace_http2_stream_state;
-
-#ifndef NDEBUG
-extern grpc_core::TraceFlag grpc_trace_chttp2_refcount;
-#endif
+extern grpc_core::DebugOnlyTraceFlag grpc_trace_chttp2_refcount;
 
 #ifdef __cplusplus
 extern "C" {

src/core/lib/debug/trace.cc

@@ -36,7 +36,7 @@ TraceFlag::TraceFlag(bool default_enabled, const char *name)
   root_tracer_ = this;
 }
 
-void TraceFlag::List() {
+void TraceFlag::LogAllTracers() {
   gpr_log(GPR_DEBUG, "available tracers:");
   TraceFlag *t;
   for (t = root_tracer_; t != nullptr; t = t->next_tracer_) {
@@ -51,7 +51,7 @@ bool TraceFlag::Set(const char *name, bool enabled) {
       t->set_enabled(enabled);
     }
   } else if (0 == strcmp(name, "list_tracers")) {
-    List();
+    LogAllTracers();
   } else if (0 == strcmp(name, "refcount")) {
     for (t = root_tracer_; t; t = t->next_tracer_) {
       if (strstr(t->name_, "refcount") != NULL) {

src/core/lib/debug/trace.h

@@ -72,7 +72,7 @@ class TraceFlag {
   }
 
  private:
-  static void List();
+  static void LogAllTracers();
 
   static TraceFlag *root_tracer_;
   TraceFlag *next_tracer_;

src/core/lib/iomgr/closure.h

@@ -33,9 +33,7 @@ extern "C" {
 struct grpc_closure;
 typedef struct grpc_closure grpc_closure;
 
-#ifndef NDEBUG
-extern grpc_core::TraceFlag grpc_trace_closure;
-#endif
+extern grpc_core::DebugOnlyTraceFlag grpc_trace_closure;
 
 typedef struct grpc_closure_list {
   grpc_closure* head;

src/core/lib/iomgr/error.h

@@ -38,9 +38,7 @@ extern "C" {
 
 typedef struct grpc_error grpc_error;
 
-#ifndef NDEBUG
-extern grpc_core::TraceFlag grpc_trace_error_refcount;
-#endif
+extern grpc_core::DebugOnlyTraceFlag grpc_trace_error_refcount;
 
 typedef enum {
   /// 'errno' from the operating system

src/core/lib/iomgr/ev_epollex_linux.cc

@@ -59,9 +59,7 @@
 #define MAX_EPOLL_EVENTS 100
 #define MAX_EPOLL_EVENTS_HANDLED_EACH_POLL_CALL 5
 
-#ifndef NDEBUG
-grpc_core::TraceFlag grpc_trace_pollable_refcount(false, "pollable_refcount");
-#endif
+grpc_core::DebugOnlyTraceFlag grpc_trace_pollable_refcount(false, "pollable_refcount");
 
 /*******************************************************************************
  * pollable Declarations

src/core/lib/iomgr/ev_posix.cc

@@ -37,10 +37,7 @@
 #include "src/core/lib/support/env.h"
 
 grpc_core::TraceFlag grpc_polling_trace(false, "polling"); /* Disabled by default */
-
-#ifndef NDEBUG
-grpc_core::TraceFlag grpc_trace_fd_refcount(false, "fd_refcount");
-#endif
+grpc_core::DebugOnlyTraceFlag grpc_trace_fd_refcount(false, "fd_refcount");
 
 /** Default poll() function - a pointer so that it can be overridden by some
  *  tests */

src/core/lib/iomgr/pollset.h

@@ -29,9 +29,7 @@
 extern "C" {
 #endif
 
-#ifndef NDEBUG
-extern grpc_core::TraceFlag grpc_trace_fd_refcount;
-#endif
+extern grpc_core::DebugOnlyTraceFlag grpc_trace_fd_refcount;
 
 /* A grpc_pollset is a set of file descriptors that a higher level item is
    interested in. For example:

src/core/lib/security/context/security_context.cc

@@ -29,10 +29,8 @@
 #include <grpc/support/log.h>
 #include <grpc/support/string_util.h>
 
-#ifndef NDEBUG
-grpc_core::TraceFlag grpc_trace_auth_context_refcount(false,
+grpc_core::DebugOnlyTraceFlag grpc_trace_auth_context_refcount(false,
                                                    "auth_context_refcount");
-#endif
 
 /* --- grpc_call --- */
 

src/core/lib/security/context/security_context.h

@@ -22,9 +22,7 @@
 #include "src/core/lib/iomgr/pollset.h"
 #include "src/core/lib/security/credentials/credentials.h"
 
-#ifndef NDEBUG
-extern grpc_core::TraceFlag grpc_trace_auth_context_refcount;
-#endif
+extern grpc_core::DebugOnlyTraceFlag grpc_trace_auth_context_refcount;
 
 #ifdef __cplusplus
 extern "C" {

src/core/lib/security/transport/security_connector.cc

@@ -44,10 +44,8 @@
 #include "src/core/tsi/ssl_transport_security.h"
 #include "src/core/tsi/transport_security_adapter.h"
 
-#ifndef NDEBUG
-grpc_core::TraceFlag grpc_trace_security_connector_refcount(
+grpc_core::DebugOnlyTraceFlag grpc_trace_security_connector_refcount(
     false, "security_connector_refcount");
-#endif
 
 /* -- Constants. -- */
 

src/core/lib/security/transport/security_connector.h

@@ -33,9 +33,7 @@
 extern "C" {
 #endif
 
-#ifndef NDEBUG
-extern grpc_core::TraceFlag grpc_trace_security_connector_refcount;
-#endif
+extern grpc_core::DebugOnlyTraceFlag grpc_trace_security_connector_refcount;
 
 /* --- status enum. --- */
 

src/core/lib/surface/alarm.cc

@@ -27,9 +27,7 @@
 #include "src/core/lib/iomgr/timer.h"
 #include "src/core/lib/surface/completion_queue.h"
 
-#ifndef NDEBUG
-grpc_core::TraceFlag grpc_trace_alarm_refcount(false, "alarm_refcount");
-#endif
+grpc_core::DebugOnlyTraceFlag grpc_trace_alarm_refcount(false, "alarm_refcount");
 
 struct grpc_alarm {
   gpr_refcount refs;

src/core/lib/surface/alarm_internal.h

@@ -26,9 +26,9 @@
 extern "C" {
 #endif
 
-#ifndef NDEBUG
+extern grpc_core::DebugOnlyTraceFlag grpc_trace_alarm_refcount;
 
-extern grpc_core::TraceFlag grpc_trace_alarm_refcount;
+#ifndef NDEBUG
 
 #define GRPC_ALARM_REF(a, reason) alarm_ref_dbg(a, reason, __FILE__, __LINE__)
 #define GRPC_ALARM_UNREF(a, reason) \

src/core/lib/surface/completion_queue.cc

@@ -41,10 +41,8 @@
 #include "src/core/lib/surface/event_string.h"
 
 grpc_core::TraceFlag grpc_trace_operation_failures(false, "op_failure");
-#ifndef NDEBUG
-grpc_core::TraceFlag grpc_trace_pending_tags(false, "pending_tags");
-grpc_core::TraceFlag grpc_trace_cq_refcount(false, "cq_refcount");
-#endif
+grpc_core::DebugOnlyTraceFlag grpc_trace_pending_tags(false, "pending_tags");
+grpc_core::DebugOnlyTraceFlag grpc_trace_cq_refcount(false, "cq_refcount");
 
 // Specifies a cq thread local cache.
 // The first event that occurs on a thread

src/core/lib/surface/completion_queue.h

@@ -30,11 +30,8 @@
 extern grpc_core::TraceFlag grpc_cq_pluck_trace;
 extern grpc_core::TraceFlag grpc_cq_event_timeout_trace;
 extern grpc_core::TraceFlag grpc_trace_operation_failures;
-
-#ifndef NDEBUG
-extern grpc_core::TraceFlag grpc_trace_pending_tags;
-extern grpc_core::TraceFlag grpc_trace_cq_refcount;
-#endif
+extern grpc_core::DebugOnlyTraceFlag grpc_trace_pending_tags;
+extern grpc_core::DebugOnlyTraceFlag grpc_trace_cq_refcount;
 
 #ifdef __cplusplus
 extern "C" {

src/core/lib/surface/init.cc

@@ -126,10 +126,6 @@ void grpc_init(void) {
     grpc_slice_intern_init();
     grpc_mdctx_global_init();
     grpc_channel_init_init();
-
-#ifndef NDEBUG
-
-#endif
     grpc_security_pre_init();
     grpc_iomgr_init(&exec_ctx);
     gpr_timers_global_init();

src/core/lib/surface/init_secure.cc

@@ -32,16 +32,9 @@
 #include "src/core/lib/security/transport/security_handshaker.h"
 #include "src/core/lib/surface/channel_init.h"
 #include "src/core/tsi/transport_security_interface.h"
-
-#ifndef NDEBUG
 #include "src/core/lib/security/context/security_context.h"
-#endif
-
-void grpc_security_pre_init(void) {
-#ifndef NDEBUG
 
-#endif
-}
+void grpc_security_pre_init(void) {}
 
 static bool maybe_prepend_client_auth_filter(
     grpc_exec_ctx* exec_ctx, grpc_channel_stack_builder* builder, void* arg) {

src/core/lib/transport/metadata.cc

@@ -48,8 +48,9 @@
  * used to determine which kind of element a pointer refers to.
  */
 
+grpc_core::DebugOnlyTraceFlag grpc_trace_metadata(false, "metadata");
+
 #ifndef NDEBUG
-grpc_core::TraceFlag grpc_trace_metadata(false, "metadata");
 #define DEBUG_ARGS , const char *file, int line
 #define FWD_DEBUG_ARGS , file, line
 #define REF_MD_LOCKED(shard, s) ref_md_locked((shard), (s), __FILE__, __LINE__)

src/core/lib/transport/metadata.h

@@ -25,9 +25,7 @@
 
 #include "src/core/lib/iomgr/exec_ctx.h"
 
-#ifndef NDEBUG
-extern grpc_core::TraceFlag grpc_trace_metadata;
-#endif
+extern grpc_core::DebugOnlyTraceFlag grpc_trace_metadata;
 
 #ifdef __cplusplus
 extern "C" {

src/core/lib/transport/transport.cc

@@ -31,9 +31,7 @@
 #include "src/core/lib/support/string.h"
 #include "src/core/lib/transport/transport_impl.h"
 
-#ifndef NDEBUG
-grpc_core::TraceFlag grpc_trace_stream_refcount(false, "stream_refcount");
-#endif
+grpc_core::DebugOnlyTraceFlag grpc_trace_stream_refcount(false, "stream_refcount");
 
 #ifndef NDEBUG
 void grpc_stream_ref(grpc_stream_refcount* refcount, const char* reason) {

src/core/lib/transport/transport.h

@@ -43,9 +43,7 @@ typedef struct grpc_transport grpc_transport;
    for a stream. */
 typedef struct grpc_stream grpc_stream;
 
-#ifndef NDEBUG
-extern grpc_core::TraceFlag grpc_trace_stream_refcount;
-#endif
+extern grpc_core::DebugOnlyTraceFlag grpc_trace_stream_refcount;
 
 typedef struct grpc_stream_refcount {
   gpr_refcount refs;