From 0450157e0657004e6724e69bb820fa7d317e6a8e Mon Sep 17 00:00:00 2001 From: Craig Tiller Date: Wed, 20 Jul 2022 16:48:20 -0700 Subject: [PATCH] [iwyu] Better handle (#30349) * update mapping * run tool * Automated change: Fix sanity tests * fix Co-authored-by: ctiller --- src/core/ext/filters/client_channel/lb_policy.h | 1 - .../ext/filters/client_channel/lb_policy/ring_hash/ring_hash.cc | 1 - .../filters/client_channel/resolver/binder/binder_resolver.cc | 1 - .../client_channel/resolver/dns/c_ares/dns_resolver_ares.cc | 1 - .../client_channel/resolver/google_c2p/google_c2p_resolver.cc | 1 - .../client_channel/resolver/sockaddr/sockaddr_resolver.cc | 1 - .../ext/filters/client_channel/resolver/xds/xds_resolver.cc | 1 - src/core/ext/filters/client_channel/subchannel.cc | 1 - src/core/ext/filters/fault_injection/fault_injection_filter.cc | 1 - src/core/ext/filters/fault_injection/service_config_parser.cc | 1 - .../server_config_selector/server_config_selector_filter.cc | 1 - src/core/ext/xds/xds_cluster.cc | 1 - src/core/ext/xds/xds_endpoint.cc | 1 - src/core/ext/xds/xds_http_rbac_filter.cc | 1 - src/core/ext/xds/xds_lb_policy_registry.cc | 1 - src/core/ext/xds/xds_listener.cc | 1 - src/core/ext/xds/xds_route_config.cc | 1 - src/core/lib/channel/channel_args.h | 1 - src/core/lib/channel/channelz.cc | 1 - src/core/lib/channel/promise_based_filter.h | 1 - src/core/lib/event_engine/iomgr_engine/timer.cc | 1 - src/core/lib/gprpp/manual_constructor.h | 1 - src/core/lib/gprpp/ref_counted_ptr.h | 1 - src/core/lib/gprpp/table.h | 1 - src/core/lib/promise/arena_promise.h | 1 - src/core/lib/promise/context.h | 1 - src/core/lib/promise/detail/basic_join.h | 1 - src/core/lib/promise/detail/basic_seq.h | 1 - src/core/lib/promise/detail/promise_factory.h | 1 - src/core/lib/promise/for_each.h | 1 - src/core/lib/promise/map.h | 1 - src/core/lib/promise/try_seq.h | 1 - src/core/lib/resource_quota/memory_quota.cc | 1 - src/core/lib/security/authorization/rbac_policy.cc | 1 - src/core/lib/security/authorization/rbac_translator.cc | 1 - src/core/lib/security/credentials/plugin/plugin_credentials.cc | 1 - src/core/lib/slice/percent_encoding.cc | 1 - src/core/lib/transport/connectivity_state.cc | 1 - src/core/lib/transport/metadata_batch.h | 1 - src/core/lib/transport/parsed_metadata.h | 1 - src/cpp/server/orca/orca_interceptor.cc | 1 - src/cpp/server/server_cc.cc | 1 - test/core/promise/promise_test.cc | 2 ++ test/core/promise/sleep_test.cc | 2 -- tools/distrib/iwyu_mappings.imp | 1 + 45 files changed, 3 insertions(+), 44 deletions(-) diff --git a/src/core/ext/filters/client_channel/lb_policy.h b/src/core/ext/filters/client_channel/lb_policy.h index 3be781d8b91..1838929498a 100644 --- a/src/core/ext/filters/client_channel/lb_policy.h +++ b/src/core/ext/filters/client_channel/lb_policy.h @@ -24,7 +24,6 @@ #include #include -#include #include #include diff --git a/src/core/ext/filters/client_channel/lb_policy/ring_hash/ring_hash.cc b/src/core/ext/filters/client_channel/lb_policy/ring_hash/ring_hash.cc index 6d16c8e18be..7976956db98 100644 --- a/src/core/ext/filters/client_channel/lb_policy/ring_hash/ring_hash.cc +++ b/src/core/ext/filters/client_channel/lb_policy/ring_hash/ring_hash.cc @@ -27,7 +27,6 @@ #include #include #include -#include #include #include diff --git a/src/core/ext/filters/client_channel/resolver/binder/binder_resolver.cc b/src/core/ext/filters/client_channel/resolver/binder/binder_resolver.cc index d3858e8ce65..5d2d31741f5 100644 --- a/src/core/ext/filters/client_channel/resolver/binder/binder_resolver.cc +++ b/src/core/ext/filters/client_channel/resolver/binder/binder_resolver.cc @@ -26,7 +26,6 @@ #include #include -#include #include #include "absl/memory/memory.h" diff --git a/src/core/ext/filters/client_channel/resolver/dns/c_ares/dns_resolver_ares.cc b/src/core/ext/filters/client_channel/resolver/dns/c_ares/dns_resolver_ares.cc index 927c9d62697..2ed8d6f4ed3 100644 --- a/src/core/ext/filters/client_channel/resolver/dns/c_ares/dns_resolver_ares.cc +++ b/src/core/ext/filters/client_channel/resolver/dns/c_ares/dns_resolver_ares.cc @@ -24,7 +24,6 @@ #include #include #include -#include #include #include diff --git a/src/core/ext/filters/client_channel/resolver/google_c2p/google_c2p_resolver.cc b/src/core/ext/filters/client_channel/resolver/google_c2p/google_c2p_resolver.cc index 1710e7ff5b4..2a87434c2be 100644 --- a/src/core/ext/filters/client_channel/resolver/google_c2p/google_c2p_resolver.cc +++ b/src/core/ext/filters/client_channel/resolver/google_c2p/google_c2p_resolver.cc @@ -23,7 +23,6 @@ #include #include #include -#include #include #include "absl/memory/memory.h" diff --git a/src/core/ext/filters/client_channel/resolver/sockaddr/sockaddr_resolver.cc b/src/core/ext/filters/client_channel/resolver/sockaddr/sockaddr_resolver.cc index d86f87efa0e..ba88e885a1f 100644 --- a/src/core/ext/filters/client_channel/resolver/sockaddr/sockaddr_resolver.cc +++ b/src/core/ext/filters/client_channel/resolver/sockaddr/sockaddr_resolver.cc @@ -19,7 +19,6 @@ #include #include #include -#include #include #include "absl/memory/memory.h" diff --git a/src/core/ext/filters/client_channel/resolver/xds/xds_resolver.cc b/src/core/ext/filters/client_channel/resolver/xds/xds_resolver.cc index a6153dbb609..6c655f5d932 100644 --- a/src/core/ext/filters/client_channel/resolver/xds/xds_resolver.cc +++ b/src/core/ext/filters/client_channel/resolver/xds/xds_resolver.cc @@ -24,7 +24,6 @@ #include #include #include -#include #include #include diff --git a/src/core/ext/filters/client_channel/subchannel.cc b/src/core/ext/filters/client_channel/subchannel.cc index 445d637de5b..ee9dfcd460b 100644 --- a/src/core/ext/filters/client_channel/subchannel.cc +++ b/src/core/ext/filters/client_channel/subchannel.cc @@ -24,7 +24,6 @@ #include #include #include -#include #include #include "absl/status/statusor.h" diff --git a/src/core/ext/filters/fault_injection/fault_injection_filter.cc b/src/core/ext/filters/fault_injection/fault_injection_filter.cc index 34e838ea1ec..20d2b8c7a52 100644 --- a/src/core/ext/filters/fault_injection/fault_injection_filter.cc +++ b/src/core/ext/filters/fault_injection/fault_injection_filter.cc @@ -25,7 +25,6 @@ #include #include #include -#include #include #include "absl/status/status.h" diff --git a/src/core/ext/filters/fault_injection/service_config_parser.cc b/src/core/ext/filters/fault_injection/service_config_parser.cc index 59205405a6f..236ace269e7 100644 --- a/src/core/ext/filters/fault_injection/service_config_parser.cc +++ b/src/core/ext/filters/fault_injection/service_config_parser.cc @@ -19,7 +19,6 @@ #include "src/core/ext/filters/fault_injection/service_config_parser.h" #include -#include #include #include "absl/memory/memory.h" diff --git a/src/core/ext/filters/server_config_selector/server_config_selector_filter.cc b/src/core/ext/filters/server_config_selector/server_config_selector_filter.cc index 2ebcbfa85e1..d8bd4521ffc 100644 --- a/src/core/ext/filters/server_config_selector/server_config_selector_filter.cc +++ b/src/core/ext/filters/server_config_selector/server_config_selector_filter.cc @@ -18,7 +18,6 @@ #include #include -#include #include #include "absl/base/thread_annotations.h" diff --git a/src/core/ext/xds/xds_cluster.cc b/src/core/ext/xds/xds_cluster.cc index f0cbdca823b..072d6388284 100644 --- a/src/core/ext/xds/xds_cluster.cc +++ b/src/core/ext/xds/xds_cluster.cc @@ -20,7 +20,6 @@ #include -#include #include #include "absl/memory/memory.h" diff --git a/src/core/ext/xds/xds_endpoint.cc b/src/core/ext/xds/xds_endpoint.cc index a9e2699e17f..e7e3ce38258 100644 --- a/src/core/ext/xds/xds_endpoint.cc +++ b/src/core/ext/xds/xds_endpoint.cc @@ -21,7 +21,6 @@ #include #include -#include #include #include "absl/memory/memory.h" diff --git a/src/core/ext/xds/xds_http_rbac_filter.cc b/src/core/ext/xds/xds_http_rbac_filter.cc index d22c315e0ec..dab4f95daaa 100644 --- a/src/core/ext/xds/xds_http_rbac_filter.cc +++ b/src/core/ext/xds/xds_http_rbac_filter.cc @@ -24,7 +24,6 @@ #include #include #include -#include #include #include diff --git a/src/core/ext/xds/xds_lb_policy_registry.cc b/src/core/ext/xds/xds_lb_policy_registry.cc index 2b44613d2fe..1824530e268 100644 --- a/src/core/ext/xds/xds_lb_policy_registry.cc +++ b/src/core/ext/xds/xds_lb_policy_registry.cc @@ -21,7 +21,6 @@ #include #include -#include #include #include diff --git a/src/core/ext/xds/xds_listener.cc b/src/core/ext/xds/xds_listener.cc index be2bee44865..05242ab2c79 100644 --- a/src/core/ext/xds/xds_listener.cc +++ b/src/core/ext/xds/xds_listener.cc @@ -21,7 +21,6 @@ #include #include -#include #include #include "absl/memory/memory.h" diff --git a/src/core/ext/xds/xds_route_config.cc b/src/core/ext/xds/xds_route_config.cc index 3490e9123c8..4b1c227885a 100644 --- a/src/core/ext/xds/xds_route_config.cc +++ b/src/core/ext/xds/xds_route_config.cc @@ -25,7 +25,6 @@ #include #include #include -#include #include #include diff --git a/src/core/lib/channel/channel_args.h b/src/core/lib/channel/channel_args.h index 157e07072a6..2fa21ed1302 100644 --- a/src/core/lib/channel/channel_args.h +++ b/src/core/lib/channel/channel_args.h @@ -27,7 +27,6 @@ #include #include #include -#include #include #include "absl/meta/type_traits.h" diff --git a/src/core/lib/channel/channelz.cc b/src/core/lib/channel/channelz.cc index 2d0ccf38d9d..892c644bf4d 100644 --- a/src/core/lib/channel/channelz.cc +++ b/src/core/lib/channel/channelz.cc @@ -23,7 +23,6 @@ #include #include #include -#include #include "absl/status/statusor.h" #include "absl/strings/escaping.h" diff --git a/src/core/lib/channel/promise_based_filter.h b/src/core/lib/channel/promise_based_filter.h index 52e6546d482..e7e816a54b3 100644 --- a/src/core/lib/channel/promise_based_filter.h +++ b/src/core/lib/channel/promise_based_filter.h @@ -26,7 +26,6 @@ #include #include -#include #include #include "absl/container/inlined_vector.h" diff --git a/src/core/lib/event_engine/iomgr_engine/timer.cc b/src/core/lib/event_engine/iomgr_engine/timer.cc index 4ea69235321..f7567271a67 100644 --- a/src/core/lib/event_engine/iomgr_engine/timer.cc +++ b/src/core/lib/event_engine/iomgr_engine/timer.cc @@ -23,7 +23,6 @@ #include #include #include -#include #include #include diff --git a/src/core/lib/gprpp/manual_constructor.h b/src/core/lib/gprpp/manual_constructor.h index 95e57cd0e4c..0d4056daa73 100644 --- a/src/core/lib/gprpp/manual_constructor.h +++ b/src/core/lib/gprpp/manual_constructor.h @@ -25,7 +25,6 @@ #include -#include #include #include "src/core/lib/gprpp/construct_destruct.h" diff --git a/src/core/lib/gprpp/ref_counted_ptr.h b/src/core/lib/gprpp/ref_counted_ptr.h index 586cb66faf4..2547c30b5f6 100644 --- a/src/core/lib/gprpp/ref_counted_ptr.h +++ b/src/core/lib/gprpp/ref_counted_ptr.h @@ -22,7 +22,6 @@ #include #include -#include #include #include "src/core/lib/gprpp/debug_location.h" diff --git a/src/core/lib/gprpp/table.h b/src/core/lib/gprpp/table.h index b174e97cac2..f8e0128bd17 100644 --- a/src/core/lib/gprpp/table.h +++ b/src/core/lib/gprpp/table.h @@ -21,7 +21,6 @@ #include #include -#include #include #include "absl/meta/type_traits.h" diff --git a/src/core/lib/promise/arena_promise.h b/src/core/lib/promise/arena_promise.h index da823406376..4bd5a4d0cd1 100644 --- a/src/core/lib/promise/arena_promise.h +++ b/src/core/lib/promise/arena_promise.h @@ -19,7 +19,6 @@ #include -#include #include #include "absl/meta/type_traits.h" diff --git a/src/core/lib/promise/context.h b/src/core/lib/promise/context.h index 1dc0525c44b..ad8a0e43b55 100644 --- a/src/core/lib/promise/context.h +++ b/src/core/lib/promise/context.h @@ -17,7 +17,6 @@ #include -#include #include #include "src/core/lib/gpr/tls.h" diff --git a/src/core/lib/promise/detail/basic_join.h b/src/core/lib/promise/detail/basic_join.h index 2632b69c23b..b1d0d4cd7e0 100644 --- a/src/core/lib/promise/detail/basic_join.h +++ b/src/core/lib/promise/detail/basic_join.h @@ -22,7 +22,6 @@ #include #include -#include #include #include "absl/types/variant.h" diff --git a/src/core/lib/promise/detail/basic_seq.h b/src/core/lib/promise/detail/basic_seq.h index 93c9facea3d..2687d1f2568 100644 --- a/src/core/lib/promise/detail/basic_seq.h +++ b/src/core/lib/promise/detail/basic_seq.h @@ -21,7 +21,6 @@ #include #include #include -#include #include #include "absl/meta/type_traits.h" diff --git a/src/core/lib/promise/detail/promise_factory.h b/src/core/lib/promise/detail/promise_factory.h index 473512b5bf8..dd333670c96 100644 --- a/src/core/lib/promise/detail/promise_factory.h +++ b/src/core/lib/promise/detail/promise_factory.h @@ -17,7 +17,6 @@ #include -#include #include #include "absl/meta/type_traits.h" diff --git a/src/core/lib/promise/for_each.h b/src/core/lib/promise/for_each.h index add484ad362..100bc5aaa43 100644 --- a/src/core/lib/promise/for_each.h +++ b/src/core/lib/promise/for_each.h @@ -17,7 +17,6 @@ #include -#include #include #include "absl/status/status.h" diff --git a/src/core/lib/promise/map.h b/src/core/lib/promise/map.h index d4090beb69d..1ead82217a9 100644 --- a/src/core/lib/promise/map.h +++ b/src/core/lib/promise/map.h @@ -20,7 +20,6 @@ #include #include -#include #include #include "absl/types/variant.h" diff --git a/src/core/lib/promise/try_seq.h b/src/core/lib/promise/try_seq.h index fcaca8f2fe9..e4b40b5c60d 100644 --- a/src/core/lib/promise/try_seq.h +++ b/src/core/lib/promise/try_seq.h @@ -17,7 +17,6 @@ #include -#include #include #include "absl/meta/type_traits.h" diff --git a/src/core/lib/resource_quota/memory_quota.cc b/src/core/lib/resource_quota/memory_quota.cc index eecc32e2d8b..910a1c6bf23 100644 --- a/src/core/lib/resource_quota/memory_quota.cc +++ b/src/core/lib/resource_quota/memory_quota.cc @@ -21,7 +21,6 @@ #include #include #include -#include #include "absl/status/status.h" #include "absl/strings/str_cat.h" diff --git a/src/core/lib/security/authorization/rbac_policy.cc b/src/core/lib/security/authorization/rbac_policy.cc index a152aebdef8..a63bd7cafb0 100644 --- a/src/core/lib/security/authorization/rbac_policy.cc +++ b/src/core/lib/security/authorization/rbac_policy.cc @@ -17,7 +17,6 @@ #include "src/core/lib/security/authorization/rbac_policy.h" #include -#include #include #include "absl/memory/memory.h" diff --git a/src/core/lib/security/authorization/rbac_translator.cc b/src/core/lib/security/authorization/rbac_translator.cc index 8016b445a6a..82736d9c267 100644 --- a/src/core/lib/security/authorization/rbac_translator.cc +++ b/src/core/lib/security/authorization/rbac_translator.cc @@ -22,7 +22,6 @@ #include #include #include -#include #include #include diff --git a/src/core/lib/security/credentials/plugin/plugin_credentials.cc b/src/core/lib/security/credentials/plugin/plugin_credentials.cc index 467bbfc83fc..ad3e944fcf1 100644 --- a/src/core/lib/security/credentials/plugin/plugin_credentials.cc +++ b/src/core/lib/security/credentials/plugin/plugin_credentials.cc @@ -21,7 +21,6 @@ #include "src/core/lib/security/credentials/plugin/plugin_credentials.h" #include -#include #include "absl/status/status.h" #include "absl/strings/str_cat.h" diff --git a/src/core/lib/slice/percent_encoding.cc b/src/core/lib/slice/percent_encoding.cc index 8f912807437..117e98d7b9f 100644 --- a/src/core/lib/slice/percent_encoding.cc +++ b/src/core/lib/slice/percent_encoding.cc @@ -23,7 +23,6 @@ #include #include -#include #include #include diff --git a/src/core/lib/transport/connectivity_state.cc b/src/core/lib/transport/connectivity_state.cc index 8e5ad9eceb6..bceb381b377 100644 --- a/src/core/lib/transport/connectivity_state.cc +++ b/src/core/lib/transport/connectivity_state.cc @@ -21,7 +21,6 @@ #include "src/core/lib/transport/connectivity_state.h" #include -#include #include diff --git a/src/core/lib/transport/metadata_batch.h b/src/core/lib/transport/metadata_batch.h index 79afb4014bf..ec89c589fe1 100644 --- a/src/core/lib/transport/metadata_batch.h +++ b/src/core/lib/transport/metadata_batch.h @@ -25,7 +25,6 @@ #include #include -#include #include #include "absl/container/inlined_vector.h" diff --git a/src/core/lib/transport/parsed_metadata.h b/src/core/lib/transport/parsed_metadata.h index 82f13500aeb..4c2a8f642ab 100644 --- a/src/core/lib/transport/parsed_metadata.h +++ b/src/core/lib/transport/parsed_metadata.h @@ -21,7 +21,6 @@ #include #include -#include #include #include "absl/functional/function_ref.h" diff --git a/src/cpp/server/orca/orca_interceptor.cc b/src/cpp/server/orca/orca_interceptor.cc index 399f95c5696..09afa6ef828 100644 --- a/src/cpp/server/orca/orca_interceptor.cc +++ b/src/cpp/server/orca/orca_interceptor.cc @@ -20,7 +20,6 @@ #include #include #include -#include #include #include diff --git a/src/cpp/server/server_cc.cc b/src/cpp/server/server_cc.cc index 9c49f73676f..e036a54f443 100644 --- a/src/cpp/server/server_cc.cc +++ b/src/cpp/server/server_cc.cc @@ -25,7 +25,6 @@ #include #include #include -#include #include #include diff --git a/test/core/promise/promise_test.cc b/test/core/promise/promise_test.cc index 8c01687b678..dc123c0ab75 100644 --- a/test/core/promise/promise_test.cc +++ b/test/core/promise/promise_test.cc @@ -14,6 +14,8 @@ #include "src/core/lib/promise/promise.h" +#include + #include "gtest/gtest.h" namespace grpc_core { diff --git a/test/core/promise/sleep_test.cc b/test/core/promise/sleep_test.cc index 204243c0c51..e942b86a255 100644 --- a/test/core/promise/sleep_test.cc +++ b/test/core/promise/sleep_test.cc @@ -14,8 +14,6 @@ #include "src/core/lib/promise/sleep.h" -#include - #include "absl/synchronization/notification.h" #include "gtest/gtest.h" diff --git a/tools/distrib/iwyu_mappings.imp b/tools/distrib/iwyu_mappings.imp index 3f993a9aee5..036298461b1 100644 --- a/tools/distrib/iwyu_mappings.imp +++ b/tools/distrib/iwyu_mappings.imp @@ -4,6 +4,7 @@ { include: ["", "public", "\"src/core/lib/iomgr/sockaddr.h\"", "public"]}, { include: ["", "private", "", "public"] }, { include: ["", "private", "", "public"] }, + { include: ["", "public", "", "public" ] }, # workaround: https://github.com/include-what-you-use/include-what-you-use/issues/908 { symbol: ["std::max", "private", "", "public" ] }, ]