[iwyu] Better handle <type_traits> (#30349)

* update mapping * run tool * Automated change: Fix sanity tests * fix Co-authored-by: ctiller <ctiller@users.noreply.github.com>
3 years ago · 0450157e06
parent df52004032
commit 0450157e06
45 changed files with 3 additions and 44 deletions
--- a/src/core/ext/filters/client_channel/lb_policy.h
+++ b/src/core/ext/filters/client_channel/lb_policy.h
@ -24,7 +24,6 @@

 #include <memory>
 #include <string>
-#include <type_traits>
 #include <utility>
 #include <vector>

--- a/src/core/ext/filters/client_channel/lb_policy/ring_hash/ring_hash.cc
+++ b/src/core/ext/filters/client_channel/lb_policy/ring_hash/ring_hash.cc
@ -27,7 +27,6 @@
 #include <map>
 #include <memory>
 #include <string>
-#include <type_traits>
 #include <utility>
 #include <vector>

--- a/src/core/ext/filters/client_channel/resolver/binder/binder_resolver.cc
+++ b/src/core/ext/filters/client_channel/resolver/binder/binder_resolver.cc
@ -26,7 +26,6 @@

 #include <memory>
 #include <string>
-#include <type_traits>
 #include <utility>

 #include "absl/memory/memory.h"
--- a/src/core/ext/filters/client_channel/resolver/dns/c_ares/dns_resolver_ares.cc
+++ b/src/core/ext/filters/client_channel/resolver/dns/c_ares/dns_resolver_ares.cc
@ -24,7 +24,6 @@
 #include <map>
 #include <memory>
 #include <string>
-#include <type_traits>
 #include <utility>
 #include <vector>

--- a/src/core/ext/filters/client_channel/resolver/google_c2p/google_c2p_resolver.cc
+++ b/src/core/ext/filters/client_channel/resolver/google_c2p/google_c2p_resolver.cc
@ -23,7 +23,6 @@
 #include <memory>
 #include <random>
 #include <string>
-#include <type_traits>
 #include <utility>

 #include "absl/memory/memory.h"
--- a/src/core/ext/filters/client_channel/resolver/sockaddr/sockaddr_resolver.cc
+++ b/src/core/ext/filters/client_channel/resolver/sockaddr/sockaddr_resolver.cc
@ -19,7 +19,6 @@
 #include <algorithm>
 #include <memory>
 #include <string>
-#include <type_traits>
 #include <utility>

 #include "absl/memory/memory.h"
--- a/src/core/ext/filters/client_channel/resolver/xds/xds_resolver.cc
+++ b/src/core/ext/filters/client_channel/resolver/xds/xds_resolver.cc
@ -24,7 +24,6 @@
 #include <map>
 #include <memory>
 #include <string>
-#include <type_traits>
 #include <utility>
 #include <vector>

--- a/src/core/ext/filters/client_channel/subchannel.cc
+++ b/src/core/ext/filters/client_channel/subchannel.cc
@ -24,7 +24,6 @@
 #include <algorithm>
 #include <memory>
 #include <new>
-#include <type_traits>
 #include <utility>

 #include "absl/status/statusor.h"
--- a/src/core/ext/filters/fault_injection/fault_injection_filter.cc
+++ b/src/core/ext/filters/fault_injection/fault_injection_filter.cc
@ -25,7 +25,6 @@
 #include <atomic>
 #include <functional>
 #include <string>
-#include <type_traits>
 #include <utility>

 #include "absl/status/status.h"
--- a/src/core/ext/filters/fault_injection/service_config_parser.cc
+++ b/src/core/ext/filters/fault_injection/service_config_parser.cc
@ -19,7 +19,6 @@
 #include "src/core/ext/filters/fault_injection/service_config_parser.h"

 #include <algorithm>
-#include <type_traits>
 #include <vector>

 #include "absl/memory/memory.h"
--- a/src/core/ext/filters/server_config_selector/server_config_selector_filter.cc
+++ b/src/core/ext/filters/server_config_selector/server_config_selector_filter.cc
@ -18,7 +18,6 @@

 #include <functional>
 #include <memory>
-#include <type_traits>
 #include <utility>

 #include "absl/base/thread_annotations.h"
--- a/src/core/ext/xds/xds_cluster.cc
+++ b/src/core/ext/xds/xds_cluster.cc
@ -20,7 +20,6 @@

 #include <stddef.h>

-#include <type_traits>
 #include <utility>

 #include "absl/memory/memory.h"
--- a/src/core/ext/xds/xds_endpoint.cc
+++ b/src/core/ext/xds/xds_endpoint.cc
@ -21,7 +21,6 @@
 #include <stdlib.h>

 #include <algorithm>
-#include <type_traits>
 #include <vector>

 #include "absl/memory/memory.h"
--- a/src/core/ext/xds/xds_http_rbac_filter.cc
+++ b/src/core/ext/xds/xds_http_rbac_filter.cc
@ -24,7 +24,6 @@
 #include <cstdint>
 #include <map>
 #include <string>
-#include <type_traits>
 #include <utility>
 #include <vector>

--- a/src/core/ext/xds/xds_lb_policy_registry.cc
+++ b/src/core/ext/xds/xds_lb_policy_registry.cc
@ -21,7 +21,6 @@
 #include <stddef.h>

 #include <string>
-#include <type_traits>
 #include <utility>
 #include <vector>

--- a/src/core/ext/xds/xds_listener.cc
+++ b/src/core/ext/xds/xds_listener.cc
@ -21,7 +21,6 @@
 #include <stdint.h>

 #include <set>
-#include <type_traits>
 #include <utility>

 #include "absl/memory/memory.h"
--- a/src/core/ext/xds/xds_route_config.cc
+++ b/src/core/ext/xds/xds_route_config.cc
@ -25,7 +25,6 @@
 #include <memory>
 #include <set>
 #include <string>
-#include <type_traits>
 #include <utility>
 #include <vector>

--- a/src/core/lib/channel/channel_args.h
+++ b/src/core/lib/channel/channel_args.h
@ -27,7 +27,6 @@
 #include <iosfwd>
 #include <memory>
 #include <string>
-#include <type_traits>
 #include <utility>

 #include "absl/meta/type_traits.h"
--- a/src/core/lib/channel/channelz.cc
+++ b/src/core/lib/channel/channelz.cc
@ -23,7 +23,6 @@
 #include <algorithm>
 #include <atomic>
 #include <memory>
-#include <type_traits>

 #include "absl/status/statusor.h"
 #include "absl/strings/escaping.h"
--- a/src/core/lib/channel/promise_based_filter.h
+++ b/src/core/lib/channel/promise_based_filter.h
@ -26,7 +26,6 @@

 #include <atomic>
 #include <new>
-#include <type_traits>
 #include <utility>

 #include "absl/container/inlined_vector.h"
--- a/src/core/lib/event_engine/iomgr_engine/timer.cc
+++ b/src/core/lib/event_engine/iomgr_engine/timer.cc
@ -23,7 +23,6 @@
 #include <algorithm>
 #include <atomic>
 #include <limits>
-#include <type_traits>
 #include <utility>

 #include <grpc/support/cpu.h>
--- a/src/core/lib/gprpp/manual_constructor.h
+++ b/src/core/lib/gprpp/manual_constructor.h
@ -25,7 +25,6 @@

 #include <stddef.h>

-#include <type_traits>
 #include <utility>

 #include "src/core/lib/gprpp/construct_destruct.h"
--- a/src/core/lib/gprpp/ref_counted_ptr.h
+++ b/src/core/lib/gprpp/ref_counted_ptr.h
@ -22,7 +22,6 @@
 #include <grpc/support/port_platform.h>

 #include <iosfwd>
-#include <type_traits>
 #include <utility>

 #include "src/core/lib/gprpp/debug_location.h"
--- a/src/core/lib/gprpp/table.h
+++ b/src/core/lib/gprpp/table.h
@ -21,7 +21,6 @@

 #include <initializer_list>
 #include <new>
-#include <type_traits>
 #include <utility>

 #include "absl/meta/type_traits.h"
--- a/src/core/lib/promise/arena_promise.h
+++ b/src/core/lib/promise/arena_promise.h
@ -19,7 +19,6 @@

 #include <stdlib.h>

-#include <type_traits>
 #include <utility>

 #include "absl/meta/type_traits.h"
--- a/src/core/lib/promise/context.h
+++ b/src/core/lib/promise/context.h
@ -17,7 +17,6 @@

 #include <grpc/support/port_platform.h>

-#include <type_traits>
 #include <utility>

 #include "src/core/lib/gpr/tls.h"
--- a/src/core/lib/promise/detail/basic_join.h
+++ b/src/core/lib/promise/detail/basic_join.h
@ -22,7 +22,6 @@

 #include <array>
 #include <tuple>
-#include <type_traits>
 #include <utility>

 #include "absl/types/variant.h"
--- a/src/core/lib/promise/detail/basic_seq.h
+++ b/src/core/lib/promise/detail/basic_seq.h
@ -21,7 +21,6 @@
 #include <cassert>
 #include <new>
 #include <tuple>
-#include <type_traits>
 #include <utility>

 #include "absl/meta/type_traits.h"
--- a/src/core/lib/promise/detail/promise_factory.h
+++ b/src/core/lib/promise/detail/promise_factory.h
@ -17,7 +17,6 @@

 #include <grpc/support/port_platform.h>

-#include <type_traits>
 #include <utility>

 #include "absl/meta/type_traits.h"
--- a/src/core/lib/promise/for_each.h
+++ b/src/core/lib/promise/for_each.h
@ -17,7 +17,6 @@

 #include <grpc/support/port_platform.h>

-#include <type_traits>
 #include <utility>

 #include "absl/status/status.h"
--- a/src/core/lib/promise/map.h
+++ b/src/core/lib/promise/map.h
@ -20,7 +20,6 @@
 #include <stddef.h>

 #include <tuple>
-#include <type_traits>
 #include <utility>

 #include "absl/types/variant.h"
--- a/src/core/lib/promise/try_seq.h
+++ b/src/core/lib/promise/try_seq.h
@ -17,7 +17,6 @@

 #include <grpc/support/port_platform.h>

-#include <type_traits>
 #include <utility>

 #include "absl/meta/type_traits.h"
--- a/src/core/lib/resource_quota/memory_quota.cc
+++ b/src/core/lib/resource_quota/memory_quota.cc
@ -21,7 +21,6 @@
 #include <algorithm>
 #include <atomic>
 #include <tuple>
-#include <type_traits>

 #include "absl/status/status.h"
 #include "absl/strings/str_cat.h"
--- a/src/core/lib/security/authorization/rbac_policy.cc
+++ b/src/core/lib/security/authorization/rbac_policy.cc
@ -17,7 +17,6 @@
 #include "src/core/lib/security/authorization/rbac_policy.h"

 #include <algorithm>
-#include <type_traits>
 #include <utility>

 #include "absl/memory/memory.h"
--- a/src/core/lib/security/authorization/rbac_translator.cc
+++ b/src/core/lib/security/authorization/rbac_translator.cc
@ -22,7 +22,6 @@
 #include <map>
 #include <memory>
 #include <string>
-#include <type_traits>
 #include <utility>
 #include <vector>

--- a/src/core/lib/security/credentials/plugin/plugin_credentials.cc
+++ b/src/core/lib/security/credentials/plugin/plugin_credentials.cc
@ -21,7 +21,6 @@
 #include "src/core/lib/security/credentials/plugin/plugin_credentials.h"

 #include <atomic>
-#include <type_traits>

 #include "absl/status/status.h"
 #include "absl/strings/str_cat.h"
--- a/src/core/lib/slice/percent_encoding.cc
+++ b/src/core/lib/slice/percent_encoding.cc
@ -23,7 +23,6 @@
 #include <stdlib.h>

 #include <cstdint>
-#include <type_traits>
 #include <utility>

 #include <grpc/support/log.h>
--- a/src/core/lib/transport/connectivity_state.cc
+++ b/src/core/lib/transport/connectivity_state.cc
@ -21,7 +21,6 @@
 #include "src/core/lib/transport/connectivity_state.h"

 #include <string>
-#include <type_traits>

 #include <grpc/support/log.h>

--- a/src/core/lib/transport/metadata_batch.h
+++ b/src/core/lib/transport/metadata_batch.h
@ -25,7 +25,6 @@

 #include <cstdint>
 #include <string>
-#include <type_traits>
 #include <utility>

 #include "absl/container/inlined_vector.h"
--- a/src/core/lib/transport/parsed_metadata.h
+++ b/src/core/lib/transport/parsed_metadata.h
@ -21,7 +21,6 @@

 #include <cstdint>
 #include <string>
-#include <type_traits>
 #include <utility>

 #include "absl/functional/function_ref.h"
--- a/src/cpp/server/orca/orca_interceptor.cc
+++ b/src/cpp/server/orca/orca_interceptor.cc
@ -20,7 +20,6 @@
 #include <map>
 #include <memory>
 #include <string>
-#include <type_traits>
 #include <utility>
 #include <vector>

--- a/src/cpp/server/server_cc.cc
+++ b/src/cpp/server/server_cc.cc
@ -25,7 +25,6 @@
 #include <new>
 #include <sstream>
 #include <string>
-#include <type_traits>
 #include <utility>
 #include <vector>

--- a/test/core/promise/promise_test.cc
+++ b/test/core/promise/promise_test.cc
@ -14,6 +14,8 @@

 #include "src/core/lib/promise/promise.h"

+#include <type_traits>
+
 #include "gtest/gtest.h"

 namespace grpc_core {
--- a/test/core/promise/sleep_test.cc
+++ b/test/core/promise/sleep_test.cc
@ -14,8 +14,6 @@

 #include "src/core/lib/promise/sleep.h"

-#include <type_traits>
-
 #include "absl/synchronization/notification.h"
 #include "gtest/gtest.h"

--- a/tools/distrib/iwyu_mappings.imp
+++ b/tools/distrib/iwyu_mappings.imp
@ -4,6 +4,7 @@
    { include: ["<sys/socket.h>", "public", "\"src/core/lib/iomgr/sockaddr.h\"", "public"]},
    { include: ["<openssl/base.h>", "private", "<openssl/crypto.h>", "public"] },
    { include: ["<openssl/digest.h>", "private", "<openssl/evp.h>", "public"] },
+    { include: ["<type_traits>", "public", "<utility>", "public" ] },
    # workaround: https://github.com/include-what-you-use/include-what-you-use/issues/908
    { symbol: ["std::max", "private", "<algorithm>", "public" ] },
 ]