From 041c283ccc70b634b9e66bc962701be9db3ea218 Mon Sep 17 00:00:00 2001
From: Yash Tibrewal <yashkt@google.com>
Date: Fri, 22 Mar 2024 17:28:13 -0700
Subject: [PATCH] [experiments] Fix initialization order fiasco (#36168)

Internal ref : b/324720620

Closes #36168

COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/36168 from yashykt:FixStaticOrderInitFiasco 14f2a8950300911295fa4260629fc72bdb0af61e
PiperOrigin-RevId: 618328195
---
 src/core/lib/experiments/config.cc            | 33 +++++++++++--------
 ...ed-retry_streaming_fuzzer-6651400812036096 |  0
 2 files changed, 20 insertions(+), 13 deletions(-)
 create mode 100644 test/core/end2end/end2end_test_corpus/retry_streaming/clusterfuzz-testcase-minimized-retry_streaming_fuzzer-6651400812036096

diff --git a/src/core/lib/experiments/config.cc b/src/core/lib/experiments/config.cc
index 4210ccc3055..ee5f7836693 100644
--- a/src/core/lib/experiments/config.cc
+++ b/src/core/lib/experiments/config.cc
@@ -49,9 +49,16 @@ struct ForcedExperiment {
   bool forced = false;
   bool value;
 };
-ForcedExperiment g_forced_experiments[kNumExperiments];
 
-std::atomic<bool> g_loaded(false);
+ForcedExperiment* ForcedExperiments() {
+  static NoDestruct<ForcedExperiment> forced_experiments[kNumExperiments];
+  return &**forced_experiments;
+}
+
+std::atomic<bool>* Loaded() {
+  static NoDestruct<std::atomic<bool>> loaded(false);
+  return &*loaded;
+}
 
 absl::AnyInvocable<bool(struct ExperimentMetadata)>* g_check_constraints_cb =
     nullptr;
@@ -98,7 +105,7 @@ GPR_ATTRIBUTE_NOINLINE Experiments LoadExperimentsFromConfigVariableInner() {
   // Set defaults from metadata.
   Experiments experiments;
   for (size_t i = 0; i < kNumExperiments; i++) {
-    if (!g_forced_experiments[i].forced) {
+    if (!ForcedExperiments()[i].forced) {
       if (g_check_constraints_cb != nullptr) {
         experiments.enabled[i] =
             (*g_check_constraints_cb)(g_experiment_metadata[i]);
@@ -106,7 +113,7 @@ GPR_ATTRIBUTE_NOINLINE Experiments LoadExperimentsFromConfigVariableInner() {
         experiments.enabled[i] = g_experiment_metadata[i].default_value;
       }
     } else {
-      experiments.enabled[i] = g_forced_experiments[i].value;
+      experiments.enabled[i] = ForcedExperiments()[i].value;
     }
   }
   // For each comma-separated experiment in the global config:
@@ -151,7 +158,7 @@ GPR_ATTRIBUTE_NOINLINE Experiments LoadExperimentsFromConfigVariableInner() {
 }
 
 Experiments LoadExperimentsFromConfigVariable() {
-  g_loaded.store(true, std::memory_order_relaxed);
+  Loaded()->store(true, std::memory_order_relaxed);
   return LoadExperimentsFromConfigVariableInner();
 }
 
@@ -193,7 +200,7 @@ void PrintExperimentsList() {
     const char* name = g_experiment_metadata[i].name;
     const bool enabled = IsExperimentEnabled(i);
     const bool default_enabled = g_experiment_metadata[i].default_value;
-    const bool forced = g_forced_experiments[i].forced;
+    const bool forced = ForcedExperiments()[i].forced;
     if (!default_enabled && !enabled) continue;
     if (default_enabled && enabled) {
       defaulted_on_experiments.insert(name);
@@ -205,13 +212,13 @@ void PrintExperimentsList() {
         experiment_status[name] = "on:constraints";
         continue;
       }
-      if (forced && g_forced_experiments[i].value) {
+      if (forced && ForcedExperiments()[i].value) {
         experiment_status[name] = "on:forced";
         continue;
       }
       experiment_status[name] = "on";
     } else {
-      if (forced && !g_forced_experiments[i].value) {
+      if (forced && !ForcedExperiments()[i].value) {
         experiment_status[name] = "off:forced";
         continue;
       }
@@ -238,14 +245,14 @@ void PrintExperimentsList() {
 }
 
 void ForceEnableExperiment(absl::string_view experiment, bool enable) {
-  GPR_ASSERT(g_loaded.load(std::memory_order_relaxed) == false);
+  GPR_ASSERT(Loaded()->load(std::memory_order_relaxed) == false);
   for (size_t i = 0; i < kNumExperiments; i++) {
     if (g_experiment_metadata[i].name != experiment) continue;
-    if (g_forced_experiments[i].forced) {
-      GPR_ASSERT(g_forced_experiments[i].value == enable);
+    if (ForcedExperiments()[i].forced) {
+      GPR_ASSERT(ForcedExperiments()[i].value == enable);
     } else {
-      g_forced_experiments[i].forced = true;
-      g_forced_experiments[i].value = enable;
+      ForcedExperiments()[i].forced = true;
+      ForcedExperiments()[i].value = enable;
     }
     return;
   }
diff --git a/test/core/end2end/end2end_test_corpus/retry_streaming/clusterfuzz-testcase-minimized-retry_streaming_fuzzer-6651400812036096 b/test/core/end2end/end2end_test_corpus/retry_streaming/clusterfuzz-testcase-minimized-retry_streaming_fuzzer-6651400812036096
new file mode 100644
index 00000000000..e69de29bb2d