diff --git a/CMakeLists.txt b/CMakeLists.txt index a35b971bd1b..36d1eff31a4 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -1194,7 +1194,6 @@ if(gRPC_BUILD_TESTS) add_dependencies(buildtests_cxx percent_encoding_test) add_dependencies(buildtests_cxx periodic_update_test) add_dependencies(buildtests_cxx pick_first_test) - add_dependencies(buildtests_cxx pid_controller_test) add_dependencies(buildtests_cxx ping_abuse_policy_test) add_dependencies(buildtests_cxx ping_callbacks_test) add_dependencies(buildtests_cxx ping_configuration_test) @@ -2503,7 +2502,6 @@ add_library(grpc src/core/lib/transport/http_connect_handshaker.cc src/core/lib/transport/metadata_batch.cc src/core/lib/transport/parsed_metadata.cc - src/core/lib/transport/pid_controller.cc src/core/lib/transport/status_conversion.cc src/core/lib/transport/tcp_connect_handshaker.cc src/core/lib/transport/timeout_encoding.cc @@ -3196,7 +3194,6 @@ add_library(grpc_unsecure src/core/lib/transport/http_connect_handshaker.cc src/core/lib/transport/metadata_batch.cc src/core/lib/transport/parsed_metadata.cc - src/core/lib/transport/pid_controller.cc src/core/lib/transport/status_conversion.cc src/core/lib/transport/tcp_connect_handshaker.cc src/core/lib/transport/timeout_encoding.cc @@ -12228,7 +12225,6 @@ add_executable(flow_control_test src/core/lib/slice/slice_refcount.cc src/core/lib/slice/slice_string_helpers.cc src/core/lib/transport/bdp_estimator.cc - src/core/lib/transport/pid_controller.cc test/core/transport/chttp2/flow_control_test.cc third_party/upb/upb/hash/common.c third_party/upb/upb/message/accessors.c @@ -17803,49 +17799,6 @@ target_link_libraries(pick_first_test ) -endif() -if(gRPC_BUILD_TESTS) - -add_executable(pid_controller_test - test/core/transport/pid_controller_test.cc - test/core/util/cmdline.cc - test/core/util/fuzzer_util.cc - test/core/util/grpc_profiler.cc - test/core/util/histogram.cc - test/core/util/mock_endpoint.cc - test/core/util/parse_hexstring.cc - test/core/util/passthru_endpoint.cc - test/core/util/resolve_localhost_ip46.cc - test/core/util/slice_splitter.cc - test/core/util/tracer_util.cc -) -target_compile_features(pid_controller_test PUBLIC cxx_std_14) -target_include_directories(pid_controller_test - PRIVATE - ${CMAKE_CURRENT_SOURCE_DIR} - ${CMAKE_CURRENT_SOURCE_DIR}/include - ${_gRPC_ADDRESS_SORTING_INCLUDE_DIR} - ${_gRPC_RE2_INCLUDE_DIR} - ${_gRPC_SSL_INCLUDE_DIR} - ${_gRPC_UPB_GENERATED_DIR} - ${_gRPC_UPB_GRPC_GENERATED_DIR} - ${_gRPC_UPB_INCLUDE_DIR} - ${_gRPC_XXHASH_INCLUDE_DIR} - ${_gRPC_ZLIB_INCLUDE_DIR} - third_party/googletest/googletest/include - third_party/googletest/googletest - third_party/googletest/googlemock/include - third_party/googletest/googlemock - ${_gRPC_PROTO_GENS_DIR} -) - -target_link_libraries(pid_controller_test - ${_gRPC_ALLTARGETS_LIBRARIES} - gtest - grpc_test_util -) - - endif() if(gRPC_BUILD_TESTS) diff --git a/Makefile b/Makefile index d9931302394..2d6aafe331a 100644 --- a/Makefile +++ b/Makefile @@ -1704,7 +1704,6 @@ LIBGRPC_SRC = \ src/core/lib/transport/http_connect_handshaker.cc \ src/core/lib/transport/metadata_batch.cc \ src/core/lib/transport/parsed_metadata.cc \ - src/core/lib/transport/pid_controller.cc \ src/core/lib/transport/status_conversion.cc \ src/core/lib/transport/tcp_connect_handshaker.cc \ src/core/lib/transport/timeout_encoding.cc \ @@ -2247,7 +2246,6 @@ LIBGRPC_UNSECURE_SRC = \ src/core/lib/transport/http_connect_handshaker.cc \ src/core/lib/transport/metadata_batch.cc \ src/core/lib/transport/parsed_metadata.cc \ - src/core/lib/transport/pid_controller.cc \ src/core/lib/transport/status_conversion.cc \ src/core/lib/transport/tcp_connect_handshaker.cc \ src/core/lib/transport/timeout_encoding.cc \ diff --git a/Package.swift b/Package.swift index 7fa98e64126..21046aebb2e 100644 --- a/Package.swift +++ b/Package.swift @@ -1895,8 +1895,6 @@ let package = Package( "src/core/lib/transport/metadata_compression_traits.h", "src/core/lib/transport/parsed_metadata.cc", "src/core/lib/transport/parsed_metadata.h", - "src/core/lib/transport/pid_controller.cc", - "src/core/lib/transport/pid_controller.h", "src/core/lib/transport/simple_slice_based_metadata.h", "src/core/lib/transport/status_conversion.cc", "src/core/lib/transport/status_conversion.h", diff --git a/build_autogenerated.yaml b/build_autogenerated.yaml index 2e7cd202f5c..d1386af91cf 100644 --- a/build_autogenerated.yaml +++ b/build_autogenerated.yaml @@ -1173,7 +1173,6 @@ libs: - src/core/lib/transport/metadata_batch.h - src/core/lib/transport/metadata_compression_traits.h - src/core/lib/transport/parsed_metadata.h - - src/core/lib/transport/pid_controller.h - src/core/lib/transport/simple_slice_based_metadata.h - src/core/lib/transport/status_conversion.h - src/core/lib/transport/tcp_connect_handshaker.h @@ -1962,7 +1961,6 @@ libs: - src/core/lib/transport/http_connect_handshaker.cc - src/core/lib/transport/metadata_batch.cc - src/core/lib/transport/parsed_metadata.cc - - src/core/lib/transport/pid_controller.cc - src/core/lib/transport/status_conversion.cc - src/core/lib/transport/tcp_connect_handshaker.cc - src/core/lib/transport/timeout_encoding.cc @@ -2603,7 +2601,6 @@ libs: - src/core/lib/transport/metadata_batch.h - src/core/lib/transport/metadata_compression_traits.h - src/core/lib/transport/parsed_metadata.h - - src/core/lib/transport/pid_controller.h - src/core/lib/transport/simple_slice_based_metadata.h - src/core/lib/transport/status_conversion.h - src/core/lib/transport/tcp_connect_handshaker.h @@ -3013,7 +3010,6 @@ libs: - src/core/lib/transport/http_connect_handshaker.cc - src/core/lib/transport/metadata_batch.cc - src/core/lib/transport/parsed_metadata.cc - - src/core/lib/transport/pid_controller.cc - src/core/lib/transport/status_conversion.cc - src/core/lib/transport/tcp_connect_handshaker.cc - src/core/lib/transport/timeout_encoding.cc @@ -9280,7 +9276,6 @@ targets: - src/core/lib/slice/slice_string_helpers.h - src/core/lib/transport/bdp_estimator.h - src/core/lib/transport/http2_errors.h - - src/core/lib/transport/pid_controller.h - third_party/upb/upb/base/internal/log2.h - third_party/upb/upb/generated_code_support.h - third_party/upb/upb/hash/common.h @@ -9362,7 +9357,6 @@ targets: - src/core/lib/slice/slice_refcount.cc - src/core/lib/slice/slice_string_helpers.cc - src/core/lib/transport/bdp_estimator.cc - - src/core/lib/transport/pid_controller.cc - test/core/transport/chttp2/flow_control_test.cc - third_party/upb/upb/hash/common.c - third_party/upb/upb/message/accessors.c @@ -12709,38 +12703,6 @@ targets: - protobuf - grpc_test_util uses_polling: false -- name: pid_controller_test - gtest: true - build: test - language: c++ - headers: - - test/core/util/cmdline.h - - test/core/util/evaluate_args_test_util.h - - test/core/util/fuzzer_util.h - - test/core/util/grpc_profiler.h - - test/core/util/histogram.h - - test/core/util/mock_authorization_endpoint.h - - test/core/util/mock_endpoint.h - - test/core/util/parse_hexstring.h - - test/core/util/passthru_endpoint.h - - test/core/util/resolve_localhost_ip46.h - - test/core/util/slice_splitter.h - - test/core/util/tracer_util.h - src: - - test/core/transport/pid_controller_test.cc - - test/core/util/cmdline.cc - - test/core/util/fuzzer_util.cc - - test/core/util/grpc_profiler.cc - - test/core/util/histogram.cc - - test/core/util/mock_endpoint.cc - - test/core/util/parse_hexstring.cc - - test/core/util/passthru_endpoint.cc - - test/core/util/resolve_localhost_ip46.cc - - test/core/util/slice_splitter.cc - - test/core/util/tracer_util.cc - deps: - - gtest - - grpc_test_util - name: ping_abuse_policy_test gtest: true build: test diff --git a/config.m4 b/config.m4 index ad0d6caee28..4e1ab8b797d 100644 --- a/config.m4 +++ b/config.m4 @@ -836,7 +836,6 @@ if test "$PHP_GRPC" != "no"; then src/core/lib/transport/http_connect_handshaker.cc \ src/core/lib/transport/metadata_batch.cc \ src/core/lib/transport/parsed_metadata.cc \ - src/core/lib/transport/pid_controller.cc \ src/core/lib/transport/status_conversion.cc \ src/core/lib/transport/tcp_connect_handshaker.cc \ src/core/lib/transport/timeout_encoding.cc \ diff --git a/config.w32 b/config.w32 index f18a8de275d..6a3925a7f58 100644 --- a/config.w32 +++ b/config.w32 @@ -801,7 +801,6 @@ if (PHP_GRPC != "no") { "src\\core\\lib\\transport\\http_connect_handshaker.cc " + "src\\core\\lib\\transport\\metadata_batch.cc " + "src\\core\\lib\\transport\\parsed_metadata.cc " + - "src\\core\\lib\\transport\\pid_controller.cc " + "src\\core\\lib\\transport\\status_conversion.cc " + "src\\core\\lib\\transport\\tcp_connect_handshaker.cc " + "src\\core\\lib\\transport\\timeout_encoding.cc " + diff --git a/gRPC-C++.podspec b/gRPC-C++.podspec index 83f07e2fe62..4d3bbfc3707 100644 --- a/gRPC-C++.podspec +++ b/gRPC-C++.podspec @@ -1268,7 +1268,6 @@ Pod::Spec.new do |s| 'src/core/lib/transport/metadata_batch.h', 'src/core/lib/transport/metadata_compression_traits.h', 'src/core/lib/transport/parsed_metadata.h', - 'src/core/lib/transport/pid_controller.h', 'src/core/lib/transport/simple_slice_based_metadata.h', 'src/core/lib/transport/status_conversion.h', 'src/core/lib/transport/tcp_connect_handshaker.h', @@ -2508,7 +2507,6 @@ Pod::Spec.new do |s| 'src/core/lib/transport/metadata_batch.h', 'src/core/lib/transport/metadata_compression_traits.h', 'src/core/lib/transport/parsed_metadata.h', - 'src/core/lib/transport/pid_controller.h', 'src/core/lib/transport/simple_slice_based_metadata.h', 'src/core/lib/transport/status_conversion.h', 'src/core/lib/transport/tcp_connect_handshaker.h', diff --git a/gRPC-Core.podspec b/gRPC-Core.podspec index 64a415514b5..a9991a0c108 100644 --- a/gRPC-Core.podspec +++ b/gRPC-Core.podspec @@ -1994,8 +1994,6 @@ Pod::Spec.new do |s| 'src/core/lib/transport/metadata_compression_traits.h', 'src/core/lib/transport/parsed_metadata.cc', 'src/core/lib/transport/parsed_metadata.h', - 'src/core/lib/transport/pid_controller.cc', - 'src/core/lib/transport/pid_controller.h', 'src/core/lib/transport/simple_slice_based_metadata.h', 'src/core/lib/transport/status_conversion.cc', 'src/core/lib/transport/status_conversion.h', @@ -3274,7 +3272,6 @@ Pod::Spec.new do |s| 'src/core/lib/transport/metadata_batch.h', 'src/core/lib/transport/metadata_compression_traits.h', 'src/core/lib/transport/parsed_metadata.h', - 'src/core/lib/transport/pid_controller.h', 'src/core/lib/transport/simple_slice_based_metadata.h', 'src/core/lib/transport/status_conversion.h', 'src/core/lib/transport/tcp_connect_handshaker.h', diff --git a/grpc.gemspec b/grpc.gemspec index 82993ca7ac9..5e1c1e5e523 100644 --- a/grpc.gemspec +++ b/grpc.gemspec @@ -1897,8 +1897,6 @@ Gem::Specification.new do |s| s.files += %w( src/core/lib/transport/metadata_compression_traits.h ) s.files += %w( src/core/lib/transport/parsed_metadata.cc ) s.files += %w( src/core/lib/transport/parsed_metadata.h ) - s.files += %w( src/core/lib/transport/pid_controller.cc ) - s.files += %w( src/core/lib/transport/pid_controller.h ) s.files += %w( src/core/lib/transport/simple_slice_based_metadata.h ) s.files += %w( src/core/lib/transport/status_conversion.cc ) s.files += %w( src/core/lib/transport/status_conversion.h ) diff --git a/grpc.gyp b/grpc.gyp index 0cd7bdb032f..1cc0c2611b5 100644 --- a/grpc.gyp +++ b/grpc.gyp @@ -1023,7 +1023,6 @@ 'src/core/lib/transport/http_connect_handshaker.cc', 'src/core/lib/transport/metadata_batch.cc', 'src/core/lib/transport/parsed_metadata.cc', - 'src/core/lib/transport/pid_controller.cc', 'src/core/lib/transport/status_conversion.cc', 'src/core/lib/transport/tcp_connect_handshaker.cc', 'src/core/lib/transport/timeout_encoding.cc', @@ -1507,7 +1506,6 @@ 'src/core/lib/transport/http_connect_handshaker.cc', 'src/core/lib/transport/metadata_batch.cc', 'src/core/lib/transport/parsed_metadata.cc', - 'src/core/lib/transport/pid_controller.cc', 'src/core/lib/transport/status_conversion.cc', 'src/core/lib/transport/tcp_connect_handshaker.cc', 'src/core/lib/transport/timeout_encoding.cc', diff --git a/package.xml b/package.xml index 9ed1cf552fb..2d1f0310663 100644 --- a/package.xml +++ b/package.xml @@ -1879,8 +1879,6 @@ - - diff --git a/src/python/grpcio/grpc_core_dependencies.py b/src/python/grpcio/grpc_core_dependencies.py index bd30eef8d32..37a00f2a6cc 100644 --- a/src/python/grpcio/grpc_core_dependencies.py +++ b/src/python/grpcio/grpc_core_dependencies.py @@ -810,7 +810,6 @@ CORE_SOURCE_FILES = [ 'src/core/lib/transport/http_connect_handshaker.cc', 'src/core/lib/transport/metadata_batch.cc', 'src/core/lib/transport/parsed_metadata.cc', - 'src/core/lib/transport/pid_controller.cc', 'src/core/lib/transport/status_conversion.cc', 'src/core/lib/transport/tcp_connect_handshaker.cc', 'src/core/lib/transport/timeout_encoding.cc', diff --git a/tools/doxygen/Doxyfile.c++.internal b/tools/doxygen/Doxyfile.c++.internal index eb1463dcf92..55c117406ce 100644 --- a/tools/doxygen/Doxyfile.c++.internal +++ b/tools/doxygen/Doxyfile.c++.internal @@ -2896,8 +2896,6 @@ src/core/lib/transport/metadata_batch.h \ src/core/lib/transport/metadata_compression_traits.h \ src/core/lib/transport/parsed_metadata.cc \ src/core/lib/transport/parsed_metadata.h \ -src/core/lib/transport/pid_controller.cc \ -src/core/lib/transport/pid_controller.h \ src/core/lib/transport/simple_slice_based_metadata.h \ src/core/lib/transport/status_conversion.cc \ src/core/lib/transport/status_conversion.h \ diff --git a/tools/doxygen/Doxyfile.core.internal b/tools/doxygen/Doxyfile.core.internal index e6ba72b8f5c..276f467c07d 100644 --- a/tools/doxygen/Doxyfile.core.internal +++ b/tools/doxygen/Doxyfile.core.internal @@ -2677,8 +2677,6 @@ src/core/lib/transport/metadata_batch.h \ src/core/lib/transport/metadata_compression_traits.h \ src/core/lib/transport/parsed_metadata.cc \ src/core/lib/transport/parsed_metadata.h \ -src/core/lib/transport/pid_controller.cc \ -src/core/lib/transport/pid_controller.h \ src/core/lib/transport/simple_slice_based_metadata.h \ src/core/lib/transport/status_conversion.cc \ src/core/lib/transport/status_conversion.h \ diff --git a/tools/run_tests/generated/tests.json b/tools/run_tests/generated/tests.json index 97e35cd758b..07038cc8e80 100644 --- a/tools/run_tests/generated/tests.json +++ b/tools/run_tests/generated/tests.json @@ -6601,30 +6601,6 @@ ], "uses_polling": false }, - { - "args": [], - "benchmark": false, - "ci_platforms": [ - "linux", - "mac", - "posix", - "windows" - ], - "cpu_cost": 1.0, - "exclude_configs": [], - "exclude_iomgrs": [], - "flaky": false, - "gtest": true, - "language": "c++", - "name": "pid_controller_test", - "platforms": [ - "linux", - "mac", - "posix", - "windows" - ], - "uses_polling": true - }, { "args": [], "benchmark": false,