From 015ab35a2875059c9047de2286c22c96a01628cb Mon Sep 17 00:00:00 2001 From: Jorge Canizales Date: Thu, 6 Aug 2015 16:51:44 -0700 Subject: [PATCH] Clarify intention of the code that adds a default port --- src/objective-c/GRPCClient/private/GRPCHost.m | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/objective-c/GRPCClient/private/GRPCHost.m b/src/objective-c/GRPCClient/private/GRPCHost.m index 14bde92d984..6636c486202 100644 --- a/src/objective-c/GRPCClient/private/GRPCHost.m +++ b/src/objective-c/GRPCClient/private/GRPCHost.m @@ -58,8 +58,10 @@ // Default initializer. - (instancetype)initWithAddress:(NSString *)address { - // To provide a default port, we try to interpret the address. - // TODO(jcanizales): Add unit tests for the types of addresses we want to let pass through. + // To provide a default port, we try to interpret the address. If it's just a host name without + // scheme and without port, we'll use port 443. If it has a scheme, we pass it untouched to the C + // gRPC library. + // TODO(jcanizales): Add unit tests for the types of addresses we want to let pass untouched. NSURL *hostURL = [NSURL URLWithString:[@"https://" stringByAppendingString:address]]; if (hostURL && !hostURL.port) { address = [hostURL.host stringByAppendingString:@":443"];