Merge pull request #17528 from grpc/revert-17466-exit_tests

Revert "re-enable ExitTest"
pull/17531/head
Juanli Shen 6 years ago committed by GitHub
commit 00be85a3e1
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 8
      src/python/grpcio_tests/commands.py
  2. 15
      src/python/grpcio_tests/tests/unit/_exit_test.py

@ -133,14 +133,6 @@ class TestGevent(setuptools.Command):
# TODO(https://github.com/grpc/grpc/issues/15411) unpin gevent version # TODO(https://github.com/grpc/grpc/issues/15411) unpin gevent version
# This test will stuck while running higher version of gevent # This test will stuck while running higher version of gevent
'unit._auth_context_test.AuthContextTest.testSessionResumption', 'unit._auth_context_test.AuthContextTest.testSessionResumption',
# TODO(https://github.com/grpc/grpc/issues/15411) enable these tests
'unit._exit_test.ExitTest.test_in_flight_unary_unary_call',
'unit._exit_test.ExitTest.test_in_flight_unary_stream_call',
'unit._exit_test.ExitTest.test_in_flight_stream_unary_call',
'unit._exit_test.ExitTest.test_in_flight_stream_stream_call',
'unit._exit_test.ExitTest.test_in_flight_partial_unary_stream_call',
'unit._exit_test.ExitTest.test_in_flight_partial_stream_unary_call',
'unit._exit_test.ExitTest.test_in_flight_partial_stream_stream_call',
# TODO(https://github.com/grpc/grpc/issues/17330) enable these three tests # TODO(https://github.com/grpc/grpc/issues/17330) enable these three tests
'channelz._channelz_servicer_test.ChannelzServicerTest.test_many_subchannels', 'channelz._channelz_servicer_test.ChannelzServicerTest.test_many_subchannels',
'channelz._channelz_servicer_test.ChannelzServicerTest.test_many_subchannels_and_sockets', 'channelz._channelz_servicer_test.ChannelzServicerTest.test_many_subchannels_and_sockets',

@ -71,6 +71,7 @@ def wait(process):
process.wait() process.wait()
@unittest.skip('https://github.com/grpc/grpc/issues/7311')
class ExitTest(unittest.TestCase): class ExitTest(unittest.TestCase):
def test_unstarted_server(self): def test_unstarted_server(self):
@ -129,8 +130,6 @@ class ExitTest(unittest.TestCase):
stderr=sys.stderr) stderr=sys.stderr)
interrupt_and_wait(process) interrupt_and_wait(process)
@unittest.skipIf(os.name == 'nt',
'os.kill does not have required permission on Windows')
def test_in_flight_unary_unary_call(self): def test_in_flight_unary_unary_call(self):
process = subprocess.Popen( process = subprocess.Popen(
BASE_COMMAND + [_exit_scenarios.IN_FLIGHT_UNARY_UNARY_CALL], BASE_COMMAND + [_exit_scenarios.IN_FLIGHT_UNARY_UNARY_CALL],
@ -139,8 +138,6 @@ class ExitTest(unittest.TestCase):
interrupt_and_wait(process) interrupt_and_wait(process)
@unittest.skipIf(six.PY2, 'https://github.com/grpc/grpc/issues/6999') @unittest.skipIf(six.PY2, 'https://github.com/grpc/grpc/issues/6999')
@unittest.skipIf(os.name == 'nt',
'os.kill does not have required permission on Windows')
def test_in_flight_unary_stream_call(self): def test_in_flight_unary_stream_call(self):
process = subprocess.Popen( process = subprocess.Popen(
BASE_COMMAND + [_exit_scenarios.IN_FLIGHT_UNARY_STREAM_CALL], BASE_COMMAND + [_exit_scenarios.IN_FLIGHT_UNARY_STREAM_CALL],
@ -148,8 +145,6 @@ class ExitTest(unittest.TestCase):
stderr=sys.stderr) stderr=sys.stderr)
interrupt_and_wait(process) interrupt_and_wait(process)
@unittest.skipIf(os.name == 'nt',
'os.kill does not have required permission on Windows')
def test_in_flight_stream_unary_call(self): def test_in_flight_stream_unary_call(self):
process = subprocess.Popen( process = subprocess.Popen(
BASE_COMMAND + [_exit_scenarios.IN_FLIGHT_STREAM_UNARY_CALL], BASE_COMMAND + [_exit_scenarios.IN_FLIGHT_STREAM_UNARY_CALL],
@ -158,8 +153,6 @@ class ExitTest(unittest.TestCase):
interrupt_and_wait(process) interrupt_and_wait(process)
@unittest.skipIf(six.PY2, 'https://github.com/grpc/grpc/issues/6999') @unittest.skipIf(six.PY2, 'https://github.com/grpc/grpc/issues/6999')
@unittest.skipIf(os.name == 'nt',
'os.kill does not have required permission on Windows')
def test_in_flight_stream_stream_call(self): def test_in_flight_stream_stream_call(self):
process = subprocess.Popen( process = subprocess.Popen(
BASE_COMMAND + [_exit_scenarios.IN_FLIGHT_STREAM_STREAM_CALL], BASE_COMMAND + [_exit_scenarios.IN_FLIGHT_STREAM_STREAM_CALL],
@ -168,8 +161,6 @@ class ExitTest(unittest.TestCase):
interrupt_and_wait(process) interrupt_and_wait(process)
@unittest.skipIf(six.PY2, 'https://github.com/grpc/grpc/issues/6999') @unittest.skipIf(six.PY2, 'https://github.com/grpc/grpc/issues/6999')
@unittest.skipIf(os.name == 'nt',
'os.kill does not have required permission on Windows')
def test_in_flight_partial_unary_stream_call(self): def test_in_flight_partial_unary_stream_call(self):
process = subprocess.Popen( process = subprocess.Popen(
BASE_COMMAND + BASE_COMMAND +
@ -178,8 +169,6 @@ class ExitTest(unittest.TestCase):
stderr=sys.stderr) stderr=sys.stderr)
interrupt_and_wait(process) interrupt_and_wait(process)
@unittest.skipIf(os.name == 'nt',
'os.kill does not have required permission on Windows')
def test_in_flight_partial_stream_unary_call(self): def test_in_flight_partial_stream_unary_call(self):
process = subprocess.Popen( process = subprocess.Popen(
BASE_COMMAND + BASE_COMMAND +
@ -189,8 +178,6 @@ class ExitTest(unittest.TestCase):
interrupt_and_wait(process) interrupt_and_wait(process)
@unittest.skipIf(six.PY2, 'https://github.com/grpc/grpc/issues/6999') @unittest.skipIf(six.PY2, 'https://github.com/grpc/grpc/issues/6999')
@unittest.skipIf(os.name == 'nt',
'os.kill does not have required permission on Windows')
def test_in_flight_partial_stream_stream_call(self): def test_in_flight_partial_stream_stream_call(self):
process = subprocess.Popen( process = subprocess.Popen(
BASE_COMMAND + BASE_COMMAND +

Loading…
Cancel
Save