|
|
|
%YAML 1.2
|
|
|
|
--- |
|
|
|
|
PHP_ARG_ENABLE(grpc, whether to enable grpc support,
|
|
|
|
[ --enable-grpc Enable grpc support])
|
|
|
|
|
|
|
|
if test "$PHP_GRPC" != "no"; then
|
|
|
|
dnl Write more examples of tests here...
|
|
|
|
|
|
|
|
dnl # --with-grpc -> add include path
|
|
|
|
PHP_ADD_INCLUDE(PHP_EXT_SRCDIR()/include)
|
|
|
|
PHP_ADD_INCLUDE(PHP_EXT_SRCDIR()/src/core/ext/upb-generated)
|
|
|
|
PHP_ADD_INCLUDE(PHP_EXT_SRCDIR()/src/core/ext/upbdefs-generated)
|
|
|
|
PHP_ADD_INCLUDE(PHP_EXT_SRCDIR()/src/php/ext/grpc)
|
|
|
|
PHP_ADD_INCLUDE(PHP_EXT_SRCDIR()/third_party/abseil-cpp)
|
|
|
|
PHP_ADD_INCLUDE(PHP_EXT_SRCDIR()/third_party/address_sorting/include)
|
|
|
|
PHP_ADD_INCLUDE(PHP_EXT_SRCDIR()/third_party/boringssl-with-bazel/src/include)
|
|
|
|
PHP_ADD_INCLUDE(PHP_EXT_SRCDIR()/third_party/re2)
|
|
|
|
PHP_ADD_INCLUDE(PHP_EXT_SRCDIR()/third_party/upb)
|
[protobuf] Upgrade third_party/protobuf to 22.x (#32606)
The very non-trivial upgrade of third_party/protobuf to 22.x
This PR strives to be as small as possible and many changes that were
compatible with protobuf 21.x and didn't have to be merged atomically
with the upgrade were already merged.
Due to the complexity of the upgrade, this PR wasn't created
automatically by a tool, but manually. Subsequent upgraded of
third_party/protobuf with our OSS release script should work again once
this change is merged.
This is best reviewed commit-by-commit, I tried to group changes in
logical areas.
Notable changes:
- the upgrade of third_party/protobuf submodule, the bazel protobuf
dependency itself
- upgrade of UPB dependency to 22.x (in the past, we used to always
upgrade upb to "main", but upb now has release branch as well). UPB
needs to be upgraded atomically with protobuf since there's a de-facto
circular dependency (new protobuf depends on new upb, which depends on
new protobuf for codegen).
- some protobuf and upb bazel rules are now aliases, so `
extract_metadata_from_bazel_xml.py` and `gen_upb_api_from_bazel_xml.py`
had to be modified to be able to follow aliases and reach the actual
aliased targets.
- some protobuf public headers were renamed, so especially
`src/compiler` needed to be updated to use the new headers.
- protobuf and upb now both depend on utf8_range project, so since we
bundle upb with grpc in some languages, we now have to bundle utf8_range
as well (hence changes in build for python, PHP, objC, cmake etc).
- protoc now depends on absl and utf8_range (previously protobuf had
absl dependency, but not for the codegen part), so python's
make_grpcio_tools.py required partial rewrite to be able to handle those
dependencies in the grpcio_tools build.
- many updates and fixes required for C++ distribtests (currently they
all pass, but we'll probably need to follow up, make protobuf's and
grpc's handling of dependencies more aligned and revisit the
distribtests)
- bunch of other changes mostly due to overhaul of protobuf's and upb's
internal build layout.
TODOs:
- [DONE] make sure IWYU and clang_tidy_code pass
- create a list of followups (e.g. work to reenable the few tests I had
to disable and to remove workaround I had to use)
- [DONE in cl/523706129] figure out problem(s) with internal import
---------
Co-authored-by: Craig Tiller <ctiller@google.com>
2 years ago
|
|
|
PHP_ADD_INCLUDE(PHP_EXT_SRCDIR()/third_party/utf8_range)
|
|
|
|
PHP_ADD_INCLUDE(PHP_EXT_SRCDIR()/third_party/xxhash)
|
|
|
|
|
|
|
|
LIBS="-lpthread $LIBS"
|
|
|
|
|
|
|
|
CFLAGS="-std=c11 -g -O2"
|
|
|
|
CXXFLAGS="-std=c++14 -fno-exceptions -fno-rtti -g -O2"
|
|
|
|
GRPC_SHARED_LIBADD="-lpthread $GRPC_SHARED_LIBADD"
|
|
|
|
PHP_REQUIRE_CXX()
|
|
|
|
PHP_ADD_LIBRARY(pthread)
|
|
|
|
PHP_ADD_LIBRARY(dl,,GRPC_SHARED_LIBADD)
|
|
|
|
PHP_ADD_LIBRARY(dl)
|
|
|
|
|
|
|
|
case $host in
|
|
|
|
*darwin*)
|
|
|
|
PHP_ADD_LIBRARY(c++,1,GRPC_SHARED_LIBADD)
|
|
|
|
;;
|
|
|
|
*)
|
|
|
|
PHP_ADD_LIBRARY(stdc++,1,GRPC_SHARED_LIBADD)
|
|
|
|
PHP_ADD_LIBRARY(rt,,GRPC_SHARED_LIBADD)
|
|
|
|
PHP_ADD_LIBRARY(rt)
|
|
|
|
;;
|
|
|
|
esac
|
|
|
|
|
|
|
|
PHP_SUBST(GRPC_SHARED_LIBADD)
|
|
|
|
<%
|
|
|
|
srcs = []
|
|
|
|
srcs.extend(php_config_m4.src)
|
|
|
|
lib_maps = {lib.name: lib for lib in libs}
|
|
|
|
php_deps = php_config_m4.get('deps', [])
|
|
|
|
php_full_deps = []
|
|
|
|
for dep in php_deps:
|
|
|
|
php_full_deps.append(dep)
|
[build metadata] Bazel to "other build systems" improvements (#33803)
- Extract build metadata for some external dependencies from bazel
build. This is achieved by letting extract_metadata_from_bazel_xml.py
analyze some external libraries and sources. The logic is basically the
same as for internal libraries, I only needed to teach
extract_metadata_from_bazel_xml.py which external libraries it is
allowed to analyze.
* currently, the list of source files is automatically determined for
`z`, `upb`, `re2` and `gtest` dependencies (at least for the case where
we're building in "embedded" mode - e.g. mostly native extensions for
python, php, ruby etc. - cmake has the ability to replace some of these
dependencies by actual cmake dependency.)
- Eliminate the need for manually written gen_build_yaml.py for some
dependencies.
- Make the info on target dependencies in build_autogenerated.yaml more
accurate and complete. Until now, there were some depdendencies that
were allowed to show up in build_autogenerated.yaml and some that were
being skipped. This made generating the CMakeLists.txt and Makefile
quite confusing (since some dependencies are being explicitly mentioned
and some had to be assumed by the build system).
- Overhaul the Makefile
* the Makefile is currently only used internally (e.g. for ruby and PHP
builds)
* until now, the makefile wasn't really using the info about which
targets depend on what libraries, but it was effectively hardcoding the
depedendency data (by magically "knowing" what is the list of all the
stuff that e.g. "grpc" depends on).
* After the overhaul, the Makefile.template now actually looks at the
library dependencies and uses them when generating the makefile. This
gives a more correct and easier to maintain makefile.
* since csharp is no longer on the master branch, remove all mentions of
"csharp" targets in the Makefile.
Other notable changes:
- make extract_metadata_from_bazel_xml.py capable of resolving workspace
bind() rules (so that it knows the real name of the target that is
referred to as e.g. `//external:xyz`)
TODO:
- [DONE] ~~pkgconfig C++ distribtest~~
- [DONE} ~~update third_party/README to reflect changes in how some deps
get updated now.~~
Planned followups:
- cleanup naming of some targets in build metadata and buildsystem
templates: libssl vs boringssl, ares vs cares etc.
- further cleanup of Makefile
- further cleanup of CMakeLists.txt
- remote the need from manually hardcoding extra metadata for targets in
build_autogenerated.yaml. Either add logic that determines the
properties of targets automatically, or use metadata from bazel BUILD.
1 year ago
|
|
|
lib = lib_maps.get(dep, None)
|
|
|
|
if lib:
|
|
|
|
php_full_deps.extend(lib.transitive_deps)
|
|
|
|
# construct list of all source files, but explicitly exclude zlib and cares
|
|
|
|
for dep in set(php_full_deps) - set({'z', 'cares'}):
|
[build metadata] Bazel to "other build systems" improvements (#33803)
- Extract build metadata for some external dependencies from bazel
build. This is achieved by letting extract_metadata_from_bazel_xml.py
analyze some external libraries and sources. The logic is basically the
same as for internal libraries, I only needed to teach
extract_metadata_from_bazel_xml.py which external libraries it is
allowed to analyze.
* currently, the list of source files is automatically determined for
`z`, `upb`, `re2` and `gtest` dependencies (at least for the case where
we're building in "embedded" mode - e.g. mostly native extensions for
python, php, ruby etc. - cmake has the ability to replace some of these
dependencies by actual cmake dependency.)
- Eliminate the need for manually written gen_build_yaml.py for some
dependencies.
- Make the info on target dependencies in build_autogenerated.yaml more
accurate and complete. Until now, there were some depdendencies that
were allowed to show up in build_autogenerated.yaml and some that were
being skipped. This made generating the CMakeLists.txt and Makefile
quite confusing (since some dependencies are being explicitly mentioned
and some had to be assumed by the build system).
- Overhaul the Makefile
* the Makefile is currently only used internally (e.g. for ruby and PHP
builds)
* until now, the makefile wasn't really using the info about which
targets depend on what libraries, but it was effectively hardcoding the
depedendency data (by magically "knowing" what is the list of all the
stuff that e.g. "grpc" depends on).
* After the overhaul, the Makefile.template now actually looks at the
library dependencies and uses them when generating the makefile. This
gives a more correct and easier to maintain makefile.
* since csharp is no longer on the master branch, remove all mentions of
"csharp" targets in the Makefile.
Other notable changes:
- make extract_metadata_from_bazel_xml.py capable of resolving workspace
bind() rules (so that it knows the real name of the target that is
referred to as e.g. `//external:xyz`)
TODO:
- [DONE] ~~pkgconfig C++ distribtest~~
- [DONE} ~~update third_party/README to reflect changes in how some deps
get updated now.~~
Planned followups:
- cleanup naming of some targets in build metadata and buildsystem
templates: libssl vs boringssl, ares vs cares etc.
- further cleanup of Makefile
- further cleanup of CMakeLists.txt
- remote the need from manually hardcoding extra metadata for targets in
build_autogenerated.yaml. Either add logic that determines the
properties of targets automatically, or use metadata from bazel BUILD.
1 year ago
|
|
|
lib = lib_maps.get(dep, None)
|
|
|
|
if lib:
|
|
|
|
srcs.extend(lib.src)
|
|
|
|
srcs = sorted(set(srcs))
|
|
|
|
%>
|
|
|
|
PHP_NEW_EXTENSION(grpc,
|
|
|
|
% for src in srcs:
|
|
|
|
${src} ${"\\"}
|
|
|
|
% endfor
|
|
|
|
, $ext_shared, , -fvisibility=hidden ${"\\"}
|
|
|
|
-DOPENSSL_NO_ASM -D_GNU_SOURCE -DWIN32_LEAN_AND_MEAN ${"\\"}
|
|
|
|
-D_HAS_EXCEPTIONS=0 -DNOMINMAX -DGRPC_ARES=0 ${"\\"}
|
|
|
|
-DGRPC_POSIX_FORK_ALLOW_PTHREAD_ATFORK=1 ${"\\"}
|
|
|
|
-DGRPC_XDS_USER_AGENT_NAME_SUFFIX='"\"PHP\""' ${"\\"}
|
|
|
|
-DGRPC_XDS_USER_AGENT_VERSION_SUFFIX='"\"${settings.php_version.php()}\""')
|
|
|
|
<%
|
|
|
|
dirs = sorted(set(src[:src.rfind('/')] for src in srcs))
|
|
|
|
%>
|
|
|
|
% for dir in dirs:
|
|
|
|
PHP_ADD_BUILD_DIR($ext_builddir/${dir})
|
|
|
|
% endfor
|
|
|
|
fi
|