The C based gRPC (C++, Python, Ruby, Objective-C, PHP, C#) https://grpc.io/
You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

122 lines
3.6 KiB

[EventEngine] PosixEventEngine DNS Resolver (#32701) This PR implements a c-ares based DNS resolver for EventEngine with the reference from the original [grpc_ares_wrapper.h](../blob/master/src/core/ext/filters/client_channel/resolver/dns/c_ares/grpc_ares_wrapper.h). The PosixEventEngine DNSResolver is implemented on top of that. Tests which use the client channel resolver API ([resolver.h](../blob/master/src/core/lib/resolver/resolver.h#L54)) are ported, namely the [resolver_component_test.cc](../blob/master/test/cpp/naming/resolver_component_test.cc) and the [cancel_ares_query_test.cc](../blob/master/test/cpp/naming/cancel_ares_query_test.cc). The WindowsEventEngine DNSResolver will use the same EventEngine's grpc_ares_wrapper and will be worked on next. The [resolve_address_test.cc](https://github.com/grpc/grpc/blob/master/test/core/iomgr/resolve_address_test.cc) which uses the iomgr [DNSResolver](../blob/master/src/core/lib/iomgr/resolve_address.h#L44) API has been ported to EventEngine's dns_test.cc. That leaves only 2 tests which use iomgr's API, notably the [dns_resolver_cooldown_test.cc](../blob/master/test/core/client_channel/resolvers/dns_resolver_cooldown_test.cc) and the [goaway_server_test.cc](../blob/master/test/core/end2end/goaway_server_test.cc) which probably need to be restructured to use EventEngine DNSResolver (for one thing they override the original grpc_ares_wrapper's free functions). I will try to tackle these in the next step. <!-- If you know who should review your pull request, please assign it to that person, otherwise the pull request would get assigned randomly. If your pull request is for a specific language, please add the appropriate lang label. -->
1 year ago
#!/usr/bin/env python3
# Copyright 2023 The gRPC Authors.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
import argparse
import platform
import subprocess
import sys
import time
def test_runner_log(msg):
sys.stderr.write("\n%s: %s\n" % (__file__, msg))
def python_args(arg_list):
[EventEngine] WindowsDNSResolver Implementation (#34400) Design is documented at [go/windows-dns-resolver-issue](http://go/windows-dns-resolver-issue) (note that the design doc is slightly outdated regarding the shared ownership model of the virtual socket that was implemented in https://github.com/grpc/grpc/pull/34400/commits/13bd2b404eee1770c73f70d5ef49638f7b0e0dd2). Passed `//test/cpp/naming:resolver_component_tests_runner_invoker` and `//test/cpp/naming:cancel_ares_query_test`: ``` C:\Users\yijiem\projects\grpc>bazel --output_base=C:\bazel6 test --dynamic_mode=off --verbose_failures --test_env=GRPC_EXPERIMENTS=event_engine_dns --test_env=GRPC_VERBOSITY=debug --test_env=GRPC_TRACE=cares_resolver --enable_runfiles=yes --nocache_test_results //test/cpp/naming:resolver_component_tests_runner_invoker INFO: Analyzed target //test/cpp/naming:resolver_component_tests_runner_invoker (1 packages loaded, 8 targets configured). INFO: Found 1 test target... INFO: From Compiling src/core/lib/event_engine/windows/windows_engine.cc: C:\bazel6\execroot\com_github_grpc_grpc\src/core/lib/channel/channel_args.h(287): warning C4312: 'reinterpret_cast': conversion from 'int' to 'void *' of greater size Target //test/cpp/naming:resolver_component_tests_runner_invoker up-to-date: bazel-bin/test/cpp/naming/resolver_component_tests_runner_invoker.exe INFO: Elapsed time: 230.374s, Critical Path: 228.54s INFO: 9 processes: 2 internal, 7 local. INFO: Build completed successfully, 9 total actions //test/cpp/naming:resolver_component_tests_runner_invoker PASSED in 221.2s Executed 1 out of 1 test: 1 test passes. ``` ``` C:\Users\yijiem\projects\grpc>bazel --output_base=C:\bazel6 test --dynamic_mode=off --verbose_failures --test_env=GRPC_EXPERIMENTS=event_engine_dns --test_env=GRPC_VERBOSITY=debug --test_env=GRPC_TRACE=cares_resolver --enable_runfiles=yes --nocache_test_results //test/cpp/naming:cancel_ares_query_test INFO: Analyzed target //test/cpp/naming:cancel_ares_query_test (0 packages loaded, 0 targets configured). INFO: Found 1 test target... Target //test/cpp/naming:cancel_ares_query_test up-to-date: bazel-bin/test/cpp/naming/cancel_ares_query_test.exe INFO: Elapsed time: 49.656s, Critical Path: 48.00s INFO: 6 processes: 2 internal, 4 local. INFO: Build completed successfully, 6 total actions //test/cpp/naming:cancel_ares_query_test PASSED in 43.0s Executed 1 out of 1 test: 1 test passes. ``` <!-- If you know who should review your pull request, please assign it to that person, otherwise the pull request would get assigned randomly. If your pull request is for a specific language, please add the appropriate lang label. -->
1 year ago
if platform.system() == "Windows" and arg_list[0].endswith(".py"):
[EventEngine] PosixEventEngine DNS Resolver (#32701) This PR implements a c-ares based DNS resolver for EventEngine with the reference from the original [grpc_ares_wrapper.h](../blob/master/src/core/ext/filters/client_channel/resolver/dns/c_ares/grpc_ares_wrapper.h). The PosixEventEngine DNSResolver is implemented on top of that. Tests which use the client channel resolver API ([resolver.h](../blob/master/src/core/lib/resolver/resolver.h#L54)) are ported, namely the [resolver_component_test.cc](../blob/master/test/cpp/naming/resolver_component_test.cc) and the [cancel_ares_query_test.cc](../blob/master/test/cpp/naming/cancel_ares_query_test.cc). The WindowsEventEngine DNSResolver will use the same EventEngine's grpc_ares_wrapper and will be worked on next. The [resolve_address_test.cc](https://github.com/grpc/grpc/blob/master/test/core/iomgr/resolve_address_test.cc) which uses the iomgr [DNSResolver](../blob/master/src/core/lib/iomgr/resolve_address.h#L44) API has been ported to EventEngine's dns_test.cc. That leaves only 2 tests which use iomgr's API, notably the [dns_resolver_cooldown_test.cc](../blob/master/test/core/client_channel/resolvers/dns_resolver_cooldown_test.cc) and the [goaway_server_test.cc](../blob/master/test/core/end2end/goaway_server_test.cc) which probably need to be restructured to use EventEngine DNSResolver (for one thing they override the original grpc_ares_wrapper's free functions). I will try to tackle these in the next step. <!-- If you know who should review your pull request, please assign it to that person, otherwise the pull request would get assigned randomly. If your pull request is for a specific language, please add the appropriate lang label. -->
1 year ago
return [sys.executable] + arg_list
return arg_list
def wait_until_dns_server_is_up(args):
for i in range(0, 30):
test_runner_log(
"Health check: attempt to connect to DNS server over TCP."
)
tcp_connect_subprocess = subprocess.Popen(
python_args(
[
args.tcp_connect_bin_path,
"--server_host",
"127.0.0.1",
"--server_port",
str(args.dns_server_port),
"--timeout",
str(1),
]
)
)
tcp_connect_subprocess.communicate()
if tcp_connect_subprocess.returncode == 0:
test_runner_log(
(
"Health check: attempt to make an A-record "
"query to DNS server."
)
)
dns_resolver_subprocess = subprocess.Popen(
python_args(
[
args.dns_resolver_bin_path,
"--qname",
"health-check-local-dns-server-is-alive.resolver-tests.grpctestingexp",
"--server_host",
"127.0.0.1",
"--server_port",
str(args.dns_server_port),
]
),
stdout=subprocess.PIPE,
)
dns_resolver_stdout, _ = dns_resolver_subprocess.communicate(
str.encode("ascii")
)
if dns_resolver_subprocess.returncode == 0:
if "123.123.123.123".encode("ascii") in dns_resolver_stdout:
test_runner_log(
(
"DNS server is up! "
"Successfully reached it over UDP and TCP."
)
)
return
time.sleep(1)
test_runner_log(
(
"Failed to reach DNS server over TCP and/or UDP. "
"Exitting without running tests."
)
)
sys.exit(1)
def main():
argp = argparse.ArgumentParser(description="Make DNS queries for A records")
argp.add_argument(
"-p",
"--dns_server_port",
default=None,
type=int,
help=("Port that local DNS server is listening on."),
)
argp.add_argument(
"--dns_resolver_bin_path",
default=None,
type=str,
help=("Path to the DNS health check utility."),
)
argp.add_argument(
"--tcp_connect_bin_path",
default=None,
type=str,
help=("Path to the TCP health check utility."),
)
args = argp.parse_args()
wait_until_dns_server_is_up(args)
if __name__ == "__main__":
main()