fix!: Remove DiscoverConnectionProfile method signature which didn't populate the request sufficiently

fix!: Overhaul resource annotations, some of which were incorrect and some of which were just non-ideal

PiperOrigin-RevId: 382316023
pull/662/head
Google APIs 4 years ago committed by Copybara-Service
parent 1c5c56c18a
commit 125799dc99
  1. 27
      google/cloud/datastream/v1alpha1/datastream.proto
  2. 4
      google/cloud/datastream/v1alpha1/datastream_resources.proto
  3. 4
      google/cloud/datastream/v1alpha1/datastream_v1alpha1.yaml

@ -96,13 +96,12 @@ service Datastream {
// Use this method to discover a connection profile.
// The discover API call exposes the data objects and metadata belonging to
// the profile. Typically, a request returns children data objects under a
// parent data object thats optionally supplied in the request.
// parent data object that's optionally supplied in the request.
rpc DiscoverConnectionProfile(DiscoverConnectionProfileRequest) returns (DiscoverConnectionProfileResponse) {
option (google.api.http) = {
post: "/v1alpha1/{parent=projects/*/locations/*}/connectionProfiles:discover"
body: "*"
};
option (google.api.method_signature) = "parent";
}
// Use this method to list streams in a project and location.
@ -173,7 +172,7 @@ service Datastream {
// The FetchStaticIps API call exposes the static ips used by Datastream.
// Typically, a request returns children data objects under
// a parent data object thats optionally supplied in the request.
// a parent data object that's optionally supplied in the request.
rpc FetchStaticIps(FetchStaticIpsRequest) returns (FetchStaticIpsResponse) {
option (google.api.http) = {
get: "/v1alpha1/{name=projects/*/locations/*}:fetchStaticIps"
@ -274,7 +273,7 @@ message DiscoverConnectionProfileRequest {
string parent = 1 [
(google.api.field_behavior) = REQUIRED,
(google.api.resource_reference) = {
type: "locations.googleapis.com/Location"
child_type: "datastream.googleapis.com/ConnectionProfile"
}
];
@ -415,7 +414,7 @@ message CreateConnectionProfileRequest {
string parent = 1 [
(google.api.field_behavior) = REQUIRED,
(google.api.resource_reference) = {
type: "datastream.googleapis.com/ConnectionProfile"
child_type: "datastream.googleapis.com/ConnectionProfile"
}
];
@ -548,7 +547,7 @@ message CreateStreamRequest {
string parent = 1 [
(google.api.field_behavior) = REQUIRED,
(google.api.resource_reference) = {
type: "datastream.googleapis.com/Stream"
child_type: "datastream.googleapis.com/Stream"
}
];
@ -675,7 +674,7 @@ message CreatePrivateConnectionRequest {
string parent = 1 [
(google.api.field_behavior) = REQUIRED,
(google.api.resource_reference) = {
type: "locations.googleapis.com/Location"
child_type: "datastream.googleapis.com/PrivateConnection"
}
];
@ -706,7 +705,7 @@ message ListPrivateConnectionsRequest {
string parent = 1 [
(google.api.field_behavior) = REQUIRED,
(google.api.resource_reference) = {
type: "locations.googleapis.com/Location"
child_type: "datastream.googleapis.com/PrivateConnection"
}
];
@ -748,7 +747,7 @@ message DeletePrivateConnectionRequest {
string name = 1 [
(google.api.field_behavior) = REQUIRED,
(google.api.resource_reference) = {
type: "locations.googleapis.com/Location"
type: "datastream.googleapis.com/PrivateConnection"
}
];
@ -777,7 +776,7 @@ message GetPrivateConnectionRequest {
string name = 1 [
(google.api.field_behavior) = REQUIRED,
(google.api.resource_reference) = {
type: "locations.googleapis.com/Location"
type: "datastream.googleapis.com/PrivateConnection"
}
];
}
@ -788,7 +787,7 @@ message CreateRouteRequest {
string parent = 1 [
(google.api.field_behavior) = REQUIRED,
(google.api.resource_reference) = {
type: "datastream.googleapis.com/PrivateConnection"
child_type: "datastream.googleapis.com/Route"
}
];
@ -820,7 +819,7 @@ message ListRoutesRequest {
string parent = 1 [
(google.api.field_behavior) = REQUIRED,
(google.api.resource_reference) = {
type: "datastream.googleapis.com/PrivateConnection"
child_type: "datastream.googleapis.com/Route"
}
];
@ -864,7 +863,7 @@ message DeleteRouteRequest {
string name = 1 [
(google.api.field_behavior) = REQUIRED,
(google.api.resource_reference) = {
type: "datastream.googleapis.com/PrivateConnection"
type: "datastream.googleapis.com/Route"
}
];
@ -890,7 +889,7 @@ message GetRouteRequest {
string name = 1 [
(google.api.field_behavior) = REQUIRED,
(google.api.resource_reference) = {
type: "datastream.googleapis.com/PrivateConnection"
type: "datastream.googleapis.com/Route"
}
];
}

@ -508,7 +508,7 @@ message Stream {
pattern: "projects/{project}/locations/{location}/streams/{stream}"
};
// Backfill strategy to automatically backfill the Streams objects.
// Backfill strategy to automatically backfill the Stream's objects.
// Specific objects can be excluded.
message BackfillAllStrategy {
// List of objects to exclude.
@ -521,7 +521,7 @@ message Stream {
}
}
// Backfill strategy to disable automatic backfill for the Streams objects.
// Backfill strategy to disable automatic backfill for the Stream's objects.
message BackfillNoneStrategy {
}

@ -1,7 +1,7 @@
type: google.api.Service
config_version: 3
name: datastream.googleapis.com
title: DataStream API
title: Datastream API
apis:
- name: google.cloud.datastream.v1alpha1.Datastream
@ -25,7 +25,7 @@ backend:
- selector: 'google.cloud.datastream.v1alpha1.Datastream.*'
deadline: 60.0
- selector: google.cloud.datastream.v1alpha1.Datastream.DiscoverConnectionProfile
deadline: 90.0
deadline: 120.0
- selector: google.cloud.location.Locations.GetLocation
deadline: 60.0
- selector: google.cloud.location.Locations.ListLocations

Loading…
Cancel
Save