`on: [push, pull_request]` has the effect that CI runs twice if I push
to a feature branch in my repo and then make a pull request – once for
the push to the feature branch, and once for the PR.
Instead, only run CI on pushes to the main branch (and on all PRs).
Verified it works now by pushing a commit that adds
print('os name:', os.name, sys.version)
if os.name == 'nt':
tests += [('demumble _Z4funcPci _Z1fv', 'fnc(char*, int)\nf()\n')]
to demumble_test.py on a test branch and checking that CI now
fails on Windows, while it didn't before.
Also, the 'passed' output now shows up.
(Just `python` instead of `python3` also runs Python 3.11 on
all the github action images demumble currently uses, and normally
python is called just `python` on Windows, not `python3`. But
`python3` seems to work on GitHub actions, so let's be explicit
about it.)
This will work on other host OSs. Also, `apt-get update`, while cool,
takes pretty long to run.
(On the downside, this misprints "Received" in the log, and upstream
seems to have stopped acception PRs, ah well.)
Trying to fix:
CMake Warning:
No source or binary directory provided. Both will be assumed to be the
same as the current working directory, but note that this warning will
become a fatal error in future CMake releases.
Nico Weber