data-plane-api

1241 Commits

2 Branches

0 Tags

18 MiB

Tag: Branch: Tree: e5456de4ba

Commit Graph

Author	SHA1	Message	Date
data-plane-api(CircleCI)	abba11d3ee	api/config: use resource type annotations to provide type-to-endpoint. (#9566 ) Previously, type_to_endpoint.cc had a lot of hardcoding, which doesn't scale well with multiple API versions. See https://github.com/envoyproxy/envoy/pull/9526 for an example of the issues encountered. This patch switches to using explicit resource type annotations on service descriptors, which is great for documentation (previously this was sometimes given in comments, sometimes not), and allows for a reflection driven reverse map from resource type URL to endpoints to be built at runtime. Risk level: Low Testing: New unit tests for type_to_endpoint.cc and golden protoxform tests for the new annotations. Fixes #9454. Signed-off-by: Harvey Tuch <htuch@google.com> Mirrored from https://github.com/envoyproxy/envoy @ cceab393664429a3063d787cf28cade3c8ab01c7	5 years ago

Author

SHA1

Message

Date

data-plane-api(CircleCI)

abba11d3ee

api/config: use resource type annotations to provide type-to-endpoint. (#9566 )

Previously, type_to_endpoint.cc had a lot of hardcoding, which doesn't scale well with multiple API
versions. See https://github.com/envoyproxy/envoy/pull/9526 for an example of the issues
encountered.

This patch switches to using explicit resource type annotations on service descriptors, which is
great for documentation (previously this was sometimes given in comments, sometimes not), and allows
for a reflection driven reverse map from resource type URL to endpoints to be built at runtime.

Risk level: Low
Testing: New unit tests for type_to_endpoint.cc and golden protoxform tests for the new annotations.

Fixes #9454.

Signed-off-by: Harvey Tuch <htuch@google.com>

Mirrored from https://github.com/envoyproxy/envoy @ cceab393664429a3063d787cf28cade3c8ab01c7

5 years ago

1 Commits (e5456de4ba40912525f3de05f3cd5ee92aefd9ac)