1) Use Address instead of SocketAddress to account for UDS.
2) Rename/clarify/add both remote/local for downstream/upstream.
Signed-off-by: Matt Klein <mklein@lyft.com>
CertificateValidationContext.trusted_ca is not only for client
certificates, but also for server certs. Change the wording to "peer
certificates".
Also mention that verification is not enabled by default in docs for
UpstreamTlsContext.
Signed-off-by: Peter Schultz <peter.schultz@classmarkets.com>
This patch clarifies the relationship between the CLI flags for local
service configuration and the bootstrap node identifier, where these
concepts are also expressed.
Signed-off-by: Harvey Tuch <htuch@google.com>
These were lost in my backlog. Required a PGV fix for cross-package enum
validation to deal with the TODOs, see
https://github.com/lyft/protoc-gen-validate/issues/42.
Signed-off-by: Harvey Tuch <htuch@google.com>
To resolve https://github.com/envoyproxy/envoy/issues/2155, it seems
better to fix via docs than implementation. This is because we have a
choice of binding 0.0.0.0 or ::, and the current Envoy idiom is to make
the user be explicit rather than probe.
It's possible to use :: for both IPv4/v6, for example, in
certain environments where /proc/sys/net/ipv6/bindv6only is set to 0. We
could add support to Envoy and the API for IPV6_V6ONLY to override this,
but this is orthogonal to the above issue.
Signed-off-by: Harvey Tuch <htuch@google.com>
This comes up a fair bit in discussion with management server
implementers, @ramaraochavali suggested we explain this.
Signed-off-by: Harvey Tuch <htuch@google.com>
Links xDS earlier in API v2 overview. Removes line numbers from github xDS proto links.
Modifies xDS protocol doc to more clearly define xDS at the start.
Signed-off-by: Stephan Zuercher <stephan@turbinelabs.io>
This is code movement only and no other changes. There should be
no namespace changes or effects to consumers.
Signed-off-by: Matt Klein <mklein@lyft.com>
* Added PGV C++ generation support. This (hopefully temporarily)
abandons using native proto_library in favor of pgv_cc_proto_library.
We maintain build support for proto_library for the glorious future in
which we write a Bazel aspect to run PGV against the native
proto_library shadow graph.
* Replace min_len with min_bytes on strings, until PGV gets not-empty or
min_len support for C++.
* Various fixups for places where the PGV plugin objected to
annotations.
Signed-off-by: Harvey Tuch <htuch@google.com>
Matt Klein
Kuat
Jose Ulises Nino Rivera
mandarjog
Peter Schultz
Taiki Ono
Stephan Zuercher
Gabriel Sagula
Lizan Zhou
Greg Greenway
htuch
alyssawilk
Piotr Sikora