From f1fa1f4b3f59e8af591937f0e3ecc1318d387288 Mon Sep 17 00:00:00 2001 From: "data-plane-api(CircleCI)" Date: Fri, 12 Jul 2019 13:14:48 +0000 Subject: [PATCH] api filter http: add build rules for go protobufs (#7526) All http filters have build rules to generate cc protobufs, but not go protobufs. Added build rules (to a few filters) to generate go protobuf files. Emulates the rules in the health_check http filter. Risk Level: Low Testing: These rules were copied to google3 and tested internally. Unfortunately, I am having a bit of trouble with bazel build directly on these targets ("Package is considered deleted due to --deleted_packages"). Please let me know if there is a better way to test this change. Signed-off-by: Teju Nareddy Mirrored from https://github.com/envoyproxy/envoy @ 23d82b9d14a6cf9f49ebcd3ae584fe3079f597d1 --- envoy/config/filter/http/jwt_authn/v2alpha/BUILD | 12 +++++++++++- envoy/config/filter/http/router/v2/BUILD | 8 +++++++- envoy/config/filter/http/transcoder/v2/BUILD | 7 ++++++- 3 files changed, 24 insertions(+), 3 deletions(-) diff --git a/envoy/config/filter/http/jwt_authn/v2alpha/BUILD b/envoy/config/filter/http/jwt_authn/v2alpha/BUILD index d637732d..e48aa582 100644 --- a/envoy/config/filter/http/jwt_authn/v2alpha/BUILD +++ b/envoy/config/filter/http/jwt_authn/v2alpha/BUILD @@ -1,6 +1,6 @@ licenses(["notice"]) # Apache 2 -load("@envoy_api//bazel:api_build_system.bzl", "api_proto_library_internal") +load("@envoy_api//bazel:api_build_system.bzl", "api_go_proto_library", "api_proto_library_internal") api_proto_library_internal( name = "jwt_authn", @@ -11,3 +11,13 @@ api_proto_library_internal( "//envoy/api/v2/route", ], ) + +api_go_proto_library( + name = "jwt_authn", + proto = ":jwt_authn", + deps = [ + "//envoy/api/v2/core:base_go_proto", + "//envoy/api/v2/core:http_uri_go_proto", + "//envoy/api/v2/route:route_go_proto", + ], +) diff --git a/envoy/config/filter/http/router/v2/BUILD b/envoy/config/filter/http/router/v2/BUILD index 990d8154..7a80299a 100644 --- a/envoy/config/filter/http/router/v2/BUILD +++ b/envoy/config/filter/http/router/v2/BUILD @@ -1,4 +1,4 @@ -load("@envoy_api//bazel:api_build_system.bzl", "api_proto_library_internal") +load("@envoy_api//bazel:api_build_system.bzl", "api_go_proto_library", "api_proto_library_internal") licenses(["notice"]) # Apache 2 @@ -7,3 +7,9 @@ api_proto_library_internal( srcs = ["router.proto"], deps = ["//envoy/config/filter/accesslog/v2:accesslog"], ) + +api_go_proto_library( + name = "router", + proto = ":router", + deps = ["//envoy/config/filter/accesslog/v2:accesslog_go_proto"], +) diff --git a/envoy/config/filter/http/transcoder/v2/BUILD b/envoy/config/filter/http/transcoder/v2/BUILD index 8ecd7759..c1a845bc 100644 --- a/envoy/config/filter/http/transcoder/v2/BUILD +++ b/envoy/config/filter/http/transcoder/v2/BUILD @@ -1,4 +1,4 @@ -load("@envoy_api//bazel:api_build_system.bzl", "api_proto_library_internal") +load("@envoy_api//bazel:api_build_system.bzl", "api_go_proto_library", "api_proto_library_internal") licenses(["notice"]) # Apache 2 @@ -6,3 +6,8 @@ api_proto_library_internal( name = "transcoder", srcs = ["transcoder.proto"], ) + +api_go_proto_library( + name = "transcoder", + proto = ":transcoder", +)