From ecc0d1551db2a78827523a04f4c845f8f36ba2d4 Mon Sep 17 00:00:00 2001 From: "data-plane-api(CircleCI)" Date: Thu, 22 Aug 2019 04:15:48 +0000 Subject: [PATCH] api config: add build rules for go protos (#7987) Some BUILD files are missing build rules to generate go protos. envoyproxy/go-control-plane depends on these protos, so they should be exposed publicly. Added build rules to generate *.pb.go files. Risk Level: Low Testing: These rules were copied to google3 and tested internally. Unfortunately, I am having a bit of trouble with bazel build directly on these targets ("Package is considered deleted due to --deleted_packages"). Please let me know if there is a better way to test this change. Signed-off-by: Teju Nareddy Mirrored from https://github.com/envoyproxy/envoy @ c7110f8d10d928a3b18ee6a05439d7b4e49e595c --- envoy/config/accesslog/v2/BUILD | 8 +++++++- envoy/config/filter/network/tcp_proxy/v2/BUILD | 12 +++++++++++- 2 files changed, 18 insertions(+), 2 deletions(-) diff --git a/envoy/config/accesslog/v2/BUILD b/envoy/config/accesslog/v2/BUILD index d6fd2d35..85ac228c 100644 --- a/envoy/config/accesslog/v2/BUILD +++ b/envoy/config/accesslog/v2/BUILD @@ -1,4 +1,4 @@ -load("@envoy_api//bazel:api_build_system.bzl", "api_proto_library_internal") +load("@envoy_api//bazel:api_build_system.bzl", "api_go_proto_library", "api_proto_library_internal") licenses(["notice"]) # Apache 2 @@ -14,3 +14,9 @@ api_proto_library_internal( name = "file", srcs = ["file.proto"], ) + +api_go_proto_library( + name = "als", + proto = ":als", + deps = ["//envoy/api/v2/core:grpc_service_go_proto"], +) diff --git a/envoy/config/filter/network/tcp_proxy/v2/BUILD b/envoy/config/filter/network/tcp_proxy/v2/BUILD index d77d910a..e75ab703 100644 --- a/envoy/config/filter/network/tcp_proxy/v2/BUILD +++ b/envoy/config/filter/network/tcp_proxy/v2/BUILD @@ -1,4 +1,4 @@ -load("@envoy_api//bazel:api_build_system.bzl", "api_proto_library_internal") +load("@envoy_api//bazel:api_build_system.bzl", "api_go_proto_library", "api_proto_library_internal") licenses(["notice"]) # Apache 2 @@ -11,3 +11,13 @@ api_proto_library_internal( "//envoy/config/filter/accesslog/v2:accesslog", ], ) + +api_go_proto_library( + name = "tcp_proxy", + proto = ":tcp_proxy", + deps = [ + "//envoy/api/v2/core:address_go_proto", + "//envoy/api/v2/core:base_go_proto", + "//envoy/config/filter/accesslog/v2:accesslog_go_proto", + ], +)