lds: empty address implies bind 0.0.0.0/::. (#17)

As discussed offline and in https://github.com/lyft/envoy-api/issues/14.
pull/13/head
htuch 8 years ago committed by GitHub
parent ad1673648d
commit e498071da6
  1. 16
      api/address.proto
  2. 3
      api/lds.proto

@ -1,7 +1,5 @@
syntax = "proto3"; syntax = "proto3";
import "google/protobuf/wrappers.proto";
// [V2-API-DIFF] Addresses now have .proto structure. // [V2-API-DIFF] Addresses now have .proto structure.
message Address { message Address {
message SocketAddress { message SocketAddress {
@ -9,17 +7,19 @@ message Address {
TCP = 0; TCP = 0;
} }
Protocol protocol = 1; Protocol protocol = 1;
// For listeners, bind to 0.0.0.0 or :: to support the use of prefix/suffix // For listeners, an empty address implies a bind to 0.0.0.0 or ::. It's
// matching in FilterChainMatch. For clusters, an address may be either an // still possible to distinguish on address via the prefix/suffix matching
// IP or hostname to be resolved via DNS. // in FilterChainMatch after connection.
google.protobuf.StringValue address = 2; // For clusters, an address may be either an IP or hostname to be resolved via
// DNS.
string address = 2;
oneof port_specifier { oneof port_specifier {
google.protobuf.UInt32Value port = 3; uint32 port = 3;
string service = 4; string service = 4;
} }
} }
message Pipe { message Pipe {
google.protobuf.StringValue path = 1; string path = 1;
} }
oneof address { oneof address {
SocketAddress socket_address = 1; SocketAddress socket_address = 1;

@ -113,6 +113,9 @@ message Listener {
// the listener associated with the original destination port. If there is no // the listener associated with the original destination port. If there is no
// listener associated with the original destination port, the connection is // listener associated with the original destination port, the connection is
// handled by the listener that receives it. Default is false. // handled by the listener that receives it. Default is false.
// TODO(htuch): Clarify how use_original_dst interacts with listeners that
// bind to specific IP addresses, where we want the original destination IP to
// be used in the FilterChainMatch but not on bind.
google.protobuf.BoolValue use_original_dst = 4; google.protobuf.BoolValue use_original_dst = 4;
// Soft limit on size of the listeners new connection read and write buffers. // Soft limit on size of the listeners new connection read and write buffers.

Loading…
Cancel
Save