From df1ba478ace9d48aa0358e7aca76acf67fdc8cdc Mon Sep 17 00:00:00 2001 From: "data-plane-api(CircleCI)" Date: Tue, 1 May 2018 15:38:51 +0000 Subject: [PATCH] add more precise detail for grpc json transcoder doc (#3251) Signed-off-by: Mark Woo Mirrored from https://github.com/envoyproxy/envoy @ a7c01bd71efa438d6193dc220abaad1bfe3db9b4 --- envoy/config/filter/http/transcoder/v2/transcoder.proto | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/envoy/config/filter/http/transcoder/v2/transcoder.proto b/envoy/config/filter/http/transcoder/v2/transcoder.proto index 7a52c9a4..e624f718 100644 --- a/envoy/config/filter/http/transcoder/v2/transcoder.proto +++ b/envoy/config/filter/http/transcoder/v2/transcoder.proto @@ -23,10 +23,11 @@ message GrpcJsonTranscoder { bytes proto_descriptor_bin = 4; } - // A list of strings that supplies the service names that the - // transcoder will translate. If the service name doesn't exist in ``proto_descriptor``, Envoy - // will fail at startup. The ``proto_descriptor`` may contain more services than the service names - // specified here, but they won't be translated. + // A list of strings that + // supplies the fully qualified service names (i.e. "package_name.service_name") that + // the transcoder will translate. If the service name doesn't exist in ``proto_descriptor``, + // Envoy will fail at startup. The ``proto_descriptor`` may contain more services than + // the service names specified here, but they won't be translated. repeated string services = 2 [(validate.rules).repeated .min_items = 1]; message PrintOptions {