External authorization review comments (#491)

Fix up the comments for failure_mode_allow that was incorrectly worded and caught during review envoyproxy/envoy#2416

Signed-off-by: Saurabh Mohan <saurabh+github@tigera.io>
pull/494/head
Saurabh Mohan 7 years ago committed by htuch
parent 258bfddfdd
commit cb26bddf35
  1. 8
      envoy/config/filter/http/ext_authz/v2/ext_authz.proto
  2. 8
      envoy/config/filter/network/ext_authz/v2/ext_authz.proto

@ -9,7 +9,8 @@ import "validate/validate.proto";
// [#not-implemented-hide:]
// External Authorization filter calls out to an external service over the
// gRPC Authorization API defined by :ref:`external_auth <envoy_api_msg_auth.CheckRequest>`.
// gRPC Authorization API defined by
// :ref:`external_auth <envoy_api_msg_auth.CheckRequest>`.
// A failed check will cause this filter to return 403 Forbidden.
message ExtAuthz {
@ -18,9 +19,8 @@ message ExtAuthz {
// The filter's behaviour in case the external authorization service does
// not respond back. If set to true then in case of failure to get a
// response back from the authorization service allow the traffic.
// response back from the authorization service or getting a response that
// is NOT denied then traffic will be permitted.
// Defaults to false.
// If set to true and the response from the authorization service is NOT
// Denied then the traffic will be permitted.
bool failure_mode_allow = 2;
}

@ -9,7 +9,8 @@ import "validate/validate.proto";
// [#not-implemented-hide:]
// External Authorization filter calls out to an external service over the
// gRPC Authorization API defined by :ref:`external_auth <envoy_api_msg_auth.CheckRequest>`.
// gRPC Authorization API defined by
// :ref:`external_auth <envoy_api_msg_auth.CheckRequest>`.
// A failed check will cause this filter to close the TCP connection.
message ExtAuthz {
// The prefix to use when emitting statistics.
@ -20,9 +21,8 @@ message ExtAuthz {
// The filter's behaviour in case the external authorization service does
// not respond back. If set to true then in case of failure to get a
// response back from the authorization service allow the traffic.
// response back from the authorization service or getting a response that
// is NOT denied then traffic will be permitted.
// Defaults to false.
// If set to true and the response from the authorization service is NOT
// Denied then the traffic will be permitted.
bool failure_mode_allow = 3;
}

Loading…
Cancel
Save