outlier_detection: add optional random jitter to ejection time (#19869)

* outlier_detection: add optional random jitter to ejection time

Signed-off-by: asheryer <asheryer@amazon.com>

* Add max_ejection_time_jitter configuration reference to current release notes

Signed-off-by: asheryer <asheryer@amazon.com>

* Change wording in release notes

Signed-off-by: asheryer <asheryer@amazon.com>

* Add clarifying comment to jitter calculation

Signed-off-by: asheryer <asheryer@amazon.com>

* Fix formatting issues

Signed-off-by: asheryer <asheryer@amazon.com>

* Fix more formatting issues

Signed-off-by: asheryer <asheryer@amazon.com>

* Fix parameters in outlier_detection tests

Signed-off-by: asheryer <asheryer@amazon.com>

* Fix format of test functions

Signed-off-by: asheryer <asheryer@amazon.com>

* Fix comment punctuation

Signed-off-by: asheryer <asheryer@amazon.com>

* Fixes based on PR feedback

Signed-off-by: asheryer <asheryer@amazon.com>

* Fix format

Signed-off-by: asheryer <asheryer@amazon.com>

* Empty commit to retrigger CI

Signed-off-by: asheryer <asheryer@amazon.com>

* Fix nits

Signed-off-by: asheryer <asheryer@amazon.com>

* Add configuration tests

Signed-off-by: asheryer <asheryer@amazon.com>

* Add jitter tests

Signed-off-by: asheryer <asheryer@amazon.com>

* Fix comments

Signed-off-by: asheryer <asheryer@amazon.com>

* Update source/common/upstream/outlier_detection_impl.cc

Co-authored-by: Adi (Suissa) Peleg <adip@google.com>

Signed-off-by: asheryer <asheryer@amazon.com>

* Check exact value in jitter test

Signed-off-by: asheryer <asheryer@amazon.com>

* Move to new features

Signed-off-by: asheryer <asheryer@amazon.com>

* Empty commit to trigger CI

Signed-off-by: asheryer <asheryer@amazon.com>

Mirrored from https://github.com/envoyproxy/envoy @ 158535979a833d076c44c701f1cdf5406187d3ba

envoy/config/cluster/v3/outlier_detection.proto

@@ -19,7 +19,7 @@ option (udpa.annotations.file_status).package_version_status = ACTIVE;
 
 // See the :ref:`architecture overview <arch_overview_outlier_detection>` for
 // more information on outlier detection.
-// [#next-free-field: 22]
+// [#next-free-field: 23]
 message OutlierDetection {
   option (udpa.annotations.versioning).previous_message_type =
       "envoy.api.v2.cluster.OutlierDetection";
@@ -155,4 +155,10 @@ message OutlierDetection {
   // for more information. If not specified, the default value (300000ms or 300s) or
   // :ref:`base_ejection_time<envoy_v3_api_field_config.cluster.v3.OutlierDetection.base_ejection_time>` value is applied, whatever is larger.
   google.protobuf.Duration max_ejection_time = 21 [(validate.rules).duration = {gt {}}];
+
+  // The maximum amount of jitter to add to the ejection time, in order to prevent
+  // a 'thundering herd' effect where all proxies try to reconnect to host at the same time.
+  // See :ref:`max_ejection_time_jitter<envoy_v3_api_field_config.cluster.v3.OutlierDetection.base_ejection_time>`
+  // Defaults to 0s.
+  google.protobuf.Duration max_ejection_time_jitter = 22;
 }