regex: don't enforce max_program_size when field isn't present in config. (#11187)

max_program_size was deprecated, but when the field isn't specified, a default max program size of 100 is still enforced. This change makes it such that when the field isn't present, no max program size check is enforced.

Signed-off-by: Lisa Lu <lisalu@lyft.com>

Mirrored from https://github.com/envoyproxy/envoy @ 5330d15b6b37af3d3ff39cd45ec710fbe7dc6d6d

envoy/type/matcher/regex.proto

@@ -19,6 +19,16 @@ message RegexMatcher {
   // Google's `RE2 <https://github.com/google/re2>`_ regex engine. The regex string must adhere to
   // the documented `syntax <https://github.com/google/re2/wiki/Syntax>`_. The engine is designed
   // to complete execution in linear time as well as limit the amount of memory used.
+  //
+  // Envoy supports program size checking via runtime. The runtime keys `re2.max_program_size.error_level`
+  // and `re2.max_program_size.warn_level` can be set to integers as the maximum program size or
+  // complexity that a compiled regex can have before an exception is thrown or a warning is
+  // logged, respectively. `re2.max_program_size.error_level` defaults to 100, and
+  // `re2.max_program_size.warn_level` has no default if unset (will not check/log a warning).
+  //
+  // Envoy emits two stats for tracking the program size of regexes: the histogram `re2.program_size`,
+  // which records the program size, and the counter `re2.exceeded_warn_level`, which is incremented
+  // each time the program size exceeds the warn level threshold.
   message GoogleRE2 {
     // This field controls the RE2 "program size" which is a rough estimate of how complex a
     // compiled regex is to evaluate. A regex that has a program size greater than the configured

envoy/type/matcher/v3/regex.proto

@@ -22,6 +22,16 @@ message RegexMatcher {
   // Google's `RE2 <https://github.com/google/re2>`_ regex engine. The regex string must adhere to
   // the documented `syntax <https://github.com/google/re2/wiki/Syntax>`_. The engine is designed
   // to complete execution in linear time as well as limit the amount of memory used.
+  //
+  // Envoy supports program size checking via runtime. The runtime keys `re2.max_program_size.error_level`
+  // and `re2.max_program_size.warn_level` can be set to integers as the maximum program size or
+  // complexity that a compiled regex can have before an exception is thrown or a warning is
+  // logged, respectively. `re2.max_program_size.error_level` defaults to 100, and
+  // `re2.max_program_size.warn_level` has no default if unset (will not check/log a warning).
+  //
+  // Envoy emits two stats for tracking the program size of regexes: the histogram `re2.program_size`,
+  // which records the program size, and the counter `re2.exceeded_warn_level`, which is incremented
+  // each time the program size exceeds the warn level threshold.
   message GoogleRE2 {
     option (udpa.annotations.versioning).previous_message_type =
         "envoy.type.matcher.RegexMatcher.GoogleRE2";

envoy/type/matcher/v4alpha/regex.proto

@@ -22,6 +22,16 @@ message RegexMatcher {
   // Google's `RE2 <https://github.com/google/re2>`_ regex engine. The regex string must adhere to
   // the documented `syntax <https://github.com/google/re2/wiki/Syntax>`_. The engine is designed
   // to complete execution in linear time as well as limit the amount of memory used.
+  //
+  // Envoy supports program size checking via runtime. The runtime keys `re2.max_program_size.error_level`
+  // and `re2.max_program_size.warn_level` can be set to integers as the maximum program size or
+  // complexity that a compiled regex can have before an exception is thrown or a warning is
+  // logged, respectively. `re2.max_program_size.error_level` defaults to 100, and
+  // `re2.max_program_size.warn_level` has no default if unset (will not check/log a warning).
+  //
+  // Envoy emits two stats for tracking the program size of regexes: the histogram `re2.program_size`,
+  // which records the program size, and the counter `re2.exceeded_warn_level`, which is incremented
+  // each time the program size exceeds the warn level threshold.
   message GoogleRE2 {
     option (udpa.annotations.versioning).previous_message_type =
         "envoy.type.matcher.v3.RegexMatcher.GoogleRE2";