From 9e2cb423b65947eca7c0a4e7a5d4cff763990f52 Mon Sep 17 00:00:00 2001 From: "data-plane-api(Azure Pipelines)" Date: Tue, 9 May 2023 16:16:32 +0000 Subject: [PATCH] api: clarify ranges of LB config parameters (#27192) * api: clarify ranges of LB config parameters Signed-off-by: Yousuk Seung Mirrored from https://github.com/envoyproxy/envoy @ d93958dbef1c2b11587bea6f3eb561bd630b212d --- .../v3/client_side_weighted_round_robin.proto | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/envoy/extensions/load_balancing_policies/client_side_weighted_round_robin/v3/client_side_weighted_round_robin.proto b/envoy/extensions/load_balancing_policies/client_side_weighted_round_robin/v3/client_side_weighted_round_robin.proto index 4af32eb6..ae4a99b4 100644 --- a/envoy/extensions/load_balancing_policies/client_side_weighted_round_robin/v3/client_side_weighted_round_robin.proto +++ b/envoy/extensions/load_balancing_policies/client_side_weighted_round_robin/v3/client_side_weighted_round_robin.proto @@ -6,6 +6,7 @@ import "google/protobuf/duration.proto"; import "google/protobuf/wrappers.proto"; import "udpa/annotations/status.proto"; +import "validate/validate.proto"; option java_package = "io.envoyproxy.envoy.extensions.load_balancing_policies.client_side_weighted_round_robin.v3"; option java_outer_classname = "ClientSideWeightedRoundRobinProto"; @@ -58,10 +59,12 @@ message ClientSideWeightedRoundRobin { // blackout_period applies. Defaults to 3 minutes. google.protobuf.Duration weight_expiration_period = 4; - // How often endpoint weights are recalculated. Default is 1 second. + // How often endpoint weights are recalculated. Values less than 100ms are + // capped at 100ms. Default is 1 second. google.protobuf.Duration weight_update_period = 5; // The multiplier used to adjust endpoint weights with the error rate - // calculated as eps/qps. Default is 1.0. - google.protobuf.FloatValue error_utilization_penalty = 6; + // calculated as eps/qps. Configuration is rejected if this value is negative. + // Default is 1.0. + google.protobuf.FloatValue error_utilization_penalty = 6 [(validate.rules).float = {gte: 0.0}]; }