event: reintroduce dispatcher stats (#6659)

Reintroduce dispatcher stats previously reverted in #6649. Dispatcher stats are now gated on a new bootstrap config parameter, enable_dispatcher_stats, and disabled by default.

Risk Level: Low
Testing: Manually verified that config is respected (see #6582, this still requires integration tests).
Docs Changes: Included a note about how statsd doesn't play well with these high-volume histograms.

Signed-off-by: Dan Rosen <mergeconflict@google.com>

Mirrored from https://github.com/envoyproxy/envoy @ 481a127f5ade32e5590b4e8b8271576e44643082
pull/620/head
data-plane-api(CircleCI) 6 years ago
parent 59afd49a7a
commit 9c735715f5
  1. 8
      envoy/config/bootstrap/v2/bootstrap.proto

@ -118,6 +118,14 @@ message Bootstrap {
// Optional overload manager configuration.
envoy.config.overload.v2alpha.OverloadManager overload_manager = 15;
// Enable :ref:`stats for event dispatcher <operations_performance>`, defaults to false.
// Note that this records a value for each iteration of the event loop on every thread. This
// should normally be minimal overhead, but when using
// :ref:`statsd <envoy_api_msg_config.metrics.v2.StatsdSink>`, it will send each observed value
// over the wire individually because the statsd protocol doesn't have any way to represent a
// histogram summary. Be aware that this can be a very large volume of data.
bool enable_dispatcher_stats = 16;
}
// Administration interface :ref:`operations documentation

Loading…
Cancel
Save