From 90439ad743b6ee71bd2910f230f6e1be0094763f Mon Sep 17 00:00:00 2001 From: "data-plane-api(CircleCI)" Date: Tue, 8 Jan 2019 20:12:07 +0000 Subject: [PATCH] config: removing the legacy rest API (#5522) Risk Level: Medium (still unclear who might be using it) Testing: n/a Docs Changes: v1 docs already removed Release Notes: inline Fixes #5378 Signed-off-by: Alyssa Wilk Mirrored from https://github.com/envoyproxy/envoy @ 47dbc4f506274ad7dac9226fd947c01b9d243923 --- envoy/api/v2/core/config_source.proto | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/envoy/api/v2/core/config_source.proto b/envoy/api/v2/core/config_source.proto index 56eb2379..01194eb7 100644 --- a/envoy/api/v2/core/config_source.proto +++ b/envoy/api/v2/core/config_source.proto @@ -21,8 +21,9 @@ option (gogoproto.equal_all) = true; message ApiConfigSource { // APIs may be fetched via either REST or gRPC. enum ApiType { - // REST-JSON legacy corresponds to the v1 API. - REST_LEGACY = 0 [deprecated = true]; + // Ideally this would be 'reserved 0' but one can't reserve the default + // value. Instead we throw an exception if this is ever used. + UNSUPPORTED_REST_LEGACY = 0 [deprecated = true]; // REST-JSON v2 API. The `canonical JSON encoding // `_ for // the v2 protos is used. @@ -31,7 +32,7 @@ message ApiConfigSource { GRPC = 2; } ApiType api_type = 1 [(validate.rules).enum.defined_only = true]; - // Cluster names should be used only with REST_LEGACY/REST. If > 1 + // Cluster names should be used only with REST. If > 1 // cluster is defined, clusters will be cycled through if any kind of failure // occurs. //