From 74241fcf82d38b0ff4d0b13d2efcd0fe887cb50f Mon Sep 17 00:00:00 2001 From: "data-plane-api(CircleCI)" Date: Wed, 22 Apr 2020 16:58:57 +0000 Subject: [PATCH] api/faq: add entry on incremental xDS. (#10876) Also remove some stale comments around delta xDS in ConfigSource. Fixes #10836 Signed-off-by: Harvey Tuch Mirrored from https://github.com/envoyproxy/envoy @ 4ee310ec07a4e0e775626fe8c652726b4151b8e9 --- envoy/api/v2/core/config_source.proto | 4 ---- envoy/config/core/v3/config_source.proto | 4 ---- envoy/config/core/v4alpha/config_source.proto | 4 ---- 3 files changed, 12 deletions(-) diff --git a/envoy/api/v2/core/config_source.proto b/envoy/api/v2/core/config_source.proto index fa42a7ae..8bbb961c 100644 --- a/envoy/api/v2/core/config_source.proto +++ b/envoy/api/v2/core/config_source.proto @@ -57,10 +57,6 @@ message ApiConfigSource { // Using the delta xDS gRPC service, i.e. DeltaDiscovery{Request,Response} // rather than Discovery{Request,Response}. Rather than sending Envoy the entire state // with every update, the xDS server only sends what has changed since the last update. - // - // DELTA_GRPC is not yet entirely implemented! Initially, only CDS is available. - // Do not use for other xDSes. - // [#comment:TODO(fredlas) update/remove this warning when appropriate.] DELTA_GRPC = 3; } diff --git a/envoy/config/core/v3/config_source.proto b/envoy/config/core/v3/config_source.proto index b56e06e6..7337403b 100644 --- a/envoy/config/core/v3/config_source.proto +++ b/envoy/config/core/v3/config_source.proto @@ -58,10 +58,6 @@ message ApiConfigSource { // Using the delta xDS gRPC service, i.e. DeltaDiscovery{Request,Response} // rather than Discovery{Request,Response}. Rather than sending Envoy the entire state // with every update, the xDS server only sends what has changed since the last update. - // - // DELTA_GRPC is not yet entirely implemented! Initially, only CDS is available. - // Do not use for other xDSes. - // [#comment:TODO(fredlas) update/remove this warning when appropriate.] DELTA_GRPC = 3; } diff --git a/envoy/config/core/v4alpha/config_source.proto b/envoy/config/core/v4alpha/config_source.proto index be600bd0..253a576a 100644 --- a/envoy/config/core/v4alpha/config_source.proto +++ b/envoy/config/core/v4alpha/config_source.proto @@ -59,10 +59,6 @@ message ApiConfigSource { // Using the delta xDS gRPC service, i.e. DeltaDiscovery{Request,Response} // rather than Discovery{Request,Response}. Rather than sending Envoy the entire state // with every update, the xDS server only sends what has changed since the last update. - // - // DELTA_GRPC is not yet entirely implemented! Initially, only CDS is available. - // Do not use for other xDSes. - // [#comment:TODO(fredlas) update/remove this warning when appropriate.] DELTA_GRPC = 3; }