From 6290b71f73024a7e19cfee499b13c1e851793b2b Mon Sep 17 00:00:00 2001 From: "data-plane-api(Azure Pipelines)" Date: Fri, 25 Mar 2022 15:03:27 +0000 Subject: [PATCH] thrift: deprecate twitter/finagle protocol (#20471) This begins the deprecation process for TTwitter. Fixes #20466. Signed-off-by: Raul Gutierrez Segales Mirrored from https://github.com/envoyproxy/envoy @ 9e67f1e2461e965c0269c69356d608e39c23902b --- envoy/extensions/filters/network/thrift_proxy/v3/BUILD | 1 + .../filters/network/thrift_proxy/v3/thrift_proxy.proto | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/envoy/extensions/filters/network/thrift_proxy/v3/BUILD b/envoy/extensions/filters/network/thrift_proxy/v3/BUILD index 6eb33fe8..64353a11 100644 --- a/envoy/extensions/filters/network/thrift_proxy/v3/BUILD +++ b/envoy/extensions/filters/network/thrift_proxy/v3/BUILD @@ -6,6 +6,7 @@ licenses(["notice"]) # Apache 2 api_proto_package( deps = [ + "//envoy/annotations:pkg", "//envoy/config/core/v3:pkg", "//envoy/config/route/v3:pkg", "@com_github_cncf_udpa//udpa/annotations:pkg", diff --git a/envoy/extensions/filters/network/thrift_proxy/v3/thrift_proxy.proto b/envoy/extensions/filters/network/thrift_proxy/v3/thrift_proxy.proto index a9a991d6..ae9befdf 100644 --- a/envoy/extensions/filters/network/thrift_proxy/v3/thrift_proxy.proto +++ b/envoy/extensions/filters/network/thrift_proxy/v3/thrift_proxy.proto @@ -8,6 +8,7 @@ import "envoy/extensions/filters/network/thrift_proxy/v3/route.proto"; import "google/protobuf/any.proto"; import "google/protobuf/wrappers.proto"; +import "envoy/annotations/deprecation.proto"; import "udpa/annotations/migrate.proto"; import "udpa/annotations/status.proto"; import "udpa/annotations/versioning.proto"; @@ -58,7 +59,7 @@ enum ProtocolType { COMPACT = 3; // The Thrift proxy will use the Thrift "Twitter" protocol implemented by the finagle library. - TWITTER = 4; + TWITTER = 4 [deprecated = true, (envoy.annotations.deprecated_at_minor_version_enum) = "3.0"]; } message Trds {