From 5e627017921e1177afa33db428e9d32bc0b2b6a2 Mon Sep 17 00:00:00 2001 From: "data-plane-api(CircleCI)" Date: Thu, 7 Feb 2019 00:13:35 +0000 Subject: [PATCH] maglev: fix handling of unspecified locality weights. (#5863) The config fuzzer showed that the locality weight assertion in https://github.com/envoyproxy/envoy/pull/5831 was too strong. Extant behavior was and is that if locality weight is not specified and locality LB weighting, we should just ignore the locality. Fixes oss-fuzz issue https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=12923. Risk level: Low Testing: Corpus entry and unit test added. Signed-off-by: Harvey Tuch Mirrored from https://github.com/envoyproxy/envoy @ 5fd128d63810919840917bdf7da2d018edc5e32f --- envoy/api/v2/endpoint/endpoint.proto | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/envoy/api/v2/endpoint/endpoint.proto b/envoy/api/v2/endpoint/endpoint.proto index c458884c..1d5d07f5 100644 --- a/envoy/api/v2/endpoint/endpoint.proto +++ b/envoy/api/v2/endpoint/endpoint.proto @@ -111,8 +111,8 @@ message LocalityLbEndpoints { // Locality weights are only considered when :ref:`locality weighted load // balancing ` is // configured. These weights are ignored otherwise. If no weights are - // specified when locality weighted load balancing is enabled, the cluster is - // assumed to have a weight of 1. + // specified when locality weighted load balancing is enabled, the locality is + // assigned no load. // // .. attention:: //