From 48d873c019f577452d33fd686c934827dc055a21 Mon Sep 17 00:00:00 2001 From: "data-plane-api(CircleCI)" Date: Fri, 9 Aug 2019 23:12:47 +0000 Subject: [PATCH] listener: add an option to continue on listener filters timeout (#7859) Description: Add an option to continue on listener filters timeout. Risk Level: Med (mostly guarded by config) Testing: unittest Docs Changes: Added Release Notes: Added Fixes #7195 Signed-off-by: Lizan Zhou Mirrored from https://github.com/envoyproxy/envoy @ 975c62dd2258fe23c3d8098b99261fffd43da736 --- envoy/api/v2/lds.proto | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/envoy/api/v2/lds.proto b/envoy/api/v2/lds.proto index dd29659c..19540134 100644 --- a/envoy/api/v2/lds.proto +++ b/envoy/api/v2/lds.proto @@ -44,7 +44,7 @@ service ListenerDiscoveryService { } } -// [#comment:next free field: 17] +// [#comment:next free field: 18] message Listener { // The unique name by which this listener is known. If no name is provided, // Envoy will allocate an internal UUID for the listener. If the listener is to be dynamically @@ -132,10 +132,20 @@ message Listener { repeated listener.ListenerFilter listener_filters = 9; // The timeout to wait for all listener filters to complete operation. If the timeout is reached, - // the accepted socket is closed without a connection being created. Specify 0 to disable the + // the accepted socket is closed without a connection being created unless + // `continue_on_listener_filters_timeout` is set to true. Specify 0 to disable the // timeout. If not specified, a default timeout of 15s is used. google.protobuf.Duration listener_filters_timeout = 15 [(gogoproto.stdduration) = true]; + // Whether a connection should be created when listener filters timeout. Default is false. + // + // .. attention:: + // + // Some listener filters, such as :ref:`Proxy Protocol filter + // `, should not be used with this option. It will cause + // unexpected behavior when a connection is created. + bool continue_on_listener_filters_timeout = 17; + // Whether the listener should be set as a transparent socket. // When this flag is set to true, connections can be redirected to the listener using an // *iptables* *TPROXY* target, in which case the original source and destination addresses and