ext_proc: Clean up errors in configuration proto (#19733)

* Fix comments regarding what is and isn't implemented.
* Indicate that "stat_prefix" really is implemented, because it is.
* Re-name two misnamed (but as yet unimplemented) fields in per-route
configuration.

Risk Level: Low
Testing: Existing integration and unit tests
Docs Changes:
Release Notes:
Platform Specific Features:

Signed-off-by: Gregory Brail <gregbrail@google.com>

Mirrored from https://github.com/envoyproxy/envoy @ c1f3f51156fe6c56216ec10be9e04af8f4a157b6
pull/626/head
data-plane-api(Azure Pipelines) 3 years ago
parent 477d5f5d50
commit 3ae648a335
  1. 13
      envoy/extensions/filters/http/ext_proc/v3/ext_proc.proto

@ -31,7 +31,7 @@ option (xds.annotations.v3.file_status).work_in_progress = true;
//
// * Request and response attributes are not sent and not processed.
// * Dynamic metadata in responses from the external processor is ignored.
// * "async mode" is not implemented
// * "async mode" is not implemented.
// The filter communicates with an external gRPC service called an "external processor"
// that can do a variety of things with the request and response:
@ -147,7 +147,6 @@ message ExternalProcessor {
// mode. Default is 200 milliseconds.
google.protobuf.Duration message_timeout = 7;
// [#not-implemented-hide:]
// Optional additional prefix to use when emitting statistics. This allows to distinguish
// emitted statistics between configured *ext_proc* filters in an HTTP filter chain.
string stat_prefix = 8;
@ -188,10 +187,12 @@ message ExtProcOverrides {
bool async_mode = 2;
// [#not-implemented-hide:]
// Set different optional properties than the default.
repeated string request_properties = 3;
// Set different optional attributes than the default setting of the
// ``request_attributes`` field.
repeated string request_attributes = 3;
// [#not-implemented-hide:]
// Set different optional properties than the default.
repeated string response_properties = 4;
// Set different optional properties than the default setting of the
// ``response_attributes`` field.
repeated string response_attributes = 4;
}

Loading…
Cancel
Save