From 397797c5301e861e524fe7fafac5ca9c8aa63f26 Mon Sep 17 00:00:00 2001 From: "data-plane-api(CircleCI)" Date: Thu, 16 Jan 2020 20:30:30 +0000 Subject: [PATCH] docs: add note about missing primary cluster (#9704) This is expected behavior, but just lets add a note to RequestMirrorPolicy as a reminder. Fixes #9698 Signed-off-by: Raul Gutierrez Segales Mirrored from https://github.com/envoyproxy/envoy @ 552a42d6cd12fbde790c0f5664a1141e37c160e1 --- envoy/api/v2/route/route_components.proto | 4 ++++ envoy/config/route/v3/route_components.proto | 4 ++++ 2 files changed, 8 insertions(+) diff --git a/envoy/api/v2/route/route_components.proto b/envoy/api/v2/route/route_components.proto index a001eb45..d79dd67d 100644 --- a/envoy/api/v2/route/route_components.proto +++ b/envoy/api/v2/route/route_components.proto @@ -548,6 +548,10 @@ message RouteAction { // // During shadowing, the host/authority header is altered such that *-shadow* is appended. This is // useful for logging. For example, *cluster1* becomes *cluster1-shadow*. + // + // .. note:: + // + // Shadowing will not be triggered if the primary cluster does not exist. message RequestMirrorPolicy { // Specifies the cluster that requests will be mirrored to. The cluster must // exist in the cluster manager configuration. diff --git a/envoy/config/route/v3/route_components.proto b/envoy/config/route/v3/route_components.proto index 856d8cad..26bf3c5d 100644 --- a/envoy/config/route/v3/route_components.proto +++ b/envoy/config/route/v3/route_components.proto @@ -512,6 +512,10 @@ message RouteAction { // // During shadowing, the host/authority header is altered such that *-shadow* is appended. This is // useful for logging. For example, *cluster1* becomes *cluster1-shadow*. + // + // .. note:: + // + // Shadowing will not be triggered if the primary cluster does not exist. message RequestMirrorPolicy { option (udpa.annotations.versioning).previous_message_type = "envoy.api.v2.route.RouteAction.RequestMirrorPolicy";