From 3846fffe24945b75521898f74a326616abd3c483 Mon Sep 17 00:00:00 2001 From: "data-plane-api(Azure Pipelines)" Date: Tue, 18 Jan 2022 17:48:41 +0000 Subject: [PATCH] runtime: envoy.reloadable_features.use_observable_cluster_name removal (#19475) See #15139 ([cluster] Use alt_stat_name for general observability purposes (access log, tracing, admin)), which introduced a runtime guarded feature, which has been enabled by default for 6 months, so remove the old code path. Risk Level: Low Testing: n/a Docs Changes: updated Release Notes: Deprecate envoy.reloadable_features.use_observable_cluster_name. Platform Specific Features: n/a Signed-off-by: Loong Mirrored from https://github.com/envoyproxy/envoy @ 198ae65234223f48cbe2284eb145e16598593963 --- envoy/config/cluster/v3/cluster.proto | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/envoy/config/cluster/v3/cluster.proto b/envoy/config/cluster/v3/cluster.proto index 704cfd33..e98414f8 100644 --- a/envoy/config/cluster/v3/cluster.proto +++ b/envoy/config/cluster/v3/cluster.proto @@ -735,11 +735,9 @@ message Cluster { // emitting stats for the cluster and access logging the cluster name. This will appear as // additional information in configuration dumps of a cluster's current status as // :ref:`observability_name ` - // and as an additional tag "upstream_cluster.name" while tracing. Note: access logging using - // this field is presently enabled with runtime feature - // `envoy.reloadable_features.use_observable_cluster_name`. Any ``:`` in the name will be - // converted to ``_`` when emitting statistics. This should not be confused with :ref:`Router - // Filter Header `. + // and as an additional tag "upstream_cluster.name" while tracing. Note: Any ``:`` in the name + // will be converted to ``_`` when emitting statistics. This should not be confused with + // :ref:`Router Filter Header `. string alt_stat_name = 28 [(udpa.annotations.field_migrate).rename = "observability_name"]; oneof cluster_discovery_type {