dns_filter: fix incorrect validation annotation (#11703)

The upstream resolver list should not be mandatory as it won't allow Envoy to default
to the ambient DNS resolvers to resolve hosts not found in the static dns table.

Risk Level: Low

Signed-off-by: Shriram Rajagopalan <rshriram@tetrate.io>

Mirrored from https://github.com/envoyproxy/envoy @ 1cac626ff5473a53b190f4b3c6c5481850edfdcc
master-ci-test
data-plane-api(CircleCI) 5 years ago
parent 041d39e823
commit 2b18c77d10
  1. 7
      envoy/extensions/filters/udp/dns_filter/v3alpha/dns_filter.proto
  2. 7
      envoy/extensions/filters/udp/dns_filter/v4alpha/dns_filter.proto

@ -51,9 +51,10 @@ message DnsFilterConfig {
// number of retries multiplied by the resolver_timeout.
google.protobuf.Duration resolver_timeout = 1 [(validate.rules).duration = {gte {seconds: 1}}];
// A list of DNS servers to which we can forward queries
repeated config.core.v3.Address upstream_resolvers = 2
[(validate.rules).repeated = {min_items: 1}];
// A list of DNS servers to which we can forward queries. If not
// specified, Envoy will use the ambient DNS resolvers in the
// system.
repeated config.core.v3.Address upstream_resolvers = 2;
// Controls how many outstanding external lookup contexts the filter tracks.
// The context structure allows the filter to respond to every query even if the external

@ -61,9 +61,10 @@ message DnsFilterConfig {
// number of retries multiplied by the resolver_timeout.
google.protobuf.Duration resolver_timeout = 1 [(validate.rules).duration = {gte {seconds: 1}}];
// A list of DNS servers to which we can forward queries
repeated config.core.v4alpha.Address upstream_resolvers = 2
[(validate.rules).repeated = {min_items: 1}];
// A list of DNS servers to which we can forward queries. If not
// specified, Envoy will use the ambient DNS resolvers in the
// system.
repeated config.core.v4alpha.Address upstream_resolvers = 2;
// Controls how many outstanding external lookup contexts the filter tracks.
// The context structure allows the filter to respond to every query even if the external

Loading…
Cancel
Save