lds: eliminate direction from filter config. (#107)

Direction is implied at the C++ type level, putting this in the config
is redundant and can making changes to the C++ implementations difficult
to synchronize between binary and config.

Fixes #63.
pull/110/head
htuch 7 years ago committed by GitHub
parent 4a1411d23e
commit 01acafa412
  1. 15
      api/filter/http_connection_manager.proto
  2. 13
      api/lds.proto

@ -160,24 +160,13 @@ message AccessLog {
} }
message HttpFilter { message HttpFilter {
// The type of filter to instantiate. Most filters implement a specific type,
// though it is theoretically possible for a filter to be written such that it
// can operate in multiple modes. Supported types are decoder, encoder, and
// both.
enum Type {
BOTH = 0;
DECODER = 1;
ENCODER = 2;
}
Type type = 1;
// The name of the filter to instantiate. The name must match a supported // The name of the filter to instantiate. The name must match a supported
// filter. // filter.
string name = 2; string name = 1;
// Filter specific configuration which depends on the filter being // Filter specific configuration which depends on the filter being
// instantiated. See the supported filters for further documentation. // instantiated. See the supported filters for further documentation.
google.protobuf.Struct config = 3; google.protobuf.Struct config = 2;
} }
message HttpConnectionManager { message HttpConnectionManager {

@ -33,21 +33,12 @@ service ListenerDiscoveryService {
} }
message Filter { message Filter {
// The type of filter to instantiate. Most filters implement a specific type,
// though it is theoretically possible for a filter to be written such that it
// can operate in multiple modes. Supported types are read, write, and both.
enum Type {
BOTH = 0;
READ = 1;
WRITE = 2;
}
Type type = 1;
// The name of the filter to instantiate. The name must match a supported // The name of the filter to instantiate. The name must match a supported
// filter. // filter.
string name = 2; string name = 1;
// Filter specific configuration which depends on the filter being // Filter specific configuration which depends on the filter being
// instantiated. See the supported filters for further documentation. // instantiated. See the supported filters for further documentation.
google.protobuf.Struct config = 3; google.protobuf.Struct config = 2;
} }
// Specifies the match criteria for selecting a specific filter chain for a // Specifies the match criteria for selecting a specific filter chain for a

Loading…
Cancel
Save