From 004656ecb6d0c72f0d85a5e5c6ff7a18b312103d Mon Sep 17 00:00:00 2001 From: htuch Date: Mon, 7 Aug 2017 14:51:37 -0400 Subject: [PATCH] base: add cluster to Node and clarify what is required. (#131) Since we expeceted both node name and cluster in v1, it makes sense to continue providing this to management servers. We don't need to use metadata for cluster if it is required. --- api/base.proto | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/api/base.proto b/api/base.proto index b0edd2ad..e7a02e74 100644 --- a/api/base.proto +++ b/api/base.proto @@ -25,12 +25,15 @@ message Locality { // Identifies a specific Envoy instance. Remote server may have per Envoy configuration. message Node { + // An opaque node identifier for the Envoy node. This must be set. string id = 1; - google.protobuf.Struct metadata = 2; - Locality locality = 3; + // The cluster that the Envoy node belongs to. This must be set. + string cluster = 2; + google.protobuf.Struct metadata = 3; + Locality locality = 4; // This is motivated by informing a management server during canary which // version of Envoy is being tested in a heterogeneous fleet. - string build_version = 4; + string build_version = 5; } message Endpoint {