c-ares

174 Commits

14 Branches

96 Tags

22 MiB

Tag: Branch: Tree: f6ddd08e69

Commit Graph

Author	SHA1	Message	Date
Kai Pastor	0e678f2fb2	CMake: Guard target creation in exported config (#464 ) User projects may call 'find_package(c-ares)' multiple times (e.g. via dependencies), but targets must be created only once. Shared and static target must be treated independently. Fix By: Kai Pastor (@dg0yt)	3 years ago
Fionn Fitzmaurice	6d6cd5daf6	Avoid buffer overflow in RC4 loop comparison (#336 ) The rc4 function iterates over a buffer of size buffer_len who's maximum value is INT_MAX with a counter of type short that is not guaranteed to have maximum size INT_MAX. In circumstances where short is narrower than int and where buffer_len is larger than the maximum value of a short, it may be possible to loop infinitely as counter will overflow and never be greater than or equal to buffer_len. The solution is to make the comparison be between types of equal width. This commit defines counter as an int. Fix By: Fionn Fitzmaurice (@fionn)	4 years ago

Author

SHA1

Message

Date

Kai Pastor

0e678f2fb2

CMake: Guard target creation in exported config (#464 )

User projects may call 'find_package(c-ares)' multiple times (e.g.
via dependencies), but targets must be created only once.
Shared and static target must be treated independently.

Fix By: Kai Pastor (@dg0yt)

3 years ago

Fionn Fitzmaurice

6d6cd5daf6

Avoid buffer overflow in RC4 loop comparison (#336 )

The rc4 function iterates over a buffer of size buffer_len who's maximum
value is INT_MAX with a counter of type short that is not guaranteed to
have maximum size INT_MAX.

In circumstances where short is narrower than int and where buffer_len
is larger than the maximum value of a short, it may be possible to loop
infinitely as counter will overflow and never be greater than or equal
to buffer_len.

The solution is to make the comparison be between types of equal width.
This commit defines counter as an int.

Fix By: Fionn Fitzmaurice (@fionn)

4 years ago

2 Commits (f6ddd08e69fbfc890fb4bdc76b35c52436e14633)