c-ares

Commit Graph

Author	SHA1	Message	Date
Brad House	00f7cf6d25	fix test case regression due to missing parens	1 year ago
Brad House	5262da7e88	now that warnings are enabled on test cases, clear a bunch of warnings	1 year ago
Brad House	ecf7a7f166	fix additional windows test warnings	1 year ago
Brad House	5c1a5d8050	cleanup some Windows warnings in test	1 year ago
Brad House	7dc3d98fba	Modernization: replace multiple hand-parsers with new memory-safe parser (#581 ) New DNS record parsing code. The old code was basically just some helper macros and functions for parsing an entire DNS message. The caller had to know the RFCs to use the parsers, except for some pre-made exceptions. The new parsing code parses the entire DNS message into an opaque data structure in a memory safe manner with various accessors for reading and manipulating the data. The existing parser helpers for the various record types were reimplemented as wrappers around the new parser. The accessors allow easy iteration across the DNS record datastructure, and can be used to easily create dig-like output without needing to know anything about the various record types and formats as dynamic helpers are provided for enumeration of values and data types of those values. At some point in the future, this new DNS record structure, accessors, and parser will be exposed publicly. This is not done at this point as we don't want to do that until the API is completely stable. Likely a write() function to output the DNS record back into an actual message buffer will be introduced with the stable API as well. Some subtle bugs in the existing code were uncovered, some which had test cases which turned out to be bogus. Validation with third-party implementations (e.g. BIND9) were performed to validate such cases were indeed bugs. Adding additional RR parsers such as for TLSA (#470) or SVCB/HTTPS (#566) are trivial now since focus can be put on only parsing the data within the RR, not the entire message. That said, as the new parser is not yet public, it isn't clear the best way to expose any new RRs (probably best to wait for the new parser to be public rather than hacking in another legacy function). Some additional RRs that are part of DNS RFC1035 or EDNS RFC6891 that didn't have previously implemented parsers are now also implemented (e.g. HINFO, OPT). Any unrecognized RRs are encapsulated into a "RAW_RR" as binary data which can be inserted or extracted, but are otherwise not interpreted in any way. Fix By: Brad House (@bradh352)	1 year ago
Daniel Stenberg	c1b00c41a7	provide SPDX identifiers and a REUSE CI job to verify All files have their licence and copyright information clearly identifiable. If not in the file header, they are set separately in .reuse/dep5. All used license texts are provided in LICENSES/	2 years ago
Tim Wojtulewicz	66d0c013fa	Replace uses of sprintf with snprintf (#525 ) sprintf isn't safe even if you think you are using it right. Switch to snprintf(). Fix By: Tim Wojtulewicz (@timwoj)	2 years ago
Martin Holeš	9ac7efc382	Add support for URI(Uniform Resource Identifier) records. (#411 ) Add ares_parse_uri_reply() for parsing URI DNS replies. Fix By: Martin Holeš (@martin-256)	3 years ago
bradh352	f4c079d9d0	more portability updates	4 years ago
bradh352	86dd24909e	more portability updates	4 years ago
bradh352	498ce747d3	portability updates for test cases	4 years ago
bradh352	c2f32353e3	Portability Updates for arpa/nameser.h (#388 ) There is too much inconsistency between platforms for arpa/nameser.h and arpa/nameser_compat.h for the way the current files are structured. Still load the respective system files but make our private nameser.h more forgiving. Fixes: #388 Fix By: Brad House (@bradh352)	4 years ago
Fionn Fitzmaurice	6d6cd5daf6	Avoid buffer overflow in RC4 loop comparison (#336 ) The rc4 function iterates over a buffer of size buffer_len who's maximum value is INT_MAX with a counter of type short that is not guaranteed to have maximum size INT_MAX. In circumstances where short is narrower than int and where buffer_len is larger than the maximum value of a short, it may be possible to loop infinitely as counter will overflow and never be greater than or equal to buffer_len. The solution is to make the comparison be between types of equal width. This commit defines counter as an int. Fix By: Fionn Fitzmaurice (@fionn)	5 years ago

13 Commits (f1bf69c2d71a7e426ee967847173200a3ef1705a)