c-ares

Commit Graph

Author	SHA1	Message	Date
Brad House	ac33bdc7c2	Refactor connection handling (#839 ) Refactor some connection handling to reduce code duplication and to unify the TCP and UDP codepaths a bit more. This will make some future changes easier to make. This also does some structure renaming to better conform with current standards: - `struct server_state` -> `ares_server_t` - `struct server_connection` -> `ares_conn_t` - `struct query` -> `ares_query_t` Authored-by: Brad House (@bradh352)	4 months ago
Brad House	2f9805fb61	README.md DNS Cookies are done, no longer in progress	4 months ago
Brad House	a1fe471796	fix double-free in ares_dns_rr_set_opt{_own}() recently introduced When implementing ares_dns_rr_del_opt_byid() for DNS cookie support, memory wasn't being zero'd out after removing an option, and when ares_dns_rr_set_opt{_own}() was called, it would try to free the address that still existed. Add a couple memset()'s to prevent this issue. Fixes #836 Fix By: Brad House (@bradh352)	4 months ago
Brad House	d90ce411b3	Reorganize more files into subdirectories (#834 ) More on the reorg effort for easier hacking on the source. Fix By: Brad House (@bradh352)	4 months ago
Brad House	c9c235761f	server cookie wasn't being passed back due to missing length During the implementation of server cookies, test cases were missing to validate the server cookie in a prior reply was passed back, and it turns out they were not. This also adds tests for verification. Fix By: Brad House (@bradh352)	4 months ago
Brad House	2614afc553	SonarCloud: fix warning about memcmp() on padded structure	4 months ago
Brad House	4bedfd0d55	Add DNS cookie support (RFC7873 + RFC9018) (#833 ) DNS cookies are a simple form of learned mutual authentication supported by most DNS server implementations these days and can help prevent DNS Cache Poisoning attacks for clients and DNS amplification attacks for servers. Fixes #620 Fix By: Brad House (@bradh352)	4 months ago
Brad House	d4282d7665	`ares_destroy()` race condition during shutdown due to missing lock (#831 ) When using EventThreads, the config change cleanup code might manipulate the event update list if it uses file descriptors (such as on Linux). This was being done without a lock. Rework the event enqueuing to handle locking internally to prevent this and to simplify where it is used. This was found by chance during an ASAN CI run. Fix By: Brad House (@bradh352)	4 months ago
Brad House	b827cdc52e	fix build failure in tests	4 months ago
Brad House	9db6f9dde8	tests: Disable LotsOfConnections test Disable a test meant for Windows event load testing. Its not meant to be something for general testing. Fix By: Brad House (@bradh352)	4 months ago
Brad House	8d77e2832e	CI: Make Msys2 builds act more like unix builds (#830 ) Fix By: Brad House (@bradh352)	4 months ago
Brad House	5c555b7c0b	clang-format	4 months ago
Brad House	341b34d140	tests: reduce required testing time for ServerFailoverOpts on most platforms	4 months ago
Brad House	5a67f7fe2d	CI: Migrate latest linux testing from Cirrus-CI to GitHub Actions (#828 ) Cirrus CI compute credits run out too fast. Lets migrate more tasks to GitHub Actions. Fix By: Brad House (@bradh352)	4 months ago
Brad House	ea0a188145	reorg: move ares__timeval.c to util	4 months ago
Brad House	0df626b829	release procedure: make commands cut and paste-able as a whole	4 months ago
Brad House	2cc44777b3	release-1.32.3 (#826 )	4 months ago
Brad House	2b80c0f7d9	msvc Makefiles: Remove support for MSVC 6 and 7 since we can't target legacy Windows versions supported by those compilers anymore	4 months ago
Brad House	f691523042	man: ares_dns_record_set_id() Add missing manpage Fixes #817 Fix By: Brad House (@bradh352)	4 months ago
Brad House	7122aec68a	CI: fix coverage build	4 months ago
Brad House	e84c7d1f61	test: bypass BadLoopbackServerNoTimeouts strict validation on NetBSD	4 months ago
Brad House	1dea1145f7	CI: BSD needs to symlink bash location	4 months ago
Brad House	c3e4c1a83d	CI: install bash on *BSD	4 months ago
Brad House	6ddc193281	alpine install bash	4 months ago
Brad House	721d255962	CI: don't use PWD variable name	4 months ago
Brad House	334272c10e	test: restore path	4 months ago
Brad House	b622f61bb5	Test: test.sh should use bash	4 months ago
Brad House	072972aec1	CI: MacOS: move to GitHub Actions instead of Cirrus-CI (#825 ) We've been using a lot of time on Cirrus-CI and our credits run out quickly. MacOS costs 15 compute credits vs 3 compute credits for Linux. Move MacOS testing to GitHub Actions. Fix By: Brad House (@bradh352)	4 months ago
Brad House	8a53099184	test: ServerFailoverOpts can fail on heavily loaded systems due to its reliance on sleep and time. Try to harden it a little bit	4 months ago
Brad House	ad12e89a24	tests: set library path for autotools	4 months ago
Brad House	48f8628738	fix autotools debugger tests	4 months ago
Brad House	cdd942640a	CI: remove deprecated coverage methodology	4 months ago
Brad House	2a65901744	CMake MSVC Parallelizm issue: Don't build adig and ahost simultaneously Make ahost a dependency of adig to prevent issues with them both referencing ares_strcasecmp.c and ares_getopt.c. This appears to be a bug in the Cmake generator for MSVC project files. Fixes #796 Fix By: Brad House (@bradh352)	4 months ago
Brad House	5f855b89f1	coveralls: attempt to enable ipv6 testing	4 months ago
Brad House	6936e672f9	mem leak due to `ares__hosts_entry_to_hostent()` allocation strategy (#824 ) `ares__hosts_entry_to_hostent()` would allocate a separate buffer for each address, but `ares_free_hostent()` expects a single allocation to hold all addresses. This PR fixes this issue and simplifies the logic by using the already-existing `ares__addrinfo2hostent()` to write the hostent instead of coming up with yet another way to write the structure. Fixes #823 Fix By: Brad House (@bradh352)	4 months ago
Brad House	130fd4794b	Reorganize source tree (#822 ) c-ares is getting larger these days and we keep adding source files to the same directory so it can be hard to differentiate core c-ares implementation from library/utility functions. Lets make some subdirectories to help with that and shuffle files around. Fix By: Brad House (@bradh352)	4 months ago
Brad House	58ae7e809a	remove unused test option	4 months ago
Brad House	a548eabbe6	UDP write may fail indicating host isn't reachable (#821 ) UDP is connectionless, but systems use ICMP unreachable messages to indicate there is no ability to reach the host or port, which can result in a `send()` returning an error like `ECONNREFUSED`. We need to handle non-retryable codes like that to treat it as a connection failure so we requeue any queries on that connection to another connection/server immediately. Otherwise what happens is we just wait on the timeout to expire which can greatly increase the time required to get a definitive message. This also adds a test case to verify the behavior. Fixes #819 Fix By: Brad Houes (@bradh352)	4 months ago
Brad House	529906d1cc	Prevent complex recursion during query requeing and connection cleanup c-ares utilizes recursion for some operations, and some of these processes can have unintended side effects, such as if a callback is called that then recurses into the same function. This can cause strange cleanup conditions that lead to crashes. Try to disassociate queries with connections as early as possible and move cleaning up unneeded connections to its own scan rather than trying to detect each time a query is disassociated from a connection. Fix By: Brad House (@bradh352)	4 months ago
Brad House	897e75e24a	CI Solaris: add note as to why we can't run through a debugger	4 months ago
Brad House	a588812a3a	propagate actual error condition on requeue	4 months ago
Brad House	1dcc170a81	Issue #819 : preliminary test case	4 months ago
Brad House	45801911a0	Event Select: need to monitor for socket exceptions too	4 months ago
Brad House	44f0cc7457	prevent SIGPIPE from being generated	4 months ago
Brad House	2bd73c9a7d	CI: ability to run tests through debugger and print backtrace if there is a crash	4 months ago
Brad House	f68992a159	Propagate record duplication error code (#820 ) In c-ares 1.30.0 we started validating strings parsed are printable. This caused a regression in a pycares test case due to a wrong response code being returned as the error was being propagated from a different section of code that was assuming the only possible failure condition was out-of-memory. This PR adds a fix for this and also a test case to validate it. Ref: https://github.com/saghul/pycares/issues/200 Fix By: Brad House (@bradh352)	4 months ago
Gregor Jasny	a6fc828b47	Fix typo reported by Lintian (#816 ) Fix By: Gregor Jasny (@gjasny)	4 months ago
Brad House	cd5664d15d	use _XOPEN_SOURCE=600 for Solaris	4 months ago
Brad House	bf7c946b76	clang static analyzer: silence warning	4 months ago
Brad House	9873be4cdb	Solaris: turn of verbosity	4 months ago

1 2 3 4 5 ...

743 Commits (ac33bdc7c2e36e1906c26e9ce91c68d5a2e3c053) All Branches Search

743 Commits (ac33bdc7c2e36e1906c26e9ce91c68d5a2e3c053)

All Branches