c-ares

11 Commits

14 Branches

97 Tags

23 MiB

Tag: Branch: Tree: abe1ff1ff3

Commit Graph

Author	SHA1	Message	Date
Brad House	abe1ff1ff3	remove CURLDEBUG as per #82	5 years ago
Brad House	2c32de2aa3	Ensure c89 support A couple of for loops in Mac-specific code were using integer declarations inside a for loop. Move the declaration to the top of the preceding code block to retain c89 compliance. Reported By: Jeffrey Walton	5 years ago
Fionn Fitzmaurice	6d6cd5daf6	Avoid buffer overflow in RC4 loop comparison (#336 ) The rc4 function iterates over a buffer of size buffer_len who's maximum value is INT_MAX with a counter of type short that is not guaranteed to have maximum size INT_MAX. In circumstances where short is narrower than int and where buffer_len is larger than the maximum value of a short, it may be possible to loop infinitely as counter will overflow and never be greater than or equal to buffer_len. The solution is to make the comparison be between types of equal width. This commit defines counter as an int. Fix By: Fionn Fitzmaurice (@fionn)	5 years ago

Author

SHA1

Message

Date

Brad House

abe1ff1ff3

remove CURLDEBUG as per #82

5 years ago

Brad House

2c32de2aa3

Ensure c89 support

A couple of for loops in Mac-specific code were using integer declarations
inside a for loop.  Move the declaration to the top of the preceding
code block to retain c89 compliance.

Reported By: Jeffrey Walton

5 years ago

Fionn Fitzmaurice

6d6cd5daf6

Avoid buffer overflow in RC4 loop comparison (#336 )

The rc4 function iterates over a buffer of size buffer_len who's maximum
value is INT_MAX with a counter of type short that is not guaranteed to
have maximum size INT_MAX.

In circumstances where short is narrower than int and where buffer_len
is larger than the maximum value of a short, it may be possible to loop
infinitely as counter will overflow and never be greater than or equal
to buffer_len.

The solution is to make the comparison be between types of equal width.
This commit defines counter as an int.

Fix By: Fionn Fitzmaurice (@fionn)

5 years ago

3 Commits (abe1ff1ff379e38629d57d7ef7221d4c770ad1b8)