c-ares

Commit Graph

Author	SHA1	Message	Date
Brad House	a18a6ad3a1	windows crash: during shutdown the IOCP wake signal handle is cleaned up but there might still be a pending event that gets delivered. Make sure we don't try to access the pointer in this situation.	4 months ago
Brad House	6a1e098917	properly honor channel->maxtimeout	4 months ago
Brad House	b1e7cd91cd	release-1.32.2 (#812 )	4 months ago
Brad House	273fa1c3d8	ares_destroy() deadlock during cleanup of config change monitoring if a configuration change comes in during shutdown	4 months ago
Brad House	afb8548068	win32: ip address change notification passed bad pointer. Regression from 1.30.0	4 months ago
Brad House	b19c186ce7	Rework WinAFD event code (#811 ) We've had reports of user-after-free type crashes in Windows cleanup code for the Event Thread. In evaluating the code, it appeared there were some memory leaks on per-connection handles that may have remained open during shutdown, while trying to resolve that it became apparent the methodology chosen may not have been the right one for interfacing with the Windows AFD system as stability issues were seen during this debugging process. Since this system is completely undocumented, there was no clear resolution path other than to switch to the other methodology which involves directly opening `\Device\Afd`, rather than spawning a "peer socket" to use to queue AFD operations. The original methodology chosen more closely resembled what is employed by [libuv](https://github.com/libuv/libuv) and given its widespread use was the reason it was used. The new methodology more closely resembles [wepoll](https://github.com/piscisaureus/wepoll). Its not clear if there are any scalability or performance advantages or disadvantages for either method. They both seem like different ways to do the same thing, but this current way does seem more stable. Fixes #798 Fix By: Brad House (@bradh352)	4 months ago
Brad House	986bef771c	kqueue: fix allocation size when socket count > 8	4 months ago
Brad House	67db56c341	whitespace	5 months ago
Brad House	46bf21a702	fix	5 months ago
Brad House	fb60be7436	document some RFCs in use	5 months ago
Brad House	f90a81ed81	tests: use std::chrono instead of pulling in ares__tvnow and ares__timeval_remaining (#809 ) This will allow more tests to run even when internal symbols aren't accessible. Fix By: Brad House (@bradh352)	5 months ago
Brad House	8a50fc6c67	win32: swap GetTickCount64() for more precise QueryPerformanceCounters()	5 months ago
Brad House	8f265c9d51	windows 32bit: config change callback needs to be stdcall	5 months ago
Brad House	2c1a20bbc4	thread safety: during ares_destroy() when we cleanup the config change monitoring, it needs to be surrounded by a channel lock	5 months ago
Brad House	51e7590610	1.32.1 release (#807 )	5 months ago
Brad House	805ffbc62b	pthread: use recursive mutexes to allow callbacks to enqueue new c-ares queries. Regression from 1.31.0.	5 months ago
Brad House	595cf21334	don't put a heading on the license	5 months ago
Brad House	9526fc6de1	update release procedure	5 months ago
Brad House	b649b85917	tests: fix compile warning	5 months ago
Brad House	b9d36509f6	more release procedure notes	5 months ago
Brad House	e24f81594e	update release procedure to make it easier to cut and paste	5 months ago
Brad House	71ad08bc39	SonarCloud: fix recently introduced minor codesmells	5 months ago
Brad House	2b6f54bc40	release-1.32.0 (#804 )	5 months ago
Brad House	614bdd88b9	Tests: fix test cleanup race condition (#803 ) There was a thread passed data for processing that was cleaned up before thread exit, and it could cause a use-after-free in the test suite. This doesn't affect c-ares. This was found during trying to reproduce #798, but appears unrelated, don't use a helper thread as it isn't necessary. Fix By: Brad House (@bradh352)	5 months ago
Brad House	378d26144d	DNS RR TXT strings should not be automatically concatenated (#801 ) As per #738, there are usecases where the DNS TXT record strings should not be concatenated like RFC 7208 indicates. We cannot break ABI with those using the new API, so we need to support retrieving the concatenated version as well as a new API to retrieve the individual strings which will be used by `ares_parse_text_reply_ext()` to restore the old behavior prior to c-ares 1.20. Fixes Issue: #738 Fix By: Brad House (@bradh352)	5 months ago
Cheng	64df444e6f	Fix building with UNICODE (#802 ) Use the unicode version of `RegOpenKeyEx` to avoid compilation error caused by string type like: ``` ../../node/deps/cares/src/lib/ares_event_configchg.c(322,9): error: incompatible pointer types passing 'char[62]' to parameter of type 'LPCWSTR' (aka 'const unsigned short *') [-Werror,-Wincompatible-pointer-types] 322 \| "SYSTEM\\CurrentControlSet\\Services\\Tcpip\\Parameters\\Interfaces", \| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ``` Fix By: Cheng (@zcbenz)	5 months ago
Brad House	70f10a85f3	DNS 0x20 implementation (#800 ) This PR enables DNS 0x20 as per https://datatracker.ietf.org/doc/html/draft-vixie-dnsext-dns0x20-00 . DNS 0x20 adds additional entropy to the request by randomly altering the case of the DNS question to help prevent cache poisoning attacks. Google DNS has implemented this support as of 2023, even though this is a proposed and expired standard from 2008: https://groups.google.com/g/public-dns-discuss/c/KxIDPOydA5M There have been documented cases of name server and caching server non-conformance, though it is expected to become more rare, especially since Google has started using this. This can be enabled via the `ARES_FLAG_DNS0x20` flag, which is currently disabled by default. The test cases do however enable this flag to validate this feature. Implementors using this flag will notice that responses will retain the mixed case, but since DNS names are case-insensitive, any proper implementation should not be impacted. There is currently no fallback mechanism implemented as it isn't immediately clear how this may affect a stub resolver like c-ares where we aren't querying the authoritative name server, but instead an intermediate recursive resolver where some domains may return invalid results while others return valid results, all while querying the same nameserver. Likely using DNS cookies as suggested by #620 is a better mechanism to fight cache poisoning attacks for stub resolvers. TCP queries do not use this feature even if the `ARES_FLAG_DNS0x20` flag is specified since they are not subject to cache poisoning attacks. Fixes Issue: #795 Fix By: Brad House (@bradh352)	5 months ago
Brad House	5e1c3a7575	tell google test to print backtraces	5 months ago
Brad House	1dc567d9c0	fix wording in docs	5 months ago
Brad House	17cf8c04e8	revert change that didn't work for #796	5 months ago
Brad House	d2a3d954c4	coverity: fix new false positives	5 months ago
Brad House	c96200353d	valgrind: fix warning in test case	5 months ago
Brad House	51ca744459	Clean up header inclusion, simplification (#797 ) The header inclusion logic in c-ares is hard to follow. Lets try to simplify the way it works to make it easier to understand and less likely to break on new code changes. There's still more work to be done, but this is a good start at simplifying things. Fix By: Brad House (@bradh352)	5 months ago
Brad House	209e7077bb	thread safety enhancements	5 months ago
Brad House	93aa939169	thread deadlock: make sure channel lock isn't used recursively	5 months ago
Brad House	74a64e486a	ares_timeout: missing thread-safety lock	5 months ago
Brad House	ef186fe2a4	remove unused SEND_QUAL_ARG2	5 months ago
Brad House	0d1008355a	remove unneeded warning disablement	5 months ago
Brad House	7d6de797d1	MSVC: Prevent C1041 error error C1041: cannot open program database '....'; if multiple CL.EXE write to the same .PDB file, please use /FS might be output in some conditions, add /FS compiler flag to prevent it. Fixes Issue: #796 Fix By: Brad House (@bradh352)	5 months ago
Brad House	cd1ff7b2f3	remove outdated comment	5 months ago
Brad House	350be9e1f1	mingw32 build fix	5 months ago
Brad House	325c75abd0	don't try to install removed header ares_rules.h	5 months ago
Brad House	e57a5b877b	remove duplicate typedef	5 months ago
Brad House	adc6659486	simplify header include order	5 months ago
Brad House	94b69fbd45	try to fix build	5 months ago
Brad House	9b6f197fec	warning in test	5 months ago
Brad House	381d38d925	forcibly kill bogus warning	5 months ago
Brad House	1b8cfdedc9	build fix	5 months ago
Brad House	bdd08d8dd4	fix warning	5 months ago
Brad House	4b0326e129	try to clean up some windows-specific warnings	5 months ago

1 2 3 4 5 ...

688 Commits (a18a6ad3a11774d4e6fb38b9d5d865643fc0a13d) All Branches Search

688 Commits (a18a6ad3a11774d4e6fb38b9d5d865643fc0a13d)

All Branches