c-ares

218 Commits

14 Branches

97 Tags

23 MiB

Tag: Branch: Tree: 7da53555c2

Commit Graph

Author	SHA1	Message	Date
Douglas R. Reno	761c618084	Watcom Portability Improvements (#509 ) - Modify the Watcom Makefile for the source code reorganization (#352) - Add *.map files into .gitignore - Fix build errors with Watcom's builtin Windows SDK (which is rather outdated). It's smart enough to understand Windows Vista, but doesn't have PMIB_UNICASTIPADDRESS_TABLE or MIB_IPFORWARD_ROW2. It may be possible to use a different Windows SDK with the Watcom compiler, such as the most recent Windows 10 SDK. Alternatively the SDK in OpenWatcom 2.0 (which is in development) should fix this. I have no problems testing this Makefile prior to releases, just give me a ping. Tested with Windows Vista, Windows 7, and Windows 10 using 'adig', 'acountry', and 'ahost'. This also seems to work on Windows XP, though this is likely due to the compiler in use. Fix By: Douglas R. Reno (@renodr) Fixes Bug: #352	2 years ago
Fionn Fitzmaurice	6d6cd5daf6	Avoid buffer overflow in RC4 loop comparison (#336 ) The rc4 function iterates over a buffer of size buffer_len who's maximum value is INT_MAX with a counter of type short that is not guaranteed to have maximum size INT_MAX. In circumstances where short is narrower than int and where buffer_len is larger than the maximum value of a short, it may be possible to loop infinitely as counter will overflow and never be greater than or equal to buffer_len. The solution is to make the comparison be between types of equal width. This commit defines counter as an int. Fix By: Fionn Fitzmaurice (@fionn)	5 years ago

Author

SHA1

Message

Date

Douglas R. Reno

761c618084

Watcom Portability Improvements (#509 )

- Modify the Watcom Makefile for the source code reorganization (#352)
- Add *.map files into .gitignore
- Fix build errors with Watcom's builtin Windows SDK (which is rather
  outdated). It's smart enough to understand Windows Vista, but doesn't
  have PMIB_UNICASTIPADDRESS_TABLE or MIB_IPFORWARD_ROW2.

It may be possible to use a different Windows SDK with the Watcom
compiler, such as the most recent Windows 10 SDK. Alternatively the SDK
in OpenWatcom 2.0 (which is in development) should fix this.

I have no problems testing this Makefile prior to releases, just give me
a ping.

Tested with Windows Vista, Windows 7, and Windows 10 using 'adig',
'acountry', and 'ahost'. This also seems to work on Windows XP, though
this is likely due to the compiler in use.

Fix By: Douglas R. Reno (@renodr)
Fixes Bug: #352

2 years ago

Fionn Fitzmaurice

6d6cd5daf6

Avoid buffer overflow in RC4 loop comparison (#336 )

The rc4 function iterates over a buffer of size buffer_len who's maximum
value is INT_MAX with a counter of type short that is not guaranteed to
have maximum size INT_MAX.

In circumstances where short is narrower than int and where buffer_len
is larger than the maximum value of a short, it may be possible to loop
infinitely as counter will overflow and never be greater than or equal
to buffer_len.

The solution is to make the comparison be between types of equal width.
This commit defines counter as an int.

Fix By: Fionn Fitzmaurice (@fionn)

5 years ago

2 Commits (7da53555c284e896baabdaef441e883bf5245f11)